From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 86D8AA0508; Wed, 6 Apr 2022 00:47:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1A24240E2D; Wed, 6 Apr 2022 00:47:01 +0200 (CEST) Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) by mails.dpdk.org (Postfix) with ESMTP id 23B6D40DF6 for ; Wed, 6 Apr 2022 00:46:58 +0200 (CEST) Received: by mail-pg1-f173.google.com with SMTP id q142so610900pgq.9 for ; Tue, 05 Apr 2022 15:46:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=T5VooQgORV4QwKvAlK4szFL6Q35zGIC3BjnkczrKrik=; b=nXHnR1QRQCrlR6XuGfhjwjBKOSMfwVbBxwA3ZJeFf3Msza0FS/U/JjlVM5BR9hMmuL tcD3oRTJ8kideGS9gOxNr5MRCIG3NGM8bMdrgKZd/ThxRPm4ena/EUUL9eS2Qvv5wSEa d8cjtCxxbSFUS/ZWGsDIZo1gqM8Z8J/e4Bjubm0yUFfvD5w8T1nBxMpt3nehqdMS/iAS sv2N4vcg88MS6gU44KmOUIrj0V/uS2Dh8KvIiGpF63ODDEeYZemSXyAQin6SFo3Y5iWr cwRsqiHgG6QZgO/t6b59WFGHracOdaNH/VFgBTjLPwcBpI7jekw3fhFWz+jlDH8CO5nF DKFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=T5VooQgORV4QwKvAlK4szFL6Q35zGIC3BjnkczrKrik=; b=24uVs9Q1NtXj55nwLWcfkwkIY+atOd06UY09aGP5Jxxpz/OKiOetWbqsapqn62aAv1 wdH6MhDO8dMm32Gw0ultmil61t0intPA1bgcUD8jc3l9rFGaPW3n95M3u7P2A+geAzmY l9tVmlHpStKJ0AcXm1vzyeP2t9YWxllH0DL0rRhGZynW95kwjKYp7MF4Kn+54Y/L6eii 7Ir9Ycoh+d92dA9yBVZ7nOlAgnoOFC2V70mVkzI9WJHNZvxS4xsPqXeg43RQ27FkeHCb ffYX8MDtXU8dRmL+RiQHnqmxuAMqN3L7Dib5AYmFLOdUXmfQtPA4tnamwGw/uGKZ64iE 7giA== X-Gm-Message-State: AOAM533grAtGuaOXaSgp3peWKihDp/jyLHellks6jdwlgPIuMsY0wmhb KvnHKtvT5rchhfGnUhrpqCbj2Fqr3bebBQ== X-Google-Smtp-Source: ABdhPJwokDe64VnBL6hAtVAm5aGMxI2Putu/GODtjurwQJtXMc0QLpZxSSVTGWi5AnywmnTaJCsQLg== X-Received: by 2002:a05:6a00:c8e:b0:4fb:18a6:18f9 with SMTP id a14-20020a056a000c8e00b004fb18a618f9mr5845314pfv.47.1649198818165; Tue, 05 Apr 2022 15:46:58 -0700 (PDT) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id z6-20020a17090a66c600b001ca7dbe1bc2sm3409626pjl.46.2022.04.05.15.46.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Apr 2022 15:46:57 -0700 (PDT) Date: Tue, 5 Apr 2022 15:46:55 -0700 From: Stephen Hemminger To: Li Feng Cc: Anatoly Burakov , dev@dpdk.org Subject: Re: [PATCH v2] eal/linux: enable the hugepage mem dump Message-ID: <20220405154655.60900b0d@hermes.local> In-Reply-To: <20220401091004.3227117-1-fengli@smartx.com> References: <20220308094125.2716847-1-fengli@smartx.comOD> <20220401091004.3227117-1-fengli@smartx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 1 Apr 2022 17:10:04 +0800 Li Feng wrote: > These hugepages include important structures. we should dump these > hugepages into a coredump file for debugging when generating a coredump. > > Signed-off-by: Li Feng > --- > lib/eal/linux/eal_memalloc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/lib/eal/linux/eal_memalloc.c b/lib/eal/linux/eal_memalloc.c > index f8b1588cae..93c4f396cf 100644 > --- a/lib/eal/linux/eal_memalloc.c > +++ b/lib/eal/linux/eal_memalloc.c > @@ -677,6 +677,8 @@ alloc_seg(struct rte_memseg *ms, void *addr, int socket_id, > __func__); > #endif > > + eal_mem_set_dump(addr, alloc_sz, true); > + > huge_recover_sigbus(); > > ms->addr = addr; Don't merge this patch as is please; it would cause a lot of pain in a cloud environment. In our environment core dumps are collected (via systemd) and uploaded to a central server. With this kind of change the processing would get overloaded with multi-gigabyte core dump size. Probably couldn't even save a core dump on these kind of smart nics. This needs to be optional (from command line) and default to the current behavior (not dumping huge pages).