From: Ke Zhang <ke1x.zhang@intel.com>
To: chas3@att.com, humin29@huawei.com, dev@dpdk.org
Cc: Ke Zhang <ke1x.zhang@intel.com>
Subject: [PATCH] net/bonding: fix rss key configuration when the key length is 52
Date: Thu, 7 Apr 2022 09:36:42 +0000 [thread overview]
Message-ID: <20220407093642.44900-1-ke1x.zhang@intel.com> (raw)
when creating a bonding device, if the slave device's rss key length
is 52, then bonding device will be same as slave, in function
bond_ethdev_configure(), the default_rss_key length is 40, it
is not matched, so it should calculate a new key for bonding
device if the deault key could not be used.
Signed-off-by: Ke Zhang <ke1x.zhang@intel.com>
---
drivers/net/bonding/rte_eth_bond_pmd.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
index b305b6a35b..4214b33f40 100644
--- a/drivers/net/bonding/rte_eth_bond_pmd.c
+++ b/drivers/net/bonding/rte_eth_bond_pmd.c
@@ -3617,13 +3617,13 @@ bond_ethdev_configure(struct rte_eth_dev *dev)
internals->rss_key_len);
} else {
if (internals->rss_key_len > sizeof(default_rss_key)) {
- RTE_BOND_LOG(ERR,
- "There is no suitable default hash key");
- return -EINVAL;
+ /* If the rss_key_len is 52, it should calculate the hash key */
+ for (i = 0; i < internals->rss_key_len; i++)
+ internals->rss_key[i] = (uint8_t)rte_rand();
+ } else {
+ memcpy(internals->rss_key, default_rss_key,
+ internals->rss_key_len);
}
-
- memcpy(internals->rss_key, default_rss_key,
- internals->rss_key_len);
}
for (i = 0; i < RTE_DIM(internals->reta_conf); i++) {
--
2.25.1
next reply other threads:[~2022-04-07 9:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 9:36 Ke Zhang [this message]
2022-04-08 2:32 ` Min Hu (Connor)
2022-04-11 3:06 ` Zhang, Ke1X
2022-04-12 15:19 ` Stephen Hemminger
2022-04-13 9:03 ` Min Hu (Connor)
2022-04-13 16:12 ` Stephen Hemminger
2022-04-11 3:02 ` [PATCH v2 1/1] " Ke Zhang
2022-04-11 3:41 ` Min Hu (Connor)
2022-04-11 5:40 ` [PATCH v3 " Ke Zhang
2022-04-13 9:01 ` Min Hu (Connor)
2022-05-04 16:32 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220407093642.44900-1-ke1x.zhang@intel.com \
--to=ke1x.zhang@intel.com \
--cc=chas3@att.com \
--cc=dev@dpdk.org \
--cc=humin29@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).