From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 80F96A0093;
Mon, 11 Apr 2022 13:00:23 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 7384E4114D;
Mon, 11 Apr 2022 13:00:23 +0200 (CEST)
Received: from us-smtp-delivery-124.mimecast.com
(us-smtp-delivery-124.mimecast.com [170.10.133.124])
by mails.dpdk.org (Postfix) with ESMTP id AEF1740F35
for <dev@dpdk.org>; Mon, 11 Apr 2022 13:00:22 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1649674822;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=1sYDCEGSntc9QQdI0aZrXjKbkxWAAW0ypyDYJcC9wOM=;
b=ctKjIXIePJf4apLJBBChfM201lBkPAjVVk4yQo5ArAX4V8RhpqQmZKUo/edzGEuhlXOjUk
wo36FMH44/JV/tdg2KiTMCdLTMhz5y+GtBQfD+nEyAMRSIwYwhJKxSyUotSiTue8SPYZQw
jTJeJLx4/Q9/mcb0X0FSG4pTMzJFhX8=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
[66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
(version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
us-mta-520-dJS9gjj5N06DMagPCic0CQ-1; Mon, 11 Apr 2022 07:00:21 -0400
X-MC-Unique: dJS9gjj5N06DMagPCic0CQ-1
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com
[10.11.54.7])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 93519811E76;
Mon, 11 Apr 2022 11:00:20 +0000 (UTC)
Received: from dmarchan.remote.csb (unknown [10.40.192.83])
by smtp.corp.redhat.com (Postfix) with ESMTP id 28AF7145B989;
Mon, 11 Apr 2022 11:00:19 +0000 (UTC)
From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: maxime.coquelin@redhat.com, stephen@networkplumber.org,
chenbo.xia@intel.com, jiayu.hu@intel.com, yuanx.wang@intel.com,
xuan.ding@intel.com
Subject: [RFC PATCH v3 0/8] vhost lock annotations
Date: Mon, 11 Apr 2022 13:00:05 +0200
Message-Id: <20220411110013.18624-1-david.marchand@redhat.com>
In-Reply-To: <20220328121758.26632-1-david.marchand@redhat.com>
References: <20220328121758.26632-1-david.marchand@redhat.com>
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7
Authentication-Results: relay.mimecast.com;
auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="US-ASCII"; x-default=true
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
vhost internals involves multiple locks to protect data access by
multiple threads.
This series is a try at using clang thread safety checks [1] to catch
issues during compilation: EAL spinlock and rwlock are annotated and
vhost code is instrumented so that clang can statically check
correctness.
This is still a work in progress (some documentation and a release note
update are missing).
Those annotations are quite heavy to maintain because the full path of
code must be annotated, but I think it is worth using.
1: https://clang.llvm.org/docs/ThreadSafetyAnalysis.html
Depends-on: patch-108840 ("vhost: fix missing virtqueue lock protection")
--
David Marchand
Changes since RFC v2:
- fixed trylock annotations for rwlock,
- annotated _tm flavors of spinlock and rwlock,
- removed Maxime vhost fix from series (since Mimecast does not like
me sending Maxime patch...), added a dependency on original fix
as a hint for reviewers,
- renamed attributes,
Changes since RFC v1:
- Cc'd people who have pending patches for vhost,
- moved annotations to EAL and removed wrappers in vhost,
- as a result of moving to EAL, this series will be tested against
the main repo, so patch 1 has been kept as part of the series
even if already applied to next-virtio,
- refined/split patches and annotated all spinlocks in vhost,
David Marchand (8):
eal: annotate spinlock and rwlock
vhost: annotate virtqueue access lock
vhost: fix async access
vhost: annotate async accesses
vhost: annotate need reply handling
vhost: annotate vDPA device list accesses
vhost: annotate IOTLB locks
vhost: enable lock check
drivers/meson.build | 5 ++
lib/eal/arm/include/rte_rwlock.h | 4 ++
lib/eal/arm/include/rte_spinlock.h | 6 ++
lib/eal/include/generic/rte_rwlock.h | 27 +++++++--
lib/eal/include/generic/rte_spinlock.h | 40 +++++++++----
lib/eal/include/meson.build | 1 +
lib/eal/include/rte_lock_annotations.h | 67 +++++++++++++++++++++
lib/eal/ppc/include/rte_rwlock.h | 4 ++
lib/eal/ppc/include/rte_spinlock.h | 9 +++
lib/eal/x86/include/rte_rwlock.h | 4 ++
lib/eal/x86/include/rte_spinlock.h | 9 +++
lib/meson.build | 5 ++
lib/vhost/iotlb.h | 8 +++
lib/vhost/meson.build | 2 +
lib/vhost/vdpa.c | 18 +++---
lib/vhost/vhost.c | 50 ++++++++--------
lib/vhost/vhost.h | 26 ++++++---
lib/vhost/vhost_crypto.c | 7 +++
lib/vhost/vhost_user.c | 6 ++
lib/vhost/virtio_net.c | 80 ++++++++++++++++++++------
20 files changed, 306 insertions(+), 72 deletions(-)
create mode 100644 lib/eal/include/rte_lock_annotations.h
--
2.23.0