From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: dev@dpdk.org, thomas@monjalon.net, anatoly.burakov@intel.com,
Narcisa Vasile <navasile@microsoft.com>
Subject: Re: [PATCH 3/3] test/threads: add unit test for thread API
Date: Tue, 12 Apr 2022 01:52:58 +0300 [thread overview]
Message-ID: <20220412015258.10053d7f@sovereign> (raw)
In-Reply-To: <20220409085631.GB4153@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
2022-04-09 01:56 (UTC-0700), Tyler Retzlaff:
> On Fri, Apr 08, 2022 at 05:01:45PM +0300, Dmitry Kozlyuk wrote:
> > 2022-04-01 06:29 (UTC-0700), Tyler Retzlaff:
> > [...]
> > > +static int
> > > +test_thread_affinity(void)
> > > +{
> > > + pthread_t id;
> > > + rte_thread_t thread_id;
> > > +
> > > + RTE_TEST_ASSERT(pthread_create(&id, NULL, thread_main, NULL) == 0,
> > > + "Failed to create thread");
> > > + thread_id.opaque_id = id;
> >
> > The need for this hack means that the new API is unusable in practice.
> > I think functions to get the current thread ID and to compare IDs
> > must be the part of this series to accept this unit test patch.
>
> are you proposing adding rte_thread_self and rte_thread_equals to this
> series? i'm not sure i understand how that helps? while maybe the unit
> test could be re-written in some fashion to use rte_thread_self it still
> wouldn't do much for practically using the api outside of the test.
Just rte_thread_self() should be enough; see below.
How this helps: the series becomes complete, because there is enough API to
verify it works without assumptions about implementation.
[...]
> if there is an absolute need to start using the api introduced in this
> series outside of the unit test we could as a part of the __experimental
> apis offer a function that formalizes the conversion to rte_thread_t from
> pthread_t. the function would only be kept as long as needed and removed
> when no longer necessary.
I rather meant this:
main thread:
init barrier
create thread
enter barrier (wait)
use shared thread ID
thread:
init shared thread ID from rte_thread_self()
enter barrier (will unblock)
After you will add rte_thread_create() in the subsequent series,
the same logic will suit for checking that rte_thread_self()
returns the proper ID.
next prev parent reply other threads:[~2022-04-11 22:53 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 13:29 [PATCH 0/3] add eal functions for thread affinity Tyler Retzlaff
2022-04-01 13:29 ` [PATCH 1/3] eal/windows: translate Windows errors to errno-style errors Tyler Retzlaff
2022-04-01 13:29 ` [PATCH 2/3] eal: implement functions for get/set thread affinity Tyler Retzlaff
2022-04-08 14:01 ` Dmitry Kozlyuk
2022-04-09 8:02 ` Tyler Retzlaff
2022-04-01 13:29 ` [PATCH 3/3] test/threads: add unit test for thread API Tyler Retzlaff
2022-04-08 14:01 ` Dmitry Kozlyuk
2022-04-09 8:56 ` Tyler Retzlaff
2022-04-11 22:52 ` Dmitry Kozlyuk [this message]
2022-04-08 8:57 ` [PATCH 0/3] add eal functions for thread affinity David Marchand
2022-04-08 13:46 ` Tyler Retzlaff
2022-04-11 7:32 ` David Marchand
2022-04-12 10:43 ` [PATCH v2 0/4] add eal functions for thread affinity and self Tyler Retzlaff
2022-04-12 10:43 ` [PATCH v2 1/4] eal/windows: translate Windows errors to errno-style errors Tyler Retzlaff
2022-04-12 17:26 ` Menon, Ranjit
2022-04-13 7:07 ` Tyler Retzlaff
2022-04-25 8:25 ` David Marchand
2022-04-25 8:52 ` Tyler Retzlaff
2022-04-12 10:43 ` [PATCH v2 2/4] eal: add basic thread ID and current thread identifier API Tyler Retzlaff
2022-04-12 10:43 ` [PATCH v2 3/4] eal: implement functions for get/set thread affinity Tyler Retzlaff
2022-04-13 7:30 ` Tyler Retzlaff
2022-04-12 10:43 ` [PATCH v2 4/4] test/threads: add unit test for thread API Tyler Retzlaff
2022-04-13 7:43 ` [PATCH v3 0/4] add eal functions for thread affinity and self Tyler Retzlaff
2022-04-13 7:43 ` [PATCH v3 1/4] eal/windows: translate Windows errors to errno-style errors Tyler Retzlaff
2022-04-13 7:43 ` [PATCH v3 2/4] eal: add basic thread ID and current thread identifier API Tyler Retzlaff
2022-04-25 8:26 ` David Marchand
2022-04-25 8:53 ` Tyler Retzlaff
2022-04-13 7:43 ` [PATCH v3 3/4] eal: implement functions for get/set thread affinity Tyler Retzlaff
2022-04-25 8:26 ` David Marchand
2022-04-25 8:55 ` Tyler Retzlaff
2022-04-13 7:43 ` [PATCH v3 4/4] test/threads: add unit test for thread API Tyler Retzlaff
2022-04-26 7:50 ` [PATCH v4 0/3] add eal functions for thread affinity and self Tyler Retzlaff
2022-04-26 7:50 ` [PATCH v4 1/3] eal: add basic thread ID and current thread identifier API Tyler Retzlaff
2022-05-01 9:18 ` Dmitry Kozlyuk
2022-04-26 7:50 ` [PATCH v4 2/3] eal: implement functions for get/set thread affinity Tyler Retzlaff
2022-05-01 9:18 ` Dmitry Kozlyuk
2022-04-26 7:50 ` [PATCH v4 3/3] test/threads: add unit test for thread API Tyler Retzlaff
2022-05-01 9:18 ` Dmitry Kozlyuk
2022-05-03 9:38 ` Tyler Retzlaff
2022-05-04 15:46 ` [PATCH v5 0/3] add eal functions for thread affinity and self Tyler Retzlaff
2022-05-04 15:46 ` [PATCH v5 1/3] eal: add basic thread ID and current thread identifier API Tyler Retzlaff
2022-05-04 22:55 ` Konstantin Ananyev
2022-05-05 7:11 ` Tyler Retzlaff
2022-05-06 19:37 ` Konstantin Ananyev
2022-05-07 8:25 ` Morten Brørup
2022-05-07 13:57 ` Konstantin Ananyev
2022-05-07 19:47 ` Morten Brørup
2022-05-10 21:52 ` Konstantin Ananyev
2022-05-11 7:17 ` Tyler Retzlaff
2022-05-11 7:36 ` Morten Brørup
2022-05-11 22:27 ` Konstantin Ananyev
2022-05-04 15:46 ` [PATCH v5 2/3] eal: implement functions for get/set thread affinity Tyler Retzlaff
2022-05-04 15:46 ` [PATCH v5 3/3] test/threads: add unit test for thread API Tyler Retzlaff
2022-05-12 13:14 ` [PATCH v6 0/3] add eal functions for thread affinity and self Tyler Retzlaff
2022-05-12 13:14 ` [PATCH v6 1/3] eal: add basic thread ID and current thread identifier API Tyler Retzlaff
2022-05-15 22:02 ` Konstantin Ananyev
2022-05-16 6:21 ` Tyler Retzlaff
2022-05-12 13:14 ` [PATCH v6 2/3] eal: implement functions for get/set thread affinity Tyler Retzlaff
2022-05-12 13:14 ` [PATCH v6 3/3] test/threads: add unit test for thread API Tyler Retzlaff
2022-05-19 15:05 ` [PATCH v6 0/3] add eal functions for thread affinity and self David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220412015258.10053d7f@sovereign \
--to=dmitry.kozliuk@gmail.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=navasile@microsoft.com \
--cc=roretzla@linux.microsoft.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).