From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 17AE3A050A; Tue, 12 Apr 2022 17:19:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D4EC540DF6; Tue, 12 Apr 2022 17:19:36 +0200 (CEST) Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by mails.dpdk.org (Postfix) with ESMTP id C5A8340E09 for <dev@dpdk.org>; Tue, 12 Apr 2022 17:19:35 +0200 (CEST) Received: by mail-pj1-f46.google.com with SMTP id z6-20020a17090a398600b001cb9fca3210so3375039pjb.1 for <dev@dpdk.org>; Tue, 12 Apr 2022 08:19:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BmX5kx85rfHa1ZOe/cOZXAUfTyZCyJB5m8DQufqIdyQ=; b=gX5PXOGW6heLwKhK/iqNXC43fcqeNvDkIcHr4o0Z1CjxN0nx1Hke7GN60j4gTj7d7r WDSi14RmmXhjbIuTiKe2KSoTjOD5ErPXBsQDg/Hos7xzX9NSTBUfVQC0BK/CHZFzw9c6 sJkRdjxERudn1xij9ssp8YM/MJWB8bLsPaJa5abxG5E05cy/4pEl94g1mqCU1CMNGK9x wLrLnNtruPhQciAxBqLqCPrbwgJH1DQHC43Z8tQuSlyQ5OOOXd7xXjVjH9mV0jOI5UHb xlw9S8LbRZRaGwmyhF82IragAnjUrNVdsnjxjBjKDuLxPOcOnD6Ui8XDqybOdiRUArW+ YRiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BmX5kx85rfHa1ZOe/cOZXAUfTyZCyJB5m8DQufqIdyQ=; b=czfDoAqnvcsdLeGpII5w5MnPi+tbz2WOBXInw9LO55MSDtkjCdKO4KZx/F+aS7Ddws XVUuvGUDhDVr4Xa3OCO81Xn5D8uGT+MwiQRN59+DCcy+niBrjrdZ8/c24YQsWmYCUGfh 8MOAvBan+VeqI6umM606VKu7qIyw15U8LX3YwnU3shyJoV1GqolIwMmPLQcQUklc+jcX w0LI0V4czi3siKEBxGieRMDldGyiKFV5CmQoQNg2gg6gkJ1L+rim97/yj7yJL0ce4DEH muSGqmAB75w1YEHguANMYW3gZbMu0sKuuCdUfP7JMBqhiwxafSLUXxGFNn7IOs/Oohuh VGfg== X-Gm-Message-State: AOAM532UbMlYwRw2qOdn3W9xEvoGvFguIuT2hMNa7Pm+FmHyfHbiZWAk zj9ULB4+Zxr4mRQ4L8oxhK/qG2rJmQr1KA== X-Google-Smtp-Source: ABdhPJzFocTXsj+Ddz1k6ojzBWMh7rdpa7YOFh5niXGcPg0SlDWDcugumQXhBd1ayRSqzC9sVFF81g== X-Received: by 2002:a17:902:e74d:b0:156:9d3c:4271 with SMTP id p13-20020a170902e74d00b001569d3c4271mr37655234plf.79.1649776774901; Tue, 12 Apr 2022 08:19:34 -0700 (PDT) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id x193-20020a6286ca000000b00505fe80736csm2973164pfd.2.2022.04.12.08.19.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 08:19:34 -0700 (PDT) Date: Tue, 12 Apr 2022 08:19:30 -0700 From: Stephen Hemminger <stephen@networkplumber.org> To: "Zhang, Ke1X" <ke1x.zhang@intel.com> Cc: "Min Hu (Connor)" <humin29@huawei.com>, "chas3@att.com" <chas3@att.com>, "dev@dpdk.org" <dev@dpdk.org> Subject: Re: [PATCH] net/bonding: fix rss key configuration when the key length is 52 Message-ID: <20220412081930.293e4384@hermes.local> In-Reply-To: <DM8PR11MB5701A8EA22AA931EB766421CDCEA9@DM8PR11MB5701.namprd11.prod.outlook.com> References: <20220407093642.44900-1-ke1x.zhang@intel.com> <66552a01-6f88-b0b2-a69f-24d0484ea36d@huawei.com> <DM8PR11MB5701A8EA22AA931EB766421CDCEA9@DM8PR11MB5701.namprd11.prod.outlook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Mon, 11 Apr 2022 03:06:46 +0000 "Zhang, Ke1X" <ke1x.zhang@intel.com> wrote: > This is a coding waring as below: > > _coding style issues_ > > WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? > #64: > when creating a bonding device, if the slave device's rss key length > > WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? > #65: > is 52, then bonding device will be same as slave, in function > > total: 0 errors, 2 warnings, 0 checks, 19 lines checked > > the 'slave' is correct, for exsample, testpmd cmd: > add bonding slave 0 2 Just a heads up, for 22.11 I plan to replace/deprecate use of master/slave terminology in bonding driver. The terms master/slave are legacy and most commercial products have switched to the terms from the 802 standard.