From: "Min Hu (Connor)" <humin29@huawei.com>
To: <dev@dpdk.org>
Cc: "Min Hu (Connor)" <humin29@huawei.com>,
Yisen Zhuang <yisen.zhuang@huawei.com>,
Lijun Ou <oulijun@huawei.com>
Subject: [PATCH 4/5] net/hns3: fix dump TM info
Date: Thu, 14 Apr 2022 21:00:55 +0800 [thread overview]
Message-ID: <20220414130056.37428-5-humin29@huawei.com> (raw)
In-Reply-To: <20220414130056.37428-1-humin29@huawei.com>
TM info should not be dump when the NIC does not support TM.
This patch fixed it.
Fixes: e4cfe6bb9114 ("net/hns3: dump TM configuration info")
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
drivers/net/hns3/hns3_ethdev_dump.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/net/hns3/hns3_ethdev_dump.c b/drivers/net/hns3/hns3_ethdev_dump.c
index 9934e4e1cc..1548d231fc 100644
--- a/drivers/net/hns3/hns3_ethdev_dump.c
+++ b/drivers/net/hns3/hns3_ethdev_dump.c
@@ -709,7 +709,6 @@ get_tm_conf_queue_format_info(FILE *file, struct hns3_tm_node **queue_node,
#define PERLINE_STRIDE 8
#define LINE_BUF_SIZE 1024
uint32_t i, j, line_num, start_queue, end_queue;
- char tmpbuf[LINE_BUF_SIZE] = {0};
line_num = (nb_tx_queues + PERLINE_QUEUES - 1) / PERLINE_QUEUES;
for (i = 0; i < line_num; i++) {
@@ -727,7 +726,7 @@ get_tm_conf_queue_format_info(FILE *file, struct hns3_tm_node **queue_node,
queue_node[j] ? queue_node_tc[j] :
HNS3_MAX_TC_NUM);
}
- fprintf(file, "%s\n", tmpbuf);
+ fprintf(file, "\n");
}
}
@@ -767,9 +766,13 @@ get_tm_conf_queue_node_info(FILE *file, struct hns3_tm_conf *conf,
static void
get_tm_conf_info(FILE *file, struct rte_eth_dev *dev)
{
+ struct hns3_hw *hw = HNS3_DEV_PRIVATE_TO_HW(dev->data->dev_private);
struct hns3_pf *pf = HNS3_DEV_PRIVATE_TO_PF(dev->data->dev_private);
struct hns3_tm_conf *conf = &pf->tm_conf;
+ if (!hns3_dev_get_support(hw, TM))
+ return;
+
fprintf(file, " - TM config info:\n");
fprintf(file,
"\t -- nb_leaf_nodes_max=%u nb_nodes_max=%u\n"
--
2.33.0
next prev parent reply other threads:[~2022-04-14 13:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-14 13:00 [PATCH 0/5] refactor for device info dump Min Hu (Connor)
2022-04-14 13:00 ` [PATCH 1/5] net/hns3: refactor adapter state dump Min Hu (Connor)
2022-04-14 13:00 ` [PATCH 2/5] net/hns3: refactor feature capability dump Min Hu (Connor)
2022-04-14 13:00 ` [PATCH 3/5] net/hns3: refactor queue info dump Min Hu (Connor)
2022-04-14 13:00 ` Min Hu (Connor) [this message]
2022-04-14 13:00 ` [PATCH 5/5] net/hns3: fix dump device info Min Hu (Connor)
2022-05-05 16:28 ` [PATCH 0/5] refactor for device info dump Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220414130056.37428-5-humin29@huawei.com \
--to=humin29@huawei.com \
--cc=dev@dpdk.org \
--cc=oulijun@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).