* [PATCH] crypto/mlx5: fix login cleanup
@ 2022-04-18 11:05 Raja Zidane
2022-04-28 10:14 ` [EXT] " Akhil Goyal
0 siblings, 1 reply; 2+ messages in thread
From: Raja Zidane @ 2022-04-18 11:05 UTC (permalink / raw)
To: dev; +Cc: matan
In case of a probing failure caused by wrong devarg provided,
login isn't destroyed when exiting.
Destroy login on failure.
Fixes: ba707cdb6da2 ("crypto/mlx5: fix queue size configuration")
Signed-off-by: Raja Zidane <rzidane@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
---
drivers/crypto/mlx5/mlx5_crypto.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/crypto/mlx5/mlx5_crypto.c b/drivers/crypto/mlx5/mlx5_crypto.c
index e14f867797..d0901f3b7c 100644
--- a/drivers/crypto/mlx5/mlx5_crypto.c
+++ b/drivers/crypto/mlx5/mlx5_crypto.c
@@ -947,6 +947,7 @@ mlx5_crypto_dev_probe(struct mlx5_common_device *cdev,
ret = mlx5_crypto_configure_wqe_size(priv,
cdev->config.hca_attr.max_wqe_sz_sq, devarg_prms.max_segs_num);
if (ret) {
+ claim_zero(mlx5_devx_cmd_destroy(priv->login_obj));
mlx5_devx_uar_release(&priv->uar);
rte_cryptodev_pmd_destroy(priv->crypto_dev);
return -1;
--
2.21.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: [EXT] [PATCH] crypto/mlx5: fix login cleanup
2022-04-18 11:05 [PATCH] crypto/mlx5: fix login cleanup Raja Zidane
@ 2022-04-28 10:14 ` Akhil Goyal
0 siblings, 0 replies; 2+ messages in thread
From: Akhil Goyal @ 2022-04-28 10:14 UTC (permalink / raw)
To: Raja Zidane, dev; +Cc: matan, stable
> In case of a probing failure caused by wrong devarg provided,
> login isn't destroyed when exiting.
>
> Destroy login on failure.
>
> Fixes: ba707cdb6da2 ("crypto/mlx5: fix queue size configuration")
>
> Signed-off-by: Raja Zidane <rzidane@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
Cc: stable@dpdk.org
Applied to dpdk-next-crypto
Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-28 10:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-18 11:05 [PATCH] crypto/mlx5: fix login cleanup Raja Zidane
2022-04-28 10:14 ` [EXT] " Akhil Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).