* [dpdk-dev] [PATCH] net/cnxk: fix error message setting on failure
@ 2022-04-19 6:34 psatheesh
2022-05-03 6:09 ` Jerin Jacob
0 siblings, 1 reply; 2+ messages in thread
From: psatheesh @ 2022-04-19 6:34 UTC (permalink / raw)
To: Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao
Cc: dev, Satheesh Paul, stable
From: Satheesh Paul <psatheesh@marvell.com>
Set the error message with rte_flow_error_set() api
when flow parsing fails.
Fixes: 8c009b4505e ("net/cnxk: support flow API")
Cc: stable@dpdk.org
Signed-off-by: Satheesh Paul <psatheesh@marvell.com>
Reviewed-by: Kiran Kumar Kokkilagadda <kirankumark@marvell.com>
---
drivers/net/cnxk/cnxk_flow.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/net/cnxk/cnxk_flow.c b/drivers/net/cnxk/cnxk_flow.c
index 8763ca63d6..2b13352312 100644
--- a/drivers/net/cnxk/cnxk_flow.c
+++ b/drivers/net/cnxk/cnxk_flow.c
@@ -297,7 +297,14 @@ cnxk_flow_validate(struct rte_eth_dev *eth_dev,
return rc;
}
- return roc_npc_flow_parse(npc, &in_attr, in_pattern, in_actions, &flow);
+ rc = roc_npc_flow_parse(npc, &in_attr, in_pattern, in_actions, &flow);
+
+ if (rc) {
+ rte_flow_error_set(error, 0, rc, NULL,
+ "Flow validation failed");
+ return rc;
+ }
+ return 0;
}
struct roc_npc_flow *
--
2.25.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] net/cnxk: fix error message setting on failure
2022-04-19 6:34 [dpdk-dev] [PATCH] net/cnxk: fix error message setting on failure psatheesh
@ 2022-05-03 6:09 ` Jerin Jacob
0 siblings, 0 replies; 2+ messages in thread
From: Jerin Jacob @ 2022-05-03 6:09 UTC (permalink / raw)
To: Satheesh Paul, Ferruh Yigit, Andrew Rybchenko
Cc: Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao,
dpdk-dev, dpdk stable
On Tue, Apr 19, 2022 at 12:04 PM <psatheesh@marvell.com> wrote:
>
> From: Satheesh Paul <psatheesh@marvell.com>
>
> Set the error message with rte_flow_error_set() api
> when flow parsing fails.
>
> Fixes: 8c009b4505e ("net/cnxk: support flow API")
> Cc: stable@dpdk.org
>
> Signed-off-by: Satheesh Paul <psatheesh@marvell.com>
> Reviewed-by: Kiran Kumar Kokkilagadda <kirankumark@marvell.com>
Applied to dpdk-next-net-mrvl/for-next-net. Thanks
> ---
> drivers/net/cnxk/cnxk_flow.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/cnxk/cnxk_flow.c b/drivers/net/cnxk/cnxk_flow.c
> index 8763ca63d6..2b13352312 100644
> --- a/drivers/net/cnxk/cnxk_flow.c
> +++ b/drivers/net/cnxk/cnxk_flow.c
> @@ -297,7 +297,14 @@ cnxk_flow_validate(struct rte_eth_dev *eth_dev,
> return rc;
> }
>
> - return roc_npc_flow_parse(npc, &in_attr, in_pattern, in_actions, &flow);
> + rc = roc_npc_flow_parse(npc, &in_attr, in_pattern, in_actions, &flow);
> +
> + if (rc) {
> + rte_flow_error_set(error, 0, rc, NULL,
> + "Flow validation failed");
> + return rc;
> + }
> + return 0;
> }
>
> struct roc_npc_flow *
> --
> 2.25.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-03 6:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-19 6:34 [dpdk-dev] [PATCH] net/cnxk: fix error message setting on failure psatheesh
2022-05-03 6:09 ` Jerin Jacob
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).