From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A3FF6A00BE; Wed, 20 Apr 2022 01:09:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 431E24068E; Wed, 20 Apr 2022 01:09:48 +0200 (CEST) Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by mails.dpdk.org (Postfix) with ESMTP id 6FF0940687 for ; Wed, 20 Apr 2022 01:09:47 +0200 (CEST) Received: by mail-pf1-f171.google.com with SMTP id bo5so220647pfb.4 for ; Tue, 19 Apr 2022 16:09:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YSYYx8J1vOSwvPXG/IyHCYKhBsNrHunlxfT6XXIgNys=; b=aPRVnXyR3ngB/4C/l5nH1aGQHCfLahRLDet4M6SVWpnaZspb3Z9Us4fOQHNf65ojNg A4N5ocTQR5Rju/wdbsjD0AX1AwxB+EiTRjBCmmxK09/8Zn1ED6tZ5+emJhHyJfBXe5dV WYn+QRR3pUtDRGrJRMiLaxJN5KTQriZisnR0vnCNlihchQxzLlvBLyy0o4qYpSpLw4LJ 9DuINxy6d9LNUBWwdsB3P5WngRGhTRwQUACdXwS7DCEOhZanSG1XN58/65Y2SQxxY3Ym LPUMnCgOeqEcdkRcRnHoAx6mjWH+iJLXw9Omdudb6O2lbrhouAtL/JQ5Lv5+r4MSnmKW V0ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YSYYx8J1vOSwvPXG/IyHCYKhBsNrHunlxfT6XXIgNys=; b=seDviS9AB0QuLQ8/tUdt8D/pxMl9Fi2FZAbEx4yadT6muGfosyHLGi1gkaaPgODPYJ NQTCBJHwSXbI5h42KpE8s2icWCHk54RWll4N45Hks/p6A/iKYCWNFXmEVgTgg3BWD/Qa 6iDZWIsV+FJbsOPEsNmKj9Iu42/Gbwo3tGCfwtPD0vAGmtxIEfQ4OM8FfTY6w6bV47nT wuaVScOzDjtvAyOFNfST8vjsP+OJbuwSDYPSF8mWcFl4MQwPeSELwIcQK7kZvzJ16HSf YjS1BTJhDPwI6QhCQFTUB06rq1x4pVlOR+zpdGTDLj8CW8LwNDY5h+sZ8OQhwpZTWkcT Uprg== X-Gm-Message-State: AOAM532XJgyJVRHXWDJlnxBWONMWe1PdaKN0FKGJ6dqsGmqR2LdZLJ2V Q7NPiyleOV52/QPfNtTgnnjvrg== X-Google-Smtp-Source: ABdhPJwG7a8GgyFoiwMqR24gOPvK1Ode9CUxguWKjUxAUDLCDCTKMWZOEy/PNqkYT4UIqF0cvSD9dA== X-Received: by 2002:a65:6e82:0:b0:381:71c9:9856 with SMTP id bm2-20020a656e82000000b0038171c99856mr16740851pgb.316.1650409786326; Tue, 19 Apr 2022 16:09:46 -0700 (PDT) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id p27-20020a056a000a1b00b004f3f63e3cf2sm19437135pfh.58.2022.04.19.16.09.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Apr 2022 16:09:45 -0700 (PDT) Date: Tue, 19 Apr 2022 16:09:42 -0700 From: Stephen Hemminger To: =?UTF-8?B?TWljaGHFgg==?= Krawczyk Cc: Amiya Mohakud , dev , Sachin Kanoje , Megha Punjani , Sharad Saha , Eswar Sadaram , "Brandes, Shai" , ena-dev Subject: Re: DPDK:20.11.1: net/ena crash while fetching xstats Message-ID: <20220419160942.75fd8703@hermes.local> In-Reply-To: References: <20220419080150.2511dee2@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 19 Apr 2022 22:27:32 +0200 Micha=C5=82 Krawczyk wrote: > Thanks Stephen, indeed the issue reproduces in the secondary process. >=20 > Basically ENA v2.2.1 is not MP aware, meaning it cannot be used safely > from the secondary process. The main obstacle is the admin queue which > is used for processing the hardware requests which can be used safely > only from the primary process. It's not strictly a bug, as we weren't > exposing 'MP Awareness' in the PMD features list, it's more like a > lack of proper MP support. >=20 > The latest ENA PMD release should be MP safe. We currently don't have > PMD backport ready for the older LTS release (but we're planning to do > so for ENA v2.6.0 on the amzn-drivers repository: > https://github.com/amzn/amzn-drivers/tree/master/userspace/dpdk).=20 I wish that ENA did not have its own versioning scheme. Driver versions are meaningful only to the driver writer/vendor, they don't help the end user. Since backporting is not part of stable process. I suggest doing what XDP did for 21.11 and earlier releases. diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 634c97acf60d..3778349f3fe9 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -3212,6 +3212,12 @@ static int ena_rx_queue_intr_disable(struct rte_eth_= dev *dev, static int eth_ena_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, struct rte_pci_device *pci_dev) { + if (rte_eal_process_type() =3D=3D RTE_PROC_SECONDARY) { + PMD_INIT_LOG(ERR, + "Ena PMD does not support secondary processes\n= "); + return -ENOTSUP; + } + return rte_eth_dev_pci_generic_probe(pci_dev, sizeof(struct ena_adapter), eth_ena_dev_init); }