From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 354BAA00BE; Thu, 21 Apr 2022 22:08:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1006840042; Thu, 21 Apr 2022 22:08:33 +0200 (CEST) Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by mails.dpdk.org (Postfix) with ESMTP id 7017040040 for <dev@dpdk.org>; Thu, 21 Apr 2022 22:08:31 +0200 (CEST) Received: by mail-pl1-f176.google.com with SMTP id n18so6154247plg.5 for <dev@dpdk.org>; Thu, 21 Apr 2022 13:08:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XgLxq081x7Q6pmPf0XqL+c1fEHHMqHdKV29fJNQQ4KA=; b=nv/O2SE2ybtlp/l9RzM9jIVEqjw6x9eK9pAhsRPgwma0adCj6CuFyJBSKt/Rb3H19m gfuBN+Un+kKuFaeoPW96wPNUh6PaEwW7sCMRrlNpvw/xJ4lOZ0fAMLItDeCxfB6AXQzW AJed32ONkim6Mw6Rv+mQeG9WonmqryrzULmJJxL1YAbs3OljZ49rKZ6ibD5SZqpZNeVS DUalWWQ73P0ZnaH7iAcCql08k+26ov6Qy8G//E3WZltFv47lJ30DmrefrApYvq1OqDaz YjyprK46akfucSu62irqUhXAO2eSTonXwQisBTxMTqcRfggYm0T6liq0zh9OUFhVKo+z xbbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XgLxq081x7Q6pmPf0XqL+c1fEHHMqHdKV29fJNQQ4KA=; b=0yNFnSI2VtIdB3GNAdfxzIlrkvgdy24qOWoLJnxNYoTEB4FhXo7AF7+v+f1gDzaFef mEfqgzvNiVcbKWyBkIuEQe2Vlm178fiZq0OWplyCPBsy0zED2lv9msmOC79dE3HS+9ss OF+krttZP7SPuDaQvid9Q9aA7iO5Vtor2lNW2HTwOFno7UTWH0/3BD4yo0GnoiPtiez4 x4bdEAr3pge7labYw4X94UswmNJ/cmkBIn8UIlMw1PwnNMXa3TG0BUMy1tLdZOLYTdgY WI/oOGYA+6f/EzSmlvgK2I+5o5lrRjiUzPECZn9OWOal3jT1OkdZFDp6xWrYS0ktR+Lj 50vg== X-Gm-Message-State: AOAM5339wWiRje86NSGx4F4y9JklYW9ueUt9wLvYYd4tpXE18nnVu93Q a/aGYjNBzaQMPKgN12GARuds3A== X-Google-Smtp-Source: ABdhPJwVYVexLyoic+DCLJlED9K3osUhrGxsV+jlmAUUrglMl9l6b9rq1WpPEbhWZiORCy3Cqhl47Q== X-Received: by 2002:a17:90b:3ec2:b0:1d2:a9a1:b2f1 with SMTP id rm2-20020a17090b3ec200b001d2a9a1b2f1mr12172404pjb.145.1650571710447; Thu, 21 Apr 2022 13:08:30 -0700 (PDT) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id u26-20020a63471a000000b003aa1ad643bdsm11782353pga.47.2022.04.21.13.08.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Apr 2022 13:08:29 -0700 (PDT) Date: Thu, 21 Apr 2022 13:08:27 -0700 From: Stephen Hemminger <stephen@networkplumber.org> To: Sean Morrissey <sean.morrissey@intel.com> Cc: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>, dev@dpdk.org Subject: Re: [PATCH v1 18/19] timer: remove unneeded header includes Message-ID: <20220421130827.32634853@hermes.local> In-Reply-To: <20220421190859.264174-19-sean.morrissey@intel.com> References: <20220421190859.264174-1-sean.morrissey@intel.com> <20220421190859.264174-19-sean.morrissey@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Thu, 21 Apr 2022 19:08:58 +0000 Sean Morrissey <sean.morrissey@intel.com> wrote: > diff --git a/lib/timer/rte_timer.c b/lib/timer/rte_timer.c > index c51a393e5c..f52ccc33ed 100644 > --- a/lib/timer/rte_timer.c > +++ b/lib/timer/rte_timer.c > @@ -5,12 +5,9 @@ > #include <stdio.h> > #include <stdint.h> > #include <stdbool.h> > -#include <inttypes.h> > #include <assert.h> > -#include <sys/queue.h> > > #include <rte_common.h> > -#include <rte_cycles.h> > #include <rte_eal_memconfig.h> > #include <rte_memory.h> > #include <rte_lcore.h> This doesn't look right. rte_timer.c relies on rte_get_timer_cycles() which is defined in rte_cycles.h Perhaps iwyu is getting confused, or thinking that is already covered by another include file?