DPDK patches and discussions
 help / color / mirror / Atom feed
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
	Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
	"Burakov, Anatoly" <anatoly.burakov@intel.com>,
	Narcisa Vasile <navasile@microsoft.com>
Subject: Re: [PATCH v2 1/4] eal/windows: translate Windows errors to errno-style errors
Date: Mon, 25 Apr 2022 01:52:53 -0700	[thread overview]
Message-ID: <20220425085253.GB15936@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <CAJFAV8ybDki-dPBskGZTOz38_D-BjAuizJ-rtuJP3eX9nPg=tA@mail.gmail.com>

On Mon, Apr 25, 2022 at 10:25:30AM +0200, David Marchand wrote:
> On Tue, Apr 12, 2022 at 12:44 PM Tyler Retzlaff
> <roretzla@linux.microsoft.com> wrote:
> >
> > Add function to translate Windows error codes to errno-style error
> > codes. The possible return values are chosen so that we have as
> > much semantical compatibility between platforms as possible.
> >
> > Signed-off-by: Narcisa Vasile <navasile@microsoft.com>
> > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> 
> This patch alone does not make sense, and I guess it breaks
> compilation on Windows if we stop at it during a bisect (because it
> adds two unused static symbols).

interesting, didn't happen locally but i can see that it should have.

> It can be squashed in patch 3 where thread_log_last_error is first used.

yep, makes sense to me. i'll push a new version.

thanks

  reply	other threads:[~2022-04-25  8:52 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-01 13:29 [PATCH 0/3] add eal functions for thread affinity Tyler Retzlaff
2022-04-01 13:29 ` [PATCH 1/3] eal/windows: translate Windows errors to errno-style errors Tyler Retzlaff
2022-04-01 13:29 ` [PATCH 2/3] eal: implement functions for get/set thread affinity Tyler Retzlaff
2022-04-08 14:01   ` Dmitry Kozlyuk
2022-04-09  8:02     ` Tyler Retzlaff
2022-04-01 13:29 ` [PATCH 3/3] test/threads: add unit test for thread API Tyler Retzlaff
2022-04-08 14:01   ` Dmitry Kozlyuk
2022-04-09  8:56     ` Tyler Retzlaff
2022-04-11 22:52       ` Dmitry Kozlyuk
2022-04-08  8:57 ` [PATCH 0/3] add eal functions for thread affinity David Marchand
2022-04-08 13:46   ` Tyler Retzlaff
2022-04-11  7:32     ` David Marchand
2022-04-12 10:43 ` [PATCH v2 0/4] add eal functions for thread affinity and self Tyler Retzlaff
2022-04-12 10:43   ` [PATCH v2 1/4] eal/windows: translate Windows errors to errno-style errors Tyler Retzlaff
2022-04-12 17:26     ` Menon, Ranjit
2022-04-13  7:07       ` Tyler Retzlaff
2022-04-25  8:25     ` David Marchand
2022-04-25  8:52       ` Tyler Retzlaff [this message]
2022-04-12 10:43   ` [PATCH v2 2/4] eal: add basic thread ID and current thread identifier API Tyler Retzlaff
2022-04-12 10:43   ` [PATCH v2 3/4] eal: implement functions for get/set thread affinity Tyler Retzlaff
2022-04-13  7:30     ` Tyler Retzlaff
2022-04-12 10:43   ` [PATCH v2 4/4] test/threads: add unit test for thread API Tyler Retzlaff
2022-04-13  7:43 ` [PATCH v3 0/4] add eal functions for thread affinity and self Tyler Retzlaff
2022-04-13  7:43   ` [PATCH v3 1/4] eal/windows: translate Windows errors to errno-style errors Tyler Retzlaff
2022-04-13  7:43   ` [PATCH v3 2/4] eal: add basic thread ID and current thread identifier API Tyler Retzlaff
2022-04-25  8:26     ` David Marchand
2022-04-25  8:53       ` Tyler Retzlaff
2022-04-13  7:43   ` [PATCH v3 3/4] eal: implement functions for get/set thread affinity Tyler Retzlaff
2022-04-25  8:26     ` David Marchand
2022-04-25  8:55       ` Tyler Retzlaff
2022-04-13  7:43   ` [PATCH v3 4/4] test/threads: add unit test for thread API Tyler Retzlaff
2022-04-26  7:50 ` [PATCH v4 0/3] add eal functions for thread affinity and self Tyler Retzlaff
2022-04-26  7:50   ` [PATCH v4 1/3] eal: add basic thread ID and current thread identifier API Tyler Retzlaff
2022-05-01  9:18     ` Dmitry Kozlyuk
2022-04-26  7:50   ` [PATCH v4 2/3] eal: implement functions for get/set thread affinity Tyler Retzlaff
2022-05-01  9:18     ` Dmitry Kozlyuk
2022-04-26  7:50   ` [PATCH v4 3/3] test/threads: add unit test for thread API Tyler Retzlaff
2022-05-01  9:18     ` Dmitry Kozlyuk
2022-05-03  9:38       ` Tyler Retzlaff
2022-05-04 15:46 ` [PATCH v5 0/3] add eal functions for thread affinity and self Tyler Retzlaff
2022-05-04 15:46   ` [PATCH v5 1/3] eal: add basic thread ID and current thread identifier API Tyler Retzlaff
2022-05-04 22:55     ` Konstantin Ananyev
2022-05-05  7:11       ` Tyler Retzlaff
2022-05-06 19:37         ` Konstantin Ananyev
2022-05-07  8:25           ` Morten Brørup
2022-05-07 13:57             ` Konstantin Ananyev
2022-05-07 19:47               ` Morten Brørup
2022-05-10 21:52                 ` Konstantin Ananyev
2022-05-11  7:17                   ` Tyler Retzlaff
2022-05-11  7:36                     ` Morten Brørup
2022-05-11 22:27                     ` Konstantin Ananyev
2022-05-04 15:46   ` [PATCH v5 2/3] eal: implement functions for get/set thread affinity Tyler Retzlaff
2022-05-04 15:46   ` [PATCH v5 3/3] test/threads: add unit test for thread API Tyler Retzlaff
2022-05-12 13:14 ` [PATCH v6 0/3] add eal functions for thread affinity and self Tyler Retzlaff
2022-05-12 13:14   ` [PATCH v6 1/3] eal: add basic thread ID and current thread identifier API Tyler Retzlaff
2022-05-15 22:02     ` Konstantin Ananyev
2022-05-16  6:21       ` Tyler Retzlaff
2022-05-12 13:14   ` [PATCH v6 2/3] eal: implement functions for get/set thread affinity Tyler Retzlaff
2022-05-12 13:14   ` [PATCH v6 3/3] test/threads: add unit test for thread API Tyler Retzlaff
2022-05-19 15:05   ` [PATCH v6 0/3] add eal functions for thread affinity and self David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220425085253.GB15936@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
    --to=roretzla@linux.microsoft.com \
    --cc=anatoly.burakov@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=navasile@microsoft.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).