From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 5A775A00BE;
	Mon, 25 Apr 2022 10:52:55 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id E050841109;
	Mon, 25 Apr 2022 10:52:54 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id CC7CE410E6
 for <dev@dpdk.org>; Mon, 25 Apr 2022 10:52:53 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id 1C4BF20E8BFD; Mon, 25 Apr 2022 01:52:53 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 1C4BF20E8BFD
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1650876773;
 bh=YzJ+iLLz7RDQccGf1lG3hyyTbEdIAcnsCGAhgeKG8Ws=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=C21IOs19tzfvzAo/eonuM+JxujriLJ55uxca5UkiE4YlkUL1n9Me171cIZcGRo+WV
 xzidjpsDq//JvB5Nn2gub/teZ+KiQxqLfdx9xCrg9I5JlczU95QyJMrVhQO2fPKM6T
 99ebiHEgri3202EzpEd9dmDiUEK9Y0cEdjuqx7Co=
Date: Mon, 25 Apr 2022 01:52:53 -0700
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
 Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
 "Burakov, Anatoly" <anatoly.burakov@intel.com>,
 Narcisa Vasile <navasile@microsoft.com>
Subject: Re: [PATCH v2 1/4] eal/windows: translate Windows errors to
 errno-style errors
Message-ID: <20220425085253.GB15936@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1648819793-18948-1-git-send-email-roretzla@linux.microsoft.com>
 <1649760220-8683-1-git-send-email-roretzla@linux.microsoft.com>
 <1649760220-8683-2-git-send-email-roretzla@linux.microsoft.com>
 <CAJFAV8ybDki-dPBskGZTOz38_D-BjAuizJ-rtuJP3eX9nPg=tA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJFAV8ybDki-dPBskGZTOz38_D-BjAuizJ-rtuJP3eX9nPg=tA@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Mon, Apr 25, 2022 at 10:25:30AM +0200, David Marchand wrote:
> On Tue, Apr 12, 2022 at 12:44 PM Tyler Retzlaff
> <roretzla@linux.microsoft.com> wrote:
> >
> > Add function to translate Windows error codes to errno-style error
> > codes. The possible return values are chosen so that we have as
> > much semantical compatibility between platforms as possible.
> >
> > Signed-off-by: Narcisa Vasile <navasile@microsoft.com>
> > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> 
> This patch alone does not make sense, and I guess it breaks
> compilation on Windows if we stop at it during a bisect (because it
> adds two unused static symbols).

interesting, didn't happen locally but i can see that it should have.

> It can be squashed in patch 3 where thread_log_last_error is first used.

yep, makes sense to me. i'll push a new version.

thanks