From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 3922BA00BE;
	Mon, 25 Apr 2022 10:53:42 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 2766D41109;
	Mon, 25 Apr 2022 10:53:42 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 1D626410E6
 for <dev@dpdk.org>; Mon, 25 Apr 2022 10:53:41 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id 6D98C20E8BFD; Mon, 25 Apr 2022 01:53:40 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 6D98C20E8BFD
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1650876820;
 bh=0NGwzkfnUWT1600boIl5FxmulZ3DRat1Y0zgayhB54w=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=oUyERNK9Dsmo7pdx2vYwlNOcSkTZ8tS4Ng0L88rBtNttJ5GpF5TPYhx7tGVbwQmxs
 dvwGm8IkwL0biSkjTRxFjoYOFuw7++koho0KtSggRAqk/zozS1BFes94h+Hbd+HObE
 q4WT3qMtYsgEtbxg5fDGn9V6BUjPpW8uHYJ6fdLY=
Date: Mon, 25 Apr 2022 01:53:40 -0700
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
 Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
 "Burakov, Anatoly" <anatoly.burakov@intel.com>,
 Narcisa Vasile <navasile@microsoft.com>
Subject: Re: [PATCH v3 2/4] eal: add basic thread ID and current thread
 identifier API
Message-ID: <20220425085340.GC15936@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1648819793-18948-1-git-send-email-roretzla@linux.microsoft.com>
 <1649835795-9344-1-git-send-email-roretzla@linux.microsoft.com>
 <1649835795-9344-3-git-send-email-roretzla@linux.microsoft.com>
 <CAJFAV8y=eAZDDLOL1tEV=WgF+75FpNwuK-yJx+h36V32O3X6Qw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJFAV8y=eAZDDLOL1tEV=WgF+75FpNwuK-yJx+h36V32O3X6Qw@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Mon, Apr 25, 2022 at 10:26:42AM +0200, David Marchand wrote:
> On Wed, Apr 13, 2022 at 9:43 AM Tyler Retzlaff
> <roretzla@linux.microsoft.com> wrote:
> >
> > Provide a portable type-safe thread identifier.
> > Provide rte_thread_self for obtaining current thread identifier.
> >
> > Signed-off-by: Narcisa Vasile <navasile@microsoft.com>
> > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> > ---
> >  lib/eal/include/rte_thread.h | 22 ++++++++++++++++++++++
> >  lib/eal/unix/rte_thread.c    | 11 +++++++++++
> >  lib/eal/version.map          |  3 +++
> >  lib/eal/windows/rte_thread.c | 10 ++++++++++
> >  4 files changed, 46 insertions(+)
> >
> > diff --git a/lib/eal/include/rte_thread.h b/lib/eal/include/rte_thread.h
> > index 8be8ed8..fb66d9a 100644
> > --- a/lib/eal/include/rte_thread.h
> > +++ b/lib/eal/include/rte_thread.h
> > @@ -1,7 +1,10 @@
> >  /* SPDX-License-Identifier: BSD-3-Clause
> >   * Copyright(c) 2021 Mellanox Technologies, Ltd
> > + * Copyright (C) 2022 Microsoft Corporation
> >   */
> >
> > +#include <stdint.h>
> > +
> >  #include <rte_os.h>
> >  #include <rte_compat.h>
> >
> > @@ -21,10 +24,29 @@
> >  #endif
> >
> >  /**
> > + * Thread id descriptor.
> > + */
> > +typedef struct rte_thread_tag {
> 
> Is there a need for rte_thread_tag.
> I don't see it used.

i don't think so. it was part of the original series i'll remove it.

> 
> 
> -- 
> David Marchand