DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ankur Dwivedi <adwivedi@marvell.com>
To: <dev@dpdk.org>
Cc: <jerinj@marvell.com>, <erik.g.carrillo@intel.com>,
	<pbhagavatula@marvell.com>, <gmuthukrishn@marvell.com>,
	Ankur Dwivedi <adwivedi@marvell.com>
Subject: [PATCH] eventdev/timer_adapter: add telemetry support
Date: Tue, 26 Apr 2022 09:29:45 +0530	[thread overview]
Message-ID: <20220426035945.8851-1-adwivedi@marvell.com> (raw)

Adds telemetry support to get timer adapter info and timer adapter
statistics.

Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com>
Reviewed-by: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
---
 lib/eventdev/rte_event_timer_adapter.c | 91 ++++++++++++++++++++++++++
 1 file changed, 91 insertions(+)

diff --git a/lib/eventdev/rte_event_timer_adapter.c b/lib/eventdev/rte_event_timer_adapter.c
index 7dc39386c9..e0d978d641 100644
--- a/lib/eventdev/rte_event_timer_adapter.c
+++ b/lib/eventdev/rte_event_timer_adapter.c
@@ -14,6 +14,7 @@
 #include <rte_common.h>
 #include <rte_timer.h>
 #include <rte_service_component.h>
+#include <rte_telemetry.h>
 
 #include "event_timer_adapter_pmd.h"
 #include "eventdev_pmd.h"
@@ -1249,3 +1250,93 @@ static const struct event_timer_adapter_ops swtim_ops = {
 	.arm_tmo_tick_burst = swtim_arm_tmo_tick_burst,
 	.cancel_burst = swtim_cancel_burst,
 };
+
+static int
+handle_ta_info(const char *cmd __rte_unused, const char *params,
+		struct rte_tel_data *d)
+{
+	struct rte_event_timer_adapter_info adapter_info;
+	struct rte_event_timer_adapter *adapter;
+	uint16_t adapter_id;
+	int ret;
+
+	if (params == NULL || strlen(params) == 0 || !isdigit(*params))
+		return -1;
+
+	adapter_id = atoi(params);
+
+	if (adapter_id >= RTE_EVENT_TIMER_ADAPTER_NUM_MAX) {
+		EVTIM_LOG_ERR("Invalid timer adapter id %u", adapter_id);
+		return -EINVAL;
+	}
+
+	adapter = &adapters[adapter_id];
+
+	ret = rte_event_timer_adapter_get_info(adapter, &adapter_info);
+	if (ret < 0) {
+		EVTIM_LOG_ERR("Failed to get info for timer adapter id %u", adapter_id);
+		return ret;
+	}
+
+	rte_tel_data_start_dict(d);
+	rte_tel_data_add_dict_u64(d, "timer_adapter_id", adapter_id);
+	rte_tel_data_add_dict_u64(d, "min_resolution_ns", adapter_info.min_resolution_ns);
+	rte_tel_data_add_dict_u64(d, "max_tmo_ns", adapter_info.max_tmo_ns);
+	rte_tel_data_add_dict_u64(d, "event_dev_id", adapter_info.conf.event_dev_id);
+	rte_tel_data_add_dict_u64(d, "socket_id", adapter_info.conf.socket_id);
+	rte_tel_data_add_dict_u64(d, "clk_src", adapter_info.conf.clk_src);
+	rte_tel_data_add_dict_u64(d, "timer_tick_ns", adapter_info.conf.timer_tick_ns);
+	rte_tel_data_add_dict_u64(d, "nb_timers", adapter_info.conf.nb_timers);
+	rte_tel_data_add_dict_u64(d, "flags", adapter_info.conf.flags);
+
+	return 0;
+}
+
+static int
+handle_ta_stats(const char *cmd __rte_unused, const char *params,
+		struct rte_tel_data *d)
+{
+	struct rte_event_timer_adapter_stats stats;
+	struct rte_event_timer_adapter *adapter;
+	uint16_t adapter_id;
+	int ret;
+
+	if (params == NULL || strlen(params) == 0 || !isdigit(*params))
+		return -1;
+
+	adapter_id = atoi(params);
+
+	if (adapter_id >= RTE_EVENT_TIMER_ADAPTER_NUM_MAX) {
+		EVTIM_LOG_ERR("Invalid timer adapter id %u", adapter_id);
+		return -EINVAL;
+	}
+
+	adapter = &adapters[adapter_id];
+
+	ret = rte_event_timer_adapter_stats_get(adapter, &stats);
+	if (ret < 0) {
+		EVTIM_LOG_ERR("Failed to get stats for timer adapter id %u", adapter_id);
+		return ret;
+	}
+
+	rte_tel_data_start_dict(d);
+	rte_tel_data_add_dict_u64(d, "timer_adapter_id", adapter_id);
+	rte_tel_data_add_dict_u64(d, "evtim_exp_count", stats.evtim_exp_count);
+	rte_tel_data_add_dict_u64(d, "ev_enq_count", stats.ev_enq_count);
+	rte_tel_data_add_dict_u64(d, "ev_inv_count", stats.ev_inv_count);
+	rte_tel_data_add_dict_u64(d, "evtim_retry_count", stats.evtim_retry_count);
+	rte_tel_data_add_dict_u64(d, "adapter_tick_count", stats.adapter_tick_count);
+
+	return 0;
+}
+
+RTE_INIT(ta_init_telemetry)
+{
+	rte_telemetry_register_cmd("/eventdev/ta_info",
+		handle_ta_info,
+		"Returns Timer adapter info. Parameter: Timer adapter id");
+
+	rte_telemetry_register_cmd("/eventdev/ta_stats",
+		handle_ta_stats,
+		"Returns Timer adapter stats. Parameter: Timer adapter id");
+}
-- 
2.28.0


             reply	other threads:[~2022-04-26  4:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-26  3:59 Ankur Dwivedi [this message]
2022-05-16  9:58 ` Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220426035945.8851-1-adwivedi@marvell.com \
    --to=adwivedi@marvell.com \
    --cc=dev@dpdk.org \
    --cc=erik.g.carrillo@intel.com \
    --cc=gmuthukrishn@marvell.com \
    --cc=jerinj@marvell.com \
    --cc=pbhagavatula@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).