From: Wenjun Wu <wenjun1.wu@intel.com>
To: dev@dpdk.org, qiming.yang@intel.com, qi.z.zhang@intel.com
Subject: [PATCH v9 9/9] net/ice: add warning log for unsupported configuration
Date: Thu, 28 Apr 2022 11:30:34 +0800 [thread overview]
Message-ID: <20220428033034.3490183-10-wenjun1.wu@intel.com> (raw)
In-Reply-To: <20220428033034.3490183-1-wenjun1.wu@intel.com>
Priority configuration is enabled in level 3 and level 4.
Weight configuration is enabled in level 4.
This patch adds warning log for unsupported priority
and weight configuration.
Signed-off-by: Wenjun Wu <wenjun1.wu@intel.com>
---
drivers/net/ice/ice_tm.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/net/ice/ice_tm.c b/drivers/net/ice/ice_tm.c
index f604523ead..34a0bfcff8 100644
--- a/drivers/net/ice/ice_tm.c
+++ b/drivers/net/ice/ice_tm.c
@@ -531,6 +531,15 @@ ice_tm_node_add(struct rte_eth_dev *dev, uint32_t node_id,
rte_calloc(NULL, 256, (sizeof(struct ice_tm_node *)), 0);
tm_node->parent->children[tm_node->parent->reference_count] = tm_node;
+ if (tm_node->priority != 0 && level_id != ICE_TM_NODE_TYPE_QUEUE &&
+ level_id != ICE_TM_NODE_TYPE_QGROUP)
+ PMD_DRV_LOG(WARNING, "priority != 0 not supported in level %d",
+ level_id);
+
+ if (tm_node->weight != 1 && level_id != ICE_TM_NODE_TYPE_QUEUE)
+ PMD_DRV_LOG(WARNING, "weight != 1 not supported in level %d",
+ level_id);
+
rte_memcpy(&tm_node->params, params,
sizeof(struct rte_tm_node_params));
if (parent_node_type == ICE_TM_NODE_TYPE_PORT) {
--
2.25.1
next prev parent reply other threads:[~2022-04-28 3:53 UTC|newest]
Thread overview: 109+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 1:48 [PATCH v1 0/9] Enable ETS-based TX QoS on PF Wenjun Wu
2022-03-29 1:48 ` [PATCH v1 1/9] net/ice/base: fix dead lock issue when getting node from ID type Wenjun Wu
2022-03-29 1:48 ` [PATCH v1 2/9] net/base/ice: support priority configuration of the exact node Wenjun Wu
2022-03-29 1:48 ` [PATCH v1 3/9] net/ice/base: support queue BW allocation configuration Wenjun Wu
2022-03-29 1:48 ` [PATCH v1 4/9] net/ice: support queue bandwidth limit Wenjun Wu
2022-03-29 1:48 ` [PATCH v1 5/9] net/ice: support queue group " Wenjun Wu
2022-03-29 1:48 ` [PATCH v1 6/9] net/ice: support queue priority configuration Wenjun Wu
2022-03-29 1:48 ` [PATCH v1 7/9] net/ice: support queue weight configuration Wenjun Wu
2022-03-29 1:48 ` [PATCH v1 8/9] net/ice: support queue group priority configuration Wenjun Wu
2022-03-29 1:48 ` [PATCH v1 9/9] net/ice: add warning log for unsupported configuration Wenjun Wu
2022-03-29 2:02 ` [PATCH v2 0/9] Enable ETS-based TX QoS on PF Wenjun Wu
2022-03-29 2:03 ` [PATCH v2 1/9] net/ice/base: fix dead lock issue when getting node from ID type Wenjun Wu
2022-03-29 2:03 ` [PATCH v2 2/9] net/base/ice: support priority configuration of the exact node Wenjun Wu
2022-03-29 2:03 ` [PATCH v2 3/9] net/ice/base: support queue BW allocation configuration Wenjun Wu
2022-03-29 2:03 ` [PATCH v2 4/9] net/ice: support queue bandwidth limit Wenjun Wu
2022-03-29 2:03 ` [PATCH v2 5/9] net/ice: support queue group " Wenjun Wu
2022-03-29 2:03 ` [PATCH v2 6/9] net/ice: support queue priority configuration Wenjun Wu
2022-03-29 2:03 ` [PATCH v2 7/9] net/ice: support queue weight configuration Wenjun Wu
2022-03-29 2:03 ` [PATCH v2 8/9] net/ice: support queue group priority configuration Wenjun Wu
2022-03-29 2:03 ` [PATCH v2 9/9] net/ice: add warning log for unsupported configuration Wenjun Wu
2022-03-29 3:06 ` [PATCH v3 0/9] Enable ETS-based TX QoS on PF Wenjun Wu
2022-03-29 3:06 ` [PATCH v3 1/9] net/ice/base: fix dead lock issue when getting node from ID type Wenjun Wu
2022-03-29 3:06 ` [PATCH v3 2/9] net/base/ice: support priority configuration of the exact node Wenjun Wu
2022-03-29 3:06 ` [PATCH v3 3/9] net/ice/base: support queue BW allocation configuration Wenjun Wu
2022-03-29 3:06 ` [PATCH v3 4/9] net/ice: support queue bandwidth limit Wenjun Wu
2022-03-29 3:06 ` [PATCH v3 5/9] net/ice: support queue group " Wenjun Wu
2022-03-29 3:06 ` [PATCH v3 6/9] net/ice: support queue priority configuration Wenjun Wu
2022-03-29 3:06 ` [PATCH v3 7/9] net/ice: support queue weight configuration Wenjun Wu
2022-03-29 3:06 ` [PATCH v3 8/9] net/ice: support queue group priority configuration Wenjun Wu
2022-03-29 3:06 ` [PATCH v3 9/9] net/ice: add warning log for unsupported configuration Wenjun Wu
2022-03-29 4:56 ` [PATCH v4 0/9] Enable ETS-based TX QoS on PF Wenjun Wu
2022-03-29 4:56 ` [PATCH v4 1/9] net/ice/base: fix dead lock issue when getting node from ID type Wenjun Wu
2022-03-29 4:56 ` [PATCH v4 2/9] net/base/ice: support priority configuration of the exact node Wenjun Wu
2022-03-29 4:56 ` [PATCH v4 3/9] net/ice/base: support queue BW allocation configuration Wenjun Wu
2022-03-29 4:56 ` [PATCH v4 4/9] net/ice: support queue bandwidth limit Wenjun Wu
2022-03-29 4:56 ` [PATCH v4 5/9] net/ice: support queue group " Wenjun Wu
2022-03-29 4:56 ` [PATCH v4 6/9] net/ice: support queue priority configuration Wenjun Wu
2022-03-29 4:56 ` [PATCH v4 7/9] net/ice: support queue weight configuration Wenjun Wu
2022-03-29 4:56 ` [PATCH v4 8/9] net/ice: support queue group priority configuration Wenjun Wu
2022-03-29 4:56 ` [PATCH v4 9/9] net/ice: add warning log for unsupported configuration Wenjun Wu
2022-03-29 9:38 ` [PATCH v5 0/9] Enable ETS-based TX QoS on PF Wenjun Wu
2022-03-29 9:38 ` [PATCH v5 1/9] net/ice/base: fix dead lock issue when getting node from ID type Wenjun Wu
2022-03-29 9:38 ` [PATCH v5 2/9] net/ice/base: support priority configuration of the exact node Wenjun Wu
2022-03-29 9:38 ` [PATCH v5 3/9] net/ice/base: support queue BW allocation configuration Wenjun Wu
2022-03-29 9:38 ` [PATCH v5 4/9] net/ice: support queue bandwidth limit Wenjun Wu
2022-03-29 9:38 ` [PATCH v5 5/9] net/ice: support queue group " Wenjun Wu
2022-03-29 9:38 ` [PATCH v5 6/9] net/ice: support queue priority configuration Wenjun Wu
2022-03-29 9:38 ` [PATCH v5 7/9] net/ice: support queue weight configuration Wenjun Wu
2022-03-29 9:38 ` [PATCH v5 8/9] net/ice: support queue group priority configuration Wenjun Wu
2022-03-29 9:38 ` [PATCH v5 9/9] net/ice: add warning log for unsupported configuration Wenjun Wu
2022-04-08 5:38 ` [PATCH v6 00/10] Enable ETS-based TX QoS on PF Wenjun Wu
2022-04-08 5:38 ` [PATCH v6 01/10] net/ice/base: fix dead lock issue when getting node from ID type Wenjun Wu
2022-04-08 5:38 ` [PATCH v6 02/10] net/ice/base: support priority configuration of the exact node Wenjun Wu
2022-04-08 5:38 ` [PATCH v6 03/10] net/ice/base: support queue BW allocation configuration Wenjun Wu
2022-04-08 5:38 ` [PATCH v6 04/10] net/ice: support queue bandwidth limit Wenjun Wu
2022-04-08 5:38 ` [PATCH v6 05/10] net/ice: support queue group " Wenjun Wu
2022-04-08 5:38 ` [PATCH v6 06/10] net/ice: support queue priority configuration Wenjun Wu
2022-04-08 5:38 ` [PATCH v6 07/10] net/ice: support queue weight configuration Wenjun Wu
2022-04-08 5:38 ` [PATCH v6 08/10] net/ice: support queue group priority configuration Wenjun Wu
2022-04-08 5:38 ` [PATCH v6 09/10] net/ice: add warning log for unsupported configuration Wenjun Wu
2022-04-08 5:38 ` [PATCH v6 10/10] doc: add release notes for 22.07 Wenjun Wu
2022-04-22 0:57 ` [PATCH v7 0/9] Enable ETS-based TX QoS on PF Wenjun Wu
2022-04-22 0:57 ` [PATCH v7 1/9] net/ice/base: fix dead lock issue when getting node from ID type Wenjun Wu
2022-04-22 0:57 ` [PATCH v7 2/9] net/ice/base: support priority configuration of the exact node Wenjun Wu
2022-04-22 0:57 ` [PATCH v7 3/9] net/ice/base: support queue BW allocation configuration Wenjun Wu
2022-04-22 0:57 ` [PATCH v7 4/9] net/ice: support queue bandwidth limit Wenjun Wu
2022-04-22 0:57 ` [PATCH v7 5/9] net/ice: support queue group " Wenjun Wu
2022-04-22 0:57 ` [PATCH v7 6/9] net/ice: support queue priority configuration Wenjun Wu
2022-04-22 0:57 ` [PATCH v7 7/9] net/ice: support queue weight configuration Wenjun Wu
2022-04-22 0:57 ` [PATCH v7 8/9] net/ice: support queue group priority configuration Wenjun Wu
2022-04-22 0:57 ` [PATCH v7 9/9] net/ice: add warning log for unsupported configuration Wenjun Wu
2022-04-27 1:59 ` [PATCH v7 0/9] Enable ETS-based TX QoS on PF Yang, Qiming
2022-04-28 2:59 ` [PATCH v8 " Wenjun Wu
2022-04-28 2:59 ` [PATCH v8 1/9] net/ice/base: fix dead lock issue when getting node from ID type Wenjun Wu
2022-04-28 2:59 ` [PATCH v8 2/9] net/ice/base: support queue BW allocation configuration Wenjun Wu
2022-04-28 2:59 ` [PATCH v8 3/9] net/ice/base: support priority configuration of the exact node Wenjun Wu
2022-04-28 2:59 ` [PATCH v8 4/9] net/ice: support queue bandwidth limit Wenjun Wu
2022-04-28 2:59 ` [PATCH v8 5/9] net/ice: support queue group " Wenjun Wu
2022-04-28 2:59 ` [PATCH v8 6/9] net/ice: support queue priority configuration Wenjun Wu
2022-04-28 2:59 ` [PATCH v8 7/9] net/ice: support queue weight configuration Wenjun Wu
2022-04-28 2:59 ` [PATCH v8 8/9] net/ice: support queue group priority configuration Wenjun Wu
2022-04-28 2:59 ` [PATCH v8 9/9] net/ice: add warning log for unsupported configuration Wenjun Wu
2022-04-28 3:30 ` [PATCH v9 0/9] Enable ETS-based TX QoS on PF Wenjun Wu
2022-04-28 3:30 ` [PATCH v9 1/9] net/ice/base: fix dead lock issue when getting node from ID type Wenjun Wu
2022-04-28 3:30 ` [PATCH v9 2/9] net/ice/base: support queue BW allocation configuration Wenjun Wu
2022-04-28 3:30 ` [PATCH v9 3/9] net/ice/base: support priority configuration of the exact node Wenjun Wu
2022-04-28 3:30 ` [PATCH v9 4/9] net/ice: support queue bandwidth limit Wenjun Wu
2022-04-28 3:30 ` [PATCH v9 5/9] net/ice: support queue group " Wenjun Wu
2022-04-28 3:30 ` [PATCH v9 6/9] net/ice: support queue priority configuration Wenjun Wu
2022-04-28 3:30 ` [PATCH v9 7/9] net/ice: support queue weight configuration Wenjun Wu
2022-04-28 3:30 ` [PATCH v9 8/9] net/ice: support queue group priority configuration Wenjun Wu
2022-04-28 3:30 ` Wenjun Wu [this message]
2022-05-17 4:59 ` [PATCH v10 0/7] Enable ETS-based TX QoS on PF Wenjun Wu
2022-05-17 4:59 ` [PATCH v10 1/7] net/ice/base: fix dead lock issue when getting node from ID type Wenjun Wu
2022-05-17 4:59 ` [PATCH v10 2/7] net/ice/base: support queue BW allocation configuration Wenjun Wu
2022-05-17 4:59 ` [PATCH v10 3/7] net/ice/base: support priority configuration of the exact node Wenjun Wu
2022-05-17 4:59 ` [PATCH v10 4/7] net/ice: support queue and queue group bandwidth limit Wenjun Wu
2022-05-17 4:59 ` [PATCH v10 5/7] net/ice: support queue and queue group priority configuration Wenjun Wu
2022-05-17 4:59 ` [PATCH v10 6/7] net/ice: support queue weight configuration Wenjun Wu
2022-05-17 4:59 ` [PATCH v10 7/7] net/ice: add warning log for unsupported configuration Wenjun Wu
2022-05-17 5:09 ` [PATCH v11 0/7] Enable ETS-based TX QoS on PF Wenjun Wu
2022-05-17 5:09 ` [PATCH v11 1/7] net/ice/base: fix dead lock issue when getting node from ID type Wenjun Wu
2022-05-17 5:09 ` [PATCH v11 2/7] net/ice/base: support queue BW allocation configuration Wenjun Wu
2022-05-17 5:09 ` [PATCH v11 3/7] net/ice/base: support priority configuration of the exact node Wenjun Wu
2022-05-17 5:09 ` [PATCH v11 4/7] net/ice: support queue and queue group bandwidth limit Wenjun Wu
2022-05-17 5:09 ` [PATCH v11 5/7] net/ice: support queue and queue group priority configuration Wenjun Wu
2022-05-17 5:09 ` [PATCH v11 6/7] net/ice: support queue weight configuration Wenjun Wu
2022-05-17 5:09 ` [PATCH v11 7/7] net/ice: add warning log for unsupported configuration Wenjun Wu
2022-05-17 7:23 ` [PATCH v11 0/7] Enable ETS-based TX QoS on PF Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220428033034.3490183-10-wenjun1.wu@intel.com \
--to=wenjun1.wu@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).