* [PATCH] examples/ipsec-secgw: fix promiscuous mode option
@ 2022-04-28 15:18 Nithin Dabilpuram
2022-04-28 19:30 ` Akhil Goyal
0 siblings, 1 reply; 3+ messages in thread
From: Nithin Dabilpuram @ 2022-04-28 15:18 UTC (permalink / raw)
To: jerinj, gakhil, Radu Nicolau
Cc: dev, anoobj, Nithin Dabilpuram, sergio.gonzalez.monroy
Currently default value of promiscuous mode flag is true and
even there is command line argument to set it to true.
So it never is in non-promiscuous mode. Fix it by
changing default value to false.
Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application")
Cc: sergio.gonzalez.monroy@intel.com
Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
---
examples/ipsec-secgw/ipsec-secgw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c
index 42b5081..931d35c 100644
--- a/examples/ipsec-secgw/ipsec-secgw.c
+++ b/examples/ipsec-secgw/ipsec-secgw.c
@@ -175,7 +175,7 @@ uint32_t single_sa_idx;
/* mask of enabled ports */
static uint32_t enabled_port_mask;
static uint64_t enabled_cryptodev_mask = UINT64_MAX;
-static int32_t promiscuous_on = 1;
+static int32_t promiscuous_on;
static int32_t numa_on = 1; /**< NUMA is enabled by default. */
static uint32_t nb_lcores;
static uint32_t single_sa;
--
2.8.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] examples/ipsec-secgw: fix promiscuous mode option
2022-04-28 15:18 [PATCH] examples/ipsec-secgw: fix promiscuous mode option Nithin Dabilpuram
@ 2022-04-28 19:30 ` Akhil Goyal
2022-05-11 19:41 ` Akhil Goyal
0 siblings, 1 reply; 3+ messages in thread
From: Akhil Goyal @ 2022-04-28 19:30 UTC (permalink / raw)
To: Nithin Kumar Dabilpuram, Jerin Jacob Kollanukkaran, Radu Nicolau
Cc: dev, Anoob Joseph, Nithin Kumar Dabilpuram, sergio.gonzalez.monroy
> Currently default value of promiscuous mode flag is true and
> even there is command line argument to set it to true.
> So it never is in non-promiscuous mode. Fix it by
> changing default value to false.
>
> Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application")
> Cc: sergio.gonzalez.monroy@intel.com
>
> Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] examples/ipsec-secgw: fix promiscuous mode option
2022-04-28 19:30 ` Akhil Goyal
@ 2022-05-11 19:41 ` Akhil Goyal
0 siblings, 0 replies; 3+ messages in thread
From: Akhil Goyal @ 2022-05-11 19:41 UTC (permalink / raw)
To: Akhil Goyal, Nithin Kumar Dabilpuram, Jerin Jacob Kollanukkaran,
Radu Nicolau
Cc: dev, Anoob Joseph, Nithin Kumar Dabilpuram, sergio.gonzalez.monroy
> > Currently default value of promiscuous mode flag is true and
> > even there is command line argument to set it to true.
> > So it never is in non-promiscuous mode. Fix it by
> > changing default value to false.
> >
> > Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application")
> > Cc: sergio.gonzalez.monroy@intel.com
> >
> > Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
> Acked-by: Akhil Goyal <gakhil@marvell.com>
Applied to dpdk-next-crypto
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-11 19:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-28 15:18 [PATCH] examples/ipsec-secgw: fix promiscuous mode option Nithin Dabilpuram
2022-04-28 19:30 ` Akhil Goyal
2022-05-11 19:41 ` Akhil Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).