From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E0E9FA00C2; Thu, 5 May 2022 19:35:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C59094014F; Thu, 5 May 2022 19:35:21 +0200 (CEST) Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by mails.dpdk.org (Postfix) with ESMTP id 54C0540042 for ; Thu, 5 May 2022 19:35:20 +0200 (CEST) Received: by mail-pj1-f52.google.com with SMTP id c1-20020a17090a558100b001dca2694f23so4579908pji.3 for ; Thu, 05 May 2022 10:35:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EH5akpn57Jm0btla3SWkDZg1zYk0n8IVWTPje9m7JHM=; b=yD0xw4JWuUoF7602eHrzIGY4WF9Sh5SA1nyiaiyOQKP04JCNltXgayCOyOpnrhvhbv ZybMWIYLaUuneFLY7fLCA7k8dxIIlEb5OD02JhTlYcLQC/KsNQym4v0X4VJxjTC+RveJ TRe1Ar2A8UextLBlb+4z6eQtmIxNy2SYMI+qXbzWVv8ageRUQ98DrGSX7LOpa0pfKwj7 PF9JANs3XDf35FVMqxyUA9J5DPJZe3fwrHrF2kfqqfLOFKC0OvsdpM8/tyfZCwQUSd5D zwKOyjf2Ax7nhBzkUKuxnDrdmxNC+eegmN7QUqKb0VYSemeps7i35Qk2ppDENICECCGy DqnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EH5akpn57Jm0btla3SWkDZg1zYk0n8IVWTPje9m7JHM=; b=JvJEWWtio2Ln57UzWwtWAsd6aWVl0CqHHuX0dDmamca8NvSsEDLuw+5MG5vDieezm9 s6Fk/dFoBd/SwZLug+5GqMvXVZofDO+wfW5PoFhEGZ0HLmey425+xF9pZjx40CXjzSfN 0geFsod95BZGRuQq/5za0SaxDqY4E698VWmBGO0t2WoHo+hwSZzkrF5Su1hESLuVga/I FLRX4dgU2q9WWNCkrjL4/Oq4oQKU8/ACl5pT36tP0RDigLbZHvFy0Oj2AColCMw/M6EE hMEZy9MDreNf56spvkkISnSGouyyndPhUiFCXNQ/qp4+VuzUqpHL+Cth3MYPe++xjVV4 PyCQ== X-Gm-Message-State: AOAM531EGlHek/hms/qNXqVGdNuH98S/X9jrO26ywRQvsZIKafo6Gqre eamD9rJzrRiAnrRFR9P7xYd4hA== X-Google-Smtp-Source: ABdhPJwWQnmWpzpnjKjLJdu6XdZlnRnOHf7v68XZbYqpiUu8LMIrshZkMk4pE17lky1Poc5oAdctAg== X-Received: by 2002:a17:902:aa85:b0:155:ceb9:3710 with SMTP id d5-20020a170902aa8500b00155ceb93710mr28963442plr.59.1651772119570; Thu, 05 May 2022 10:35:19 -0700 (PDT) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id e14-20020a17090301ce00b0015e8d4eb231sm1865216plh.123.2022.05.05.10.35.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 May 2022 10:35:19 -0700 (PDT) Date: Thu, 5 May 2022 10:35:16 -0700 From: Stephen Hemminger To: Stanislaw Kardach Cc: Honnappa Nagarahalli , dev@dpdk.org, Frank Zhao , Sam Grove , mw@semihalf.com, upstream@semihalf.com Subject: Re: [PATCH 09/11] test/ring: disable problematic tests for RISC-V Message-ID: <20220505103516.5486d020@hermes.local> In-Reply-To: <20220505173003.3242618-10-kda@semihalf.com> References: <20220505173003.3242618-1-kda@semihalf.com> <20220505173003.3242618-10-kda@semihalf.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 5 May 2022 19:30:01 +0200 Stanislaw Kardach wrote: > When compiling for RISC-V in debug mode the large amount of inlining in > test_ring_basic_ex() and test_ring_with_exact_size() (in test_ring.c) > leads to large loop bodies. This causes 'goto' and 'for' loop > PC-relative jumps generated by the compiler to go beyond the architecture > limitation of +/-1MB offset (the 'j ' instruction). This > instruction should not be generated by the compiler since C language does > not limit the maximum distance for 'goto' or 'for' loop jumps. > > This only happens in the unit test for ring which tries to perform long > loops with ring enqueue/dequeue and it seems to be caused by excessive > __rte_always_inline usage. ring perf test compiles just fine under > debug. > > To work around this, disable the offending tests in debug mode. > > Signed-off-by: Stanislaw Kardach > Sponsored-by: Frank Zhao > Sponsored-by: Sam Grove > --- It seems to me that fixing the excessive inlining in the ring code could benefit all architectures, rather than neutering the tests on RISCV.