From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4EBA9A00C2; Thu, 5 May 2022 19:39:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0D5F74014F; Thu, 5 May 2022 19:39:58 +0200 (CEST) Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by mails.dpdk.org (Postfix) with ESMTP id 1B7C640042 for ; Thu, 5 May 2022 19:39:56 +0200 (CEST) Received: by mail-pj1-f45.google.com with SMTP id w5-20020a17090aaf8500b001d74c754128so8660765pjq.0 for ; Thu, 05 May 2022 10:39:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tiGPLgeS68fg4ma3ddJPJ+q40b2tmbIeyXceFyCLqYw=; b=mteIhWLn1L8gUDUcYzubn4aPS3au6wrskciZZSPrg8A5RmPxkgrX/tEfu1R3TN9M9I 3cLN5SROChqD9uncrWoi1YvPo5CjvGJEJlg9mwNlf7BZgzy+IS40GyvC6HPxT9WRWSWt 3o5bacnO02mEgKun54n7PqjvLqt761Tr/1PyR/T+8YJjeblNWRxR+389bsjxjMpZgniC nbxzOsTFDdRCQGijxo6w5HskLLNypAAUpRc4VhkP7b03IdcZzuiPidwyjJMlPRwgQLBk s0te7+xrWjTkBgCDndKAwc/P2hj1jdjGDg1MYqS7YeRkcyYUOJ9v/ZajbZEcIV7hzIbx logw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tiGPLgeS68fg4ma3ddJPJ+q40b2tmbIeyXceFyCLqYw=; b=eESi/4FfNeq5GnnEwrKJsqZ+P/j9qitL9k9x5Dyb9wSmpzv7LgPZWpOAGj1SRfM30U Gos1JlxdGgLhM3atkwJVG/0fMAmMASc0EHd9GeMOcnrs+zsPMb7mYdzb9LrXVz04lM7d ueRSbEn7gqEeYEM5tyv7GscmPd2Y/9l4Jl71pFKJZMFtVucRX67dAW7RWSk2lfX7iilp /uyF6sfzf+EmOW525GHorKVBX5rxYVvd0ogpth9Gp3rcKPOuyiHgMmQiFP5pGki76f0V 2PMrQ/Td9kIuxZT2ypI5zvXmBhUY7KDDkI1YmkxlmcfNVCZp343L5GwO7ge2BcB2D1bn CWXw== X-Gm-Message-State: AOAM533EeOdsVcyf9TSEYhtAIakdj2GrB3ycv3dTstUipiT5ERsN6k5P mrISXYx5P9VDvpqMJ3drdqUEQQ== X-Google-Smtp-Source: ABdhPJzQqANJLVzoiAx8IaS9rpJkCqp+Aus1FNP6NmNx1sRNgf1zlwoC0NjlKd3i90xBBykaNkCWHA== X-Received: by 2002:a17:902:8608:b0:158:b827:7721 with SMTP id f8-20020a170902860800b00158b8277721mr28194466plo.149.1651772395228; Thu, 05 May 2022 10:39:55 -0700 (PDT) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id c1-20020a170903234100b0015ee24acf38sm434415plh.212.2022.05.05.10.39.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 May 2022 10:39:54 -0700 (PDT) Date: Thu, 5 May 2022 10:39:51 -0700 From: Stephen Hemminger To: Stanislaw Kardach Cc: dev@dpdk.org, Frank Zhao , Sam Grove , mw@semihalf.com, upstream@semihalf.com, pbhagavatula@marvell.com Subject: Re: [PATCH 02/11] examples/l3fwd: fix scalar LPM compilation Message-ID: <20220505103951.2c58b9d0@hermes.local> In-Reply-To: <20220505173003.3242618-3-kda@semihalf.com> References: <20220505173003.3242618-1-kda@semihalf.com> <20220505173003.3242618-3-kda@semihalf.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 5 May 2022 19:29:54 +0200 Stanislaw Kardach wrote: > The lpm_process_event_pkt() can either process a packet using an > architecture specific (defined for X86/SSE, ARM/Neon and PPC64/Altivec) > path or a scalar one. The choice is however done using an ifdef > pre-processor macro. Because of that the scalar version was apparently > not widely excersized/compiled. > Due to some copy/paste errors, the scalar logic in > lpm_process_event_pkt() retained a "continue" statement where a BAD_PORT > should be returned after refactoring of the LPM logic in the l3fwd > example. > > Fixes: 99fc91d18082 ("examples/l3fwd: add event lpm main loop") > Cc: pbhagavatula@marvell.com > > Signed-off-by: Stanislaw Kardach > Sponsored-by: Frank Zhao > Sponsored-by: Sam Grove Would be easier to get merged if bug fixes came as separate patch submission. Also have not seen Sponsored-by before; what do you expect it to mean? Never used in DPDK or kernel git tree.