From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 53DF9A00C2; Thu, 5 May 2022 20:09:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 30B044014F; Thu, 5 May 2022 20:09:25 +0200 (CEST) Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by mails.dpdk.org (Postfix) with ESMTP id 7FBA940042 for ; Thu, 5 May 2022 20:09:24 +0200 (CEST) Received: by mail-pf1-f173.google.com with SMTP id 204so1477510pfx.3 for ; Thu, 05 May 2022 11:09:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oICbQwC4is3nqwvxG2+8WOgC+pX9MqeLM6izUqSNEsg=; b=kCipG5kdRY1RmbKfW4+vO4pv+zcznvjZ9chu01OBR6bz0nLKNGS7wfBBbjXOQwgK+p kHIiUbdeAbqolgaWxK6xVl8sDlNu/qcx0J5A+vy0yPIu5U+/Z6ydO3Dzpqp9CKPMtbAJ qlkgOn7ayOajMlms9eX05YmOYdumK/q8GaQLcdcxGkr/IbdV/lj4w6ziVPH1SxX0fihd /IZVsF7AJBvI2ds3bBadsbpUiwxPvyBXxNk6uIzNxm59GUIpoIdwdcQ6WvJxY0ArWKAJ mGcRPTWb0tjS/EBICFEMbQk2OliNJGY+jLrHna1cWANXwg+XGuQUBhegRoD45KknABPl i7mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oICbQwC4is3nqwvxG2+8WOgC+pX9MqeLM6izUqSNEsg=; b=RmUuxtW47rHa7IE6emqWVa89lzek0liF2hrqtc+QkdZ7ZV0ysVtOcSEAdKlpBfb90D zj/+szF4MiPll2h8hscSJYMr+a4j/yu7IJtrrcnpP5666yW/hFrri2dOMhHzHzJYr4U5 4J+JC34WK+3ka419EtZ8jiZoopAOYgQVyhrUVUNLGsHlpfy9c3RdGcxutH8I3S2zaK9T eLQibdvc5ZPAexv7k2WTqJxvYMinr4+1CyiIW7vypgjXfyu5dWBLzY+wo91wWEcpcnN0 PuiymeM0yTGJ+7ij5qRayv+Qy4Tv70Tu3vGyn0BcQz7F8DHz/1mN9aN25zycQrf57NyD BtZA== X-Gm-Message-State: AOAM5321GqBhxaLks6kAeYQZwg+Yi1T89pOX5opxNmbS7j63ncq8Y9ZH 8OaWGKHwXOsujjkkcVsNYgVCeQ== X-Google-Smtp-Source: ABdhPJzsrl0WyPgsyqO8ElBL9I9UlW++UVWpH2K+mqXepbt8w2iz9XOcSIaIFLyVMsPxBpaMKxdpBg== X-Received: by 2002:a63:e94a:0:b0:3c1:df82:94eb with SMTP id q10-20020a63e94a000000b003c1df8294ebmr21225922pgj.513.1651774163714; Thu, 05 May 2022 11:09:23 -0700 (PDT) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id c80-20020a621c53000000b0050dc7628132sm1726480pfc.12.2022.05.05.11.09.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 May 2022 11:09:23 -0700 (PDT) Date: Thu, 5 May 2022 11:09:20 -0700 From: Stephen Hemminger To: =?UTF-8?B?U3RhbmlzxYJhdw==?= Kardach Cc: dev , Frank Zhao , Sam Grove , Marcin Wojtas , upstream@semihalf.com, pbhagavatula@marvell.com Subject: Re: [PATCH 02/11] examples/l3fwd: fix scalar LPM compilation Message-ID: <20220505110920.256bfc73@hermes.local> In-Reply-To: References: <20220505173003.3242618-1-kda@semihalf.com> <20220505173003.3242618-3-kda@semihalf.com> <20220505103951.2c58b9d0@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 5 May 2022 19:49:28 +0200 Stanis=C5=82aw Kardach wrote: > On Thu, May 5, 2022 at 7:39 PM Stephen Hemminger > wrote: >=20 > > On Thu, 5 May 2022 19:29:54 +0200 > > Stanislaw Kardach wrote: > > =20 > > > The lpm_process_event_pkt() can either process a packet using an > > > architecture specific (defined for X86/SSE, ARM/Neon and PPC64/Altive= c) > > > path or a scalar one. The choice is however done using an ifdef > > > pre-processor macro. Because of that the scalar version was apparently > > > not widely excersized/compiled. > > > Due to some copy/paste errors, the scalar logic in > > > lpm_process_event_pkt() retained a "continue" statement where a BAD_P= ORT > > > should be returned after refactoring of the LPM logic in the l3fwd > > > example. > > > > > > Fixes: 99fc91d18082 ("examples/l3fwd: add event lpm main loop") > > > Cc: pbhagavatula@marvell.com > > > > > > Signed-off-by: Stanislaw Kardach > > > Sponsored-by: Frank Zhao > > > Sponsored-by: Sam Grove =20 > > > > Would be easier to get merged if bug fixes came as separate patch > > submission. > > =20 > Sure, I can post this separately. The reason for posting this along with > RISC-V patches is that those depend on this one. So I could add > "depends-on" but wanted be on the safe side. >=20 > > > > Also have not seen Sponsored-by before; what do you expect it to mean? > > Never used in DPDK or kernel git tree. > > =20 > The idea is that this work was sponsored by the companies mentioned in the > sign-off. It is used i.e. in FreeBSD though admittedly never in Linux or > DPDK. > Alternative, which makes checkpatch happy and was previously used is > "Suggested-by". However suggestion, doesn't necessary mean sponsorship. > I had a talk about this with Thomas Monjalon and he has also leaned towar= ds > "Sponsored-by". > I'm open to suggestions as I admit, I'm not sure which route is better. So it is just advertising. I did notice slightly different syntax in the kernel. Could we follow that precedent? Example: commit 0301bcd599e552c38adf6771c25ff99680b9c4ee Author: Bjoern A. Zeeb Date: Fri Jan 28 15:34:26 2022 +0200 iwlwifi: de-const properly where needed =20 In order to de-const variables simply casting through (void *) is not enough: "cast from 'const .. *' to 'void *' drops const qualifier". Cast through (uintptr_t) as well [1] to make this compile on systems with more strict requirements. In addition passing const void *data to dma_map_single() also drops the (const) qualifier. De-constify on variable on assignment which may be overwritten later. In either case the (void *) cast to dma_map_single() is not needed (anymore) either. =20 [1] See __DECONST() in sys/sys/cdefs.h in FreeBSD =20 Sponsored by: The FreeBSD Foundation Signed-off-by: Bjoern A. Zeeb Signed-off-by: Luca Coelho Link: https://lore.kernel.org/r/iwlwifi.20220128153014.eb696eb56bf6.Ide= 1dd041f9b908c5154a600286a7453750b0704a@changeid Signed-off-by: Luca Coelho