From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6DBA7A00BE; Mon, 16 May 2022 22:28:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 103A340A7A; Mon, 16 May 2022 22:28:15 +0200 (CEST) Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by mails.dpdk.org (Postfix) with ESMTP id E10E44068B for ; Mon, 16 May 2022 22:28:13 +0200 (CEST) Received: by mail-pl1-f175.google.com with SMTP id i17so15509578pla.10 for ; Mon, 16 May 2022 13:28:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FMgUevvggva8KZv2glo8yyMPmBK7werv63yYTp2w9f4=; b=Yi0c0FprhX8blA9Gj1V85XvtgqjC9UK93A8O37fS3E8V8mNxxjSSWdA2KMBcQsXiH0 leYos+sU5VaI3EkDI8tkku3/o1bATs4TjVi2DfKbhKv6GaUsLyhtyFoZ8N80SXzq5j86 td9ioGnLshTTl2jjkMwGhisvQghRNePiQY0QPFgpWmLu5A+ZYBg0fo/ncWb12B9T6dcn Tvcw+a5KAez1yRRtweLM35WK4HkSFKQWTTFKDjxCmvqY3jP1xGHFG3s4npeBbWh7h3oZ UzUizZNBuuYk9gwkAy9C5o3cjHXwgCjBHNDXFp8SLDl2aUQSXHx9T+RaIM1V77LiehQ6 qbLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FMgUevvggva8KZv2glo8yyMPmBK7werv63yYTp2w9f4=; b=nTSKqx/MuzhOfywP9ArOqR6TeblrgsRlrgXzUGW2cv70ODmAKLgvKJjnB//1mY6cah PoKj+aFvv/toK6AFeZ2CApX8ZNbRtJjtlkQ0PzK/SLQgM1wP/Eehae/SdbIeCdh+8iHk BRvME+/TOS8INT34fpoeMMXaxgEWiBfWfYeZU3VAty+eM85DLkxozgetXgaw/3I2aRY+ kSSIMc4YDNJeXO5I5VHXk1pExfL31vGllgaMZGZYZ8roS9ztXm3JzuINY45ijFz37DVJ JuN5Mzy75d1er+rCKeiP5OgCcrRJh4yrVFATGwzEWP8+VqOhyPX/kygzDwgYlV8wELFV bE3g== X-Gm-Message-State: AOAM530trNAIXqrqjfdG73JiHpvcxkivrKQGFy5TlqIQj2lCC//ayDaI DT7OueQk2mHZOE//NCvznZwMXQ== X-Google-Smtp-Source: ABdhPJwd3mTn2bu82bdzVCGFt6ggzc/zeH/uTC1obDzZ4XhN58gStJBhlJnsLm3msM+sZx+fCu2CwA== X-Received: by 2002:a17:902:ecd1:b0:15e:850b:c2d with SMTP id a17-20020a170902ecd100b0015e850b0c2dmr19158189plh.75.1652732892959; Mon, 16 May 2022 13:28:12 -0700 (PDT) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id ku18-20020a17090b219200b001cd4989fee4sm92091pjb.48.2022.05.16.13.28.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 May 2022 13:28:12 -0700 (PDT) Date: Mon, 16 May 2022 13:28:09 -0700 From: Stephen Hemminger To: Don Wallwork Cc: dev@dpdk.org, fengchengwen@huawei.com, mb@smartsharesystems.com, anatoly.burakov@intel.com, dmitry.kozliuk@gmail.com, bruce.richardson@intel.com, Honnappa.Nagarahalli@arm.com, nd@arm.com, haiyue.wang@intel.com Subject: Re: [PATCH v3] eal: allow worker lcore stacks to be allocated from hugepage memory Message-ID: <20220516132809.08e4c587@hermes.local> In-Reply-To: <20220516195004.10091-1-donw@xsightlabs.com> References: <20220502141058.12707-1-donw@xsightlabs.com> <20220516195004.10091-1-donw@xsightlabs.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 16 May 2022 15:50:04 -0400 Don Wallwork wrote: > +static int > +eal_parse_huge_worker_stack(const char *arg, size_t *huge_worker_stack_size) > +{ > + size_t worker_stack_size; > + char *end; > + if (arg == NULL || arg[0] == '\0') { > + *huge_worker_stack_size = WORKER_STACK_SIZE_FROM_OS; > + return 0; > + } Looks good. Minor nit if you do another version. Please put blank line after declarations.