From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 86B7EA0503; Thu, 19 May 2022 17:27:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 24F7240222; Thu, 19 May 2022 17:27:26 +0200 (CEST) Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by mails.dpdk.org (Postfix) with ESMTP id 1278B40156 for ; Thu, 19 May 2022 17:27:25 +0200 (CEST) Received: by mail-pf1-f182.google.com with SMTP id j6so5423936pfe.13 for ; Thu, 19 May 2022 08:27:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=UQh+9caqgyN7bz0Tgrxoj46Fiukpu1FCt4LkstLxM8s=; b=nmjV6c4+Cn8+8ap5OcTrttR/J2JznuCnvbhNJnDVobVkJ+TvcvopfD6mHxF3Bf7SeV PvFkGb/Ox3J2LIDV2v2fMs3yDe+VN/MCZ5rsOL/shBQWBq6bU5uW/izr+0XShqcRh6Td xmJ4NbdX9nljNOrYDh8GTNFLKaPTpBw2x7dFeK+JFenY5KwXN0lxlVLxsEUj1dNUGXEU rFwuuNPEKyMWEMcsjZxchjNIX46Q7rT+2DwxBO/LpF/ZMhG9VTImoyOKyrI+5MlRKqDh 37EttcqD8VuFmUKD55skS03UL7ymAcnhypY1daG/BJGFgLQCtttjrm97fP/LvTLafPb5 xWgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=UQh+9caqgyN7bz0Tgrxoj46Fiukpu1FCt4LkstLxM8s=; b=vkUAEjYCZ9y/IAYXvzo7git+SXwJh8sJXnqkIRLQuMxnvsaS9kmVYJAONT5euyVzry rfqKo8CXGqEqrF/l88VFumYCavTJyxK0qd/YXywKnyIfeIkxNYNlnkBj+BqTOg+K/ZQ4 8DiS0F1CE/OUFj4rMZ+Klkw8f1lqUxSJWACkuWs1CzksHOh4XV1Sy/ggeBwr2Yh9Be+N idezOaIrHAT7fheUX99mD2SvtoRnPAFesvKxm2Z4hPCSjaj3iLF1c9AEWF2b/HiLPduC 5l2LrbDxe6dnkP+8evPW2S7G8E2oZMum5XE4MosCkNbxuYBCXQUJA3+fnhcvt31fhVrb bOtA== X-Gm-Message-State: AOAM532BmnxD/wW2G3vHG0kotzXE4mLR76ZZeUrOrcm9lX8DkoHqAO9t q4QC5EPtY5vHkFMBrLuNeIJ5Jw== X-Google-Smtp-Source: ABdhPJz6VoIzO+0buPu9LPKrZMowrWKYXJ0xp8SpwzTfoiXKPUdCp00P19peeG8Oyh/gK3jyrUiNgg== X-Received: by 2002:a05:6a00:1709:b0:505:fa47:b611 with SMTP id h9-20020a056a00170900b00505fa47b611mr5338508pfc.65.1652974044197; Thu, 19 May 2022 08:27:24 -0700 (PDT) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id o124-20020a634182000000b003f5dbb3bb6csm3632892pga.91.2022.05.19.08.27.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 May 2022 08:27:23 -0700 (PDT) Date: Thu, 19 May 2022 08:27:21 -0700 From: Stephen Hemminger To: Wenjun Wu Cc: dev@dpdk.org, jingjing.wu@intel.com, beilei.xing@intel.com, qi.z.zhang@intel.com, simei.su@intel.com Subject: Re: [PATCH v2] net/iavf: fix race condition for multi-cores Message-ID: <20220519082721.5a09795d@hermes.local> In-Reply-To: <20220519073334.760947-1-wenjun1.wu@intel.com> References: <20220519011959.613966-1-wenjun1.wu@intel.com> <20220519073334.760947-1-wenjun1.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 19 May 2022 15:33:34 +0800 Wenjun Wu wrote: > > + if (dev->data->dev_conf.rxmode.offloads & > + RTE_ETH_RX_OFFLOAD_TIMESTAMP) > + rte_spinlock_init(&vf->phc_time_aq_lock); > + There is no reason this init needs to be only true with some flags. Just always do it.