From: Ed Czeck <ed.czeck@atomicrules.com>
To: dev@dpdk.org
Cc: ferruh.yigit@xilinx.com, ktraynor@redhat.com, bluca@debian.org,
Shepard Siegel <shepard.siegel@atomicrules.com>,
John Miller <john.miller@atomicrules.com>
Subject: [PATCH v2 5/7] net/ark: report additional errors from firmware
Date: Thu, 19 May 2022 17:36:40 -0400 [thread overview]
Message-ID: <20220519213642.2647946-5-ed.czeck@atomicrules.com> (raw)
In-Reply-To: <20220519213642.2647946-1-ed.czeck@atomicrules.com>
detect and report completion errors from firmware
Signed-off-by: Ed Czeck <ed.czeck@atomicrules.com>
---
drivers/net/ark/ark_rqp.c | 6 ++++--
drivers/net/ark/ark_rqp.h | 3 ++-
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ark/ark_rqp.c b/drivers/net/ark/ark_rqp.c
index ef9ccd0706..efb9730fe6 100644
--- a/drivers/net/ark/ark_rqp.c
+++ b/drivers/net/ark/ark_rqp.c
@@ -22,14 +22,16 @@ ark_rqp_stats_reset(struct ark_rqpace_t *rqp)
void
ark_rqp_dump(struct ark_rqpace_t *rqp)
{
- if (rqp->err_count_other != 0)
+ if (rqp->err_count_other || rqp->cmpl_errors)
ARK_PMD_LOG(ERR,
"RQP Errors noted: ctrl: %d cplh_hmax %d cpld_max %d"
ARK_SU32
+ ARK_SU32
ARK_SU32 "\n",
rqp->ctrl, rqp->cplh_max, rqp->cpld_max,
"Error Count", rqp->err_cnt,
- "Error General", rqp->err_count_other);
+ "Error General", rqp->err_count_other,
+ "Cmpl Errors", rqp->cmpl_errors);
ARK_PMD_LOG(INFO, "RQP Dump: ctrl: %d cplh_hmax %d cpld_max %d"
ARK_SU32
diff --git a/drivers/net/ark/ark_rqp.h b/drivers/net/ark/ark_rqp.h
index 6c8046062b..d09f242e1e 100644
--- a/drivers/net/ark/ark_rqp.h
+++ b/drivers/net/ark/ark_rqp.h
@@ -48,7 +48,8 @@ struct ark_rqpace_t {
volatile uint32_t cpld_pending_max;
volatile uint32_t err_count_other;
char eval[4];
- volatile int lasped;
+ volatile int32_t lasped;
+ volatile uint32_t cmpl_errors;
};
void ark_rqp_dump(struct ark_rqpace_t *rqp);
--
2.25.1
next prev parent reply other threads:[~2022-05-19 21:38 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-02 21:22 [PATCH 1/4] net/ark: update mpu code to match current hardware version Ed Czeck
2022-05-02 21:22 ` [PATCH 2/4] net/ark: update ddm " Ed Czeck
2022-05-02 21:22 ` [PATCH 3/4] net/ark: update udm " Ed Czeck
2022-05-02 21:22 ` [PATCH 4/4] net/ark: add new devices to support list Ed Czeck
2022-05-05 15:37 ` [PATCH v1 1/5] net/ark: update mpu code to match current hardware version Ed Czeck
2022-05-05 15:37 ` [PATCH v1 2/5] net/ark: update ddm " Ed Czeck
2022-05-05 15:37 ` [PATCH v1 3/5] net/ark: update udm " Ed Czeck
2022-05-05 15:37 ` [PATCH v1 4/5] net/ark: add new devices to support list Ed Czeck
2022-05-05 15:37 ` [PATCH v1 5/5] net/ark: add PMD support for devices as virtual functions Ed Czeck
2022-05-06 21:27 ` [PATCH v1 1/5] net/ark: update mpu code to match current hardware version Ed Czeck
2022-05-06 21:27 ` [PATCH v1 2/5] net/ark: update ddm " Ed Czeck
2022-05-06 21:27 ` [PATCH v1 3/5] net/ark: update udm " Ed Czeck
2022-05-06 21:27 ` [PATCH v1 4/5] net/ark: add new devices to support list Ed Czeck
2022-05-06 21:27 ` [PATCH v1 5/5] net/ark: add PMD support for devices as virtual functions Ed Czeck
2022-05-18 12:56 ` Ferruh Yigit
2022-05-18 12:54 ` [PATCH v1 1/5] net/ark: update mpu code to match current hardware version Ferruh Yigit
2022-05-19 10:13 ` Kevin Traynor
2022-05-19 21:36 ` [PATCH v2 1/7] devtools: add Atomic Rules acronyms for commit checks Ed Czeck
2022-05-19 21:36 ` [PATCH v2 2/7] net/ark: update MPU functions for firmware update Ed Czeck
2022-05-19 21:36 ` [PATCH v2 3/7] net/ark: update DDM " Ed Czeck
2022-05-19 21:36 ` [PATCH v2 4/7] net/ark: update UDM " Ed Czeck
2022-05-19 21:36 ` Ed Czeck [this message]
2022-05-19 21:36 ` [PATCH v2 6/7] net/ark: add new devices to support list Ed Czeck
2022-05-20 8:14 ` Andrew Rybchenko
2022-05-19 21:36 ` [PATCH v2 7/7] net/ark: add PMD support for devices as virtual functions Ed Czeck
2022-05-20 14:15 ` [PATCH v2 1/7] devtools: add Atomic Rules acronyms for commit checks Ed Czeck
2022-05-20 14:15 ` [PATCH v2 2/7] net/ark: update MPU functions for firmware update Ed Czeck
2022-05-23 14:39 ` Ferruh Yigit
2022-05-20 14:15 ` [PATCH v2 3/7] net/ark: update DDM " Ed Czeck
2022-05-20 14:15 ` [PATCH v2 4/7] net/ark: update UDM " Ed Czeck
2022-05-20 14:15 ` [PATCH v2 5/7] net/ark: report additional errors from firmware Ed Czeck
2022-05-20 14:15 ` [PATCH v2 6/7] net/ark: add new devices to support list Ed Czeck
2022-05-20 14:15 ` [PATCH v2 7/7] net/ark: add PMD support for devices as virtual functions Ed Czeck
2022-05-23 14:38 ` Ferruh Yigit
2022-06-07 15:49 ` [PATCH v3 1/7] devtools: add Atomic Rules acronyms for commit checks Ed Czeck
2022-06-07 15:49 ` [PATCH v3 2/7] net/ark: update MPU functions for firmware update Ed Czeck
2022-06-07 15:49 ` [PATCH v3 3/7] net/ark: update DDM " Ed Czeck
2022-06-07 15:49 ` [PATCH v3 4/7] net/ark: update UDM " Ed Czeck
2022-06-07 15:49 ` [PATCH v3 5/7] net/ark: report additional errors from firmware Ed Czeck
2022-06-07 15:49 ` [PATCH v3 6/7] net/ark: add new devices to support list Ed Czeck
2022-06-07 15:49 ` [PATCH v3 7/7] net/ark: add PMD support for devices as virtual functions Ed Czeck
2022-06-07 21:31 ` [PATCH v4 1/7] devtools: add Atomic Rules acronyms for commit checks Ed Czeck
2022-06-07 21:31 ` [PATCH v4 2/7] net/ark: update MPU functions for firmware update Ed Czeck
2022-06-07 21:31 ` [PATCH v4 3/7] net/ark: update DDM " Ed Czeck
2022-06-07 21:31 ` [PATCH v4 4/7] net/ark: update UDM " Ed Czeck
2022-06-07 21:31 ` [PATCH v4 5/7] net/ark: report additional errors from firmware Ed Czeck
2022-06-07 21:31 ` [PATCH v4 6/7] net/ark: add new devices to support list Ed Czeck
2022-06-07 21:31 ` [PATCH v4 7/7] net/ark: add PMD support for devices as virtual functions Ed Czeck
2022-06-08 8:41 ` [PATCH v4 1/7] devtools: add Atomic Rules acronyms for commit checks Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220519213642.2647946-5-ed.czeck@atomicrules.com \
--to=ed.czeck@atomicrules.com \
--cc=bluca@debian.org \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@xilinx.com \
--cc=john.miller@atomicrules.com \
--cc=ktraynor@redhat.com \
--cc=shepard.siegel@atomicrules.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).