From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C6FCDA0093;
	Fri, 20 May 2022 22:28:12 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 7186140222;
	Fri, 20 May 2022 22:28:12 +0200 (CEST)
Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com
 [209.85.214.176])
 by mails.dpdk.org (Postfix) with ESMTP id 2A86F40156
 for <dev@dpdk.org>; Fri, 20 May 2022 22:28:11 +0200 (CEST)
Received: by mail-pl1-f176.google.com with SMTP id i1so8255570plg.7
 for <dev@dpdk.org>; Fri, 20 May 2022 13:28:11 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20210112.gappssmtp.com; s=20210112;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=CqQczrsEA5pEZGy5VLTV7A8xFXju84SWoCwKeuJrwDQ=;
 b=WR7kJvbKvYKZn72SUeRRvn4flivfojhYIlbJySSd5v7Rvkr7pIzYig7pinPHQNJeAe
 6BgH9v8tE4YpyjjtibKrR666b740ygRkNEgRJgTxBCm0zhJebs7vpTZ05y74cX2t9N7Z
 az1I1xmCj7IRQPrJ0oaJDpgGBXQlHt1X48ZlnQLlbcAgbAkork3W7XPHavI2MS2B8FMO
 HmfVVEko/k4d4IxO7Y3SUVy8kK5A0VihM6Cf6S48KUrw/pyWqbKe+HrYuyRjvlc0mqNb
 2a6b6frndvXbQ+1Z5DTg/CMa/tZQDGWQ3W8ydOfwmdMZI06CcHxCuHfg1jfWHihZUEqA
 NhFQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=CqQczrsEA5pEZGy5VLTV7A8xFXju84SWoCwKeuJrwDQ=;
 b=p5lGjtz/XkSu1kKNG4SDhAOlS0gGp0GVGrNYD+1g38n/jLfd2fX3rxwjY63VWhmW+r
 GQqf+nFRLUHZe+aUjI4CaQ0Hs3nGmJy1fXG8p46LQJtYFPC12qElVICiSJ5RJtj0cHv4
 5PRs50EX00Lpc7+LBr7y7qn5ieR2rMvhsizOai8RSxMOg0VQ6tsFPB+nW2DYCfZ3BhwA
 F7TDrF8JW1Q4brO8cnrcnnHtOaoP4NIElWfZE0IP0d7YoBDzP8aN9iPwB863g8bUs5or
 mNoV35NZ0ZPXpi6ggt4RWfxXTEZ1NLbylfECzFVbKPIENo3bbbq8zMxj5o/pM+1iWCNZ
 gVeA==
X-Gm-Message-State: AOAM530FCovCPfytru6qHH1P3pdiFsruQ5lxnSD03yn4njqOfNzRkr0q
 nnobtOjnZe8LHBbrKeUaiaZdhw==
X-Google-Smtp-Source: ABdhPJy3LjUS7saijhDpmjQ+c6RS1H+thfnfyqas7VkclCv+EraU3seNnv4uXd+R4yHiiq4Ncf7ncQ==
X-Received: by 2002:a17:902:6805:b0:161:8214:c170 with SMTP id
 h5-20020a170902680500b001618214c170mr11679002plk.11.1653078490294; 
 Fri, 20 May 2022 13:28:10 -0700 (PDT)
Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199])
 by smtp.gmail.com with ESMTPSA id
 y68-20020a62ce47000000b005184af1d72fsm2387918pfg.15.2022.05.20.13.28.09
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 20 May 2022 13:28:09 -0700 (PDT)
Date: Fri, 20 May 2022 13:28:07 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, thomas@monjalon.net, ferruh.yigit@xilinx.com,
 stable@dpdk.org, Marcin Wojtas <mw@semihalf.com>, Michal Krawczyk
 <mk@semihalf.com>, Shai Brandes <shaibran@amazon.com>, Evgeny Schemeilin
 <evgenys@amazon.com>, Igor Chauskin <igorch@amazon.com>
Subject: Re: [PATCH 04/12] net/ena: fix build with GCC 12
Message-ID: <20220520132807.57005bc1@hermes.local>
In-Reply-To: <20220518101657.1230416-5-david.marchand@redhat.com>
References: <20220518101657.1230416-1-david.marchand@redhat.com>
 <20220518101657.1230416-5-david.marchand@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Wed, 18 May 2022 12:16:49 +0200
David Marchand <david.marchand@redhat.com> wrote:

> +		for (i = 0; i < RTE_DIM(default_key); ++i)
>  			default_key[i] = rte_rand() & 0xff;

We should have rte_random_bytes() functionality if this gets
used often.

Also, worth considering dropping DPDK random number generator
in userspace for security reasons and just using more secure kernel code.