From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B07B7A0503; Fri, 20 May 2022 17:12:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 646C340222; Fri, 20 May 2022 17:12:52 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 1335C40156; Fri, 20 May 2022 17:12:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653059570; x=1684595570; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Q2wqWdg30egDCCS5TVQth7YaObG8BnM9/8pFrgJQVTk=; b=dnlzs9bkSLastEU86wRsFflsUbCVMAoSO0hwS3PI3voXpS/8rMZk/5FC 3IJPUyHGTRUBmDWELSAU9fmO3BqOgSKpebrAZrFoOba4emFNwsxjkmxlQ yRJWZ7rAsoHO39DhIe7NdYOih8ds2FCet3WuLQN5sDOXGRRD0dKYVqF+t jGr8GuPdgRflDsB++BtsqQY+TGdNtWF4iAJdnYxLSJ90IBC6dlYTFaPwN l2QytoULyIZcGrskDqrI1U4/ru+Y1ozRU+Nr5W6F613zllgpvwBjBLN+l x9ZEc45A7DxOoWzBZbESpB0Ofq7RXOnJRbCU5/EjZtrhztPFg2gZ6Qvxa A==; X-IronPort-AV: E=McAfee;i="6400,9594,10353"; a="260216929" X-IronPort-AV: E=Sophos;i="5.91,239,1647327600"; d="scan'208";a="260216929" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2022 08:12:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,239,1647327600"; d="scan'208";a="599263702" Received: from silpixa00401385.ir.intel.com (HELO silpixa00401385.ger.corp.intel.com.) ([10.237.223.87]) by orsmga008.jf.intel.com with ESMTP; 20 May 2022 08:12:47 -0700 From: Bruce Richardson To: dev@dpdk.org Cc: stable@dpdk.org, weiyuanx.li@intel.com, Bruce Richardson Subject: [PATCH v2 0/2] fix uncallable unit tests (Bugzilla 1002) Date: Fri, 20 May 2022 16:12:38 +0100 Message-Id: <20220520151240.139566-1-bruce.richardson@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220520145631.137962-1-bruce.richardson@intel.com> References: <20220520145631.137962-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The dump* unit tests are uncallable from our test framework because the command validation in the unit test binary is incorrect. Rather than trying to fix this directly in the binary, a better approach is to add command validation to the cmdline library - which already has 99% of what we need already - and use that from the test app. V2: * Fix checkpatch issues Bruce Richardson (2): cmdline: add function to verify valid commands test: use cmdline library to validate args app/test/commands.c | 11 ----------- app/test/test.c | 24 +++++++----------------- lib/cmdline/cmdline_parse.c | 20 +++++++++++++++++--- lib/cmdline/cmdline_parse.h | 17 +++++++++++++++-- lib/cmdline/version.map | 3 +++ 5 files changed, 42 insertions(+), 33 deletions(-) -- 2.34.1