From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EC984A04FF; Tue, 24 May 2022 16:49:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D432C40140; Tue, 24 May 2022 16:49:03 +0200 (CEST) Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by mails.dpdk.org (Postfix) with ESMTP id 0D051400D6 for ; Tue, 24 May 2022 16:49:02 +0200 (CEST) Received: by mail-pj1-f41.google.com with SMTP id v5-20020a17090a7c0500b001df84fa82f8so2378412pjf.5 for ; Tue, 24 May 2022 07:49:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Iq9eEG0z1HitzrEEma8Xp3Sx4MarYaSvi3YE9rXpXMg=; b=QhIeI+7VIVud5aR4lTqC0RRb59dWKNWbXd+iKq37yDs8k1jDocdtMTZzW1tFlqE4tr dW/JSlAusLGBoUeCYsszf2QZKRhn95E7hA/urzB5GAUpH/VZ6i8rWWWA63IDFX5b6+Kw GFwxjsirfetDu7CB9F078VeAtqNT91fj4r30DaTdz9g2/Z+MyYw4auHcCaLhNa/XilyU R6L6wGDnECH4rqN9mD2GTaFWmaeiDroJDg48mLGU1aW3RIHU1KUGHVEX+wkJQKZ/edSb sfOkNHjN6qw3WTlwM7GUMgsCRZbN/0JQHX7krtHsrhjtAs3zP+OGqQsLISX5uted5kD/ XkmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Iq9eEG0z1HitzrEEma8Xp3Sx4MarYaSvi3YE9rXpXMg=; b=ltj1lgeAmGCIanIISosbhQSErrJu7TJPnHBulgYF/xXKmAoibhMOklAiugfMGgC+Id I02T0c21ffRdU0vHIhVtVkQsaX3jq+7uPW36HezkhI/Qz1eyR8B6XaqYfXNGWrOoA6d1 s+NrN2O4tVtbAcMvhC63a99umI3hd8OGs1TnilqFZuo8Hgi860CR/xFIDo5ufhewg17j jZ8T+vesiEUbIVIfJupw0se9eLdwFqAWdAE67ugKhycxkeAHwE7EmTofnQbx/oZknKyY zhcz0avqWp9fCSugD6zgVRDjzyncnPrPTyoKbrDQp6VkLF9Hjmgv6yqj/VobviZrLHsW KH3w== X-Gm-Message-State: AOAM532P/QfTBk8xvADODrmO0xZ7CYzG8F4rTavIuQpJf+wQiCdlqSb1 3acb025bdqhKIEA1SVVwAeTZMEvAAp2JJA== X-Google-Smtp-Source: ABdhPJydE8u8qulf/IhXIrverkUDJevEvFqXJLVzyIRdD/OrpgTuFnIbEPAMz8JpX1RmglvxC19AeQ== X-Received: by 2002:a17:902:f710:b0:15f:165f:b50b with SMTP id h16-20020a170902f71000b0015f165fb50bmr28488748plo.158.1653403741178; Tue, 24 May 2022 07:49:01 -0700 (PDT) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id z17-20020a170903019100b00161c3fc7a44sm7514960plg.108.2022.05.24.07.49.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 May 2022 07:49:00 -0700 (PDT) Date: Tue, 24 May 2022 07:48:57 -0700 From: Stephen Hemminger To: Kevin Laatz Cc: dev@dpdk.org, Morten =?UTF-8?B?QnLDuHJ1cA==?= Subject: Re: [PATCH v4] eal: add bus cleanup to eal cleanup Message-ID: <20220524074857.4b22e9eb@hermes.local> In-Reply-To: <20220524092501.419761-1-kevin.laatz@intel.com> References: <20220419161438.1837860-1-kevin.laatz@intel.com> <20220524092501.419761-1-kevin.laatz@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 24 May 2022 10:25:01 +0100 Kevin Laatz wrote: > + > + RTE_LOG(DEBUG, EAL, > + "Clean up PCI driver: %s (%x:%x) device: "PCI_PRI_FMT" (socket %i)\n", > + drv->driver.name, dev->id.vendor_id, dev->id.device_id, > + loc->domain, loc->bus, loc->devid, loc->function, > + dev->device.numa_node); > + No message is needed here.> > + RTE_LOG(ERR, EAL, "Cleanup for device "PCI_PRI_FMT" failed\n", > + dev->addr.domain, dev->addr.bus, dev->addr.devid, > + dev->addr.function); As Bruce said, the driver probably already logged something. So no message, or make it a DEBUG message.