From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 24D7DA04FF; Tue, 24 May 2022 15:33:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B298640140; Tue, 24 May 2022 15:33:40 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 147C3400D6 for ; Tue, 24 May 2022 15:33:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653399219; x=1684935219; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=9UHHL/Y98xYQFLehYe3lSkXWKmrsftbip8AgNmZ1kb8=; b=B8JI7GUIrIbvbzDWIbPd1SNdMS42pL8hJlEzkSwgBHs/4yQa2rglGvy7 C3DpfI6Kg/BSDuAwZGPRCEM2NEzzLgmO/H2sWc2PanjIH2BYcCLaJIPst V/RKSwJUAToPUz62etL5RPLDgrySgKFYFOPMn5bIbXfkFAnZZAEpdU3FA eBFk0iebQtGlVh66lh/Hb3HPbWjdjiZvecjaiaOkZSTOy3+bhAITr1aYs hYvWUodJ8DgNETuAWt+na6h/Vpc05xoiFqwsNWMYnD8QQKaEPt3X/v7bC UYF0FafAQiFb9RHpqXvSIXtt53qfRHOsSLWhCzQEZHayBeE/KZI9DHZkI Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10356"; a="273526330" X-IronPort-AV: E=Sophos;i="5.91,248,1647327600"; d="scan'208";a="273526330" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2022 06:33:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,248,1647327600"; d="scan'208";a="572660561" Received: from silpixa00400629.ir.intel.com ([10.237.213.88]) by orsmga007.jf.intel.com with ESMTP; 24 May 2022 06:33:35 -0700 From: Marcin Danilewicz To: cristian.dumitrescu@intel.com Cc: dev@dpdk.org, jasvinder.singh@intel.com, marcinx.danilewicz@intel.com, megha.ajmera@intel.com, sham.singh.thakur@intel.com Subject: [PATCH v3] sched: enable/disable TC OV at runtime Date: Tue, 24 May 2022 13:33:31 +0000 Message-Id: <20220524133331.643801-1-marcinx.danilewicz@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Megha, Marcin, > Yes, I agree this would be the ideal way to drive this change, but the problem is that modifying the existing subport parameter structure would represent an API change. This would require a deprecation notice, and the patch would be blocked until 22.11 release. Are you willing to wait until 22.11? If not, then adding the configuration function for this flag is the next best thing. Are we making any plans for that? > > Also the name of the feature should not be abbreviated in the patch title. > > In original code, this feature has always been disabled as it impacts >> performance. > > So, in my opinion we should keep it disabled by default and let user enable it > > when required. > > > In the original code, yes, it had to be explicitly enabled through a build-time flag. This was not the best option, and this is precisely what we are trying to fix with this patch. > But on the other hand all the users of these library that I know use it with the TC oversubscription turned on. Functionality is more important for them than performance. Hence my vote now is to enable it by default; those users that prefer performance over functionality can easily turn this feature off with no issues. That was plan for this patch and yet another change to remove API change is awaiting. But when we publish this change. BR, /Marcin -------------------------------------------------------------- Intel Research and Development Ireland Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.