From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 97AF4A0545; Wed, 25 May 2022 02:41:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 094D342824; Wed, 25 May 2022 02:41:03 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2070.outbound.protection.outlook.com [40.107.223.70]) by mails.dpdk.org (Postfix) with ESMTP id 950AE40C35 for ; Wed, 25 May 2022 02:40:53 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aVj+o3unHj1phw4kkd+/fpKFMyw5wiiGvE3xwrsYzi8dBoGixuEDCYNgLFQMfgRaKUFPbGAaO+gByQIhNES6v1/cDW5WYge5qT4A9bQTIli4zz8qSLic1uoOstXfgAbqavDtmFYIO4MnY3C1yWdx/QJ4rMse570bQlsOh1Lr0ilVyaeIp6ReQviwmkGNuez4TAkU6u/EKBWwCIpL4s8SlX/vPk+851HHidB/bGHe824FMOYOMvBZzGMvN82/GD/DN7hbV304rJaE0n0Jv0uV5cWNUaXjk3NAWwBsxusaXYrnviNPewdzrr5+OcgeoH5/kBMKTEIwEFMPENltiuGMmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=szvzva9e7Ay2q+fQbrQputerDjGq5GXbxWkcC4vLwgg=; b=d44uHO815nfQ1SnpkR+3k+5/77l2q15+AnqotfkBRhr6hZj2keY7BS9YVxSPRlQbXtC6XTrgtddWVbglRq55hatpkq2QXJ349CD1iGi8yggx5mh/+3/QHbxyVnx/BTCNzN9Y3QmajCHowUXUzISM2WjYqcMOI4VsSq+qDXLTx2+wvszSMzsKfyNzhk2chTv1QgUjEbry4VNGr2QY190aUb7FPHCGdH9b7XbxqFIfwkySPZmiw1cIMx79t6LdQHYoDI4yNIBXCmqTu9lxkZXYmOJTvIA6sTPyEi09EcD5kvrFLRVfTf0xNkv7aXKVQ5nna1ToOEzdb6yISTsXcCcNcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vmware.com; dmarc=pass action=none header.from=vmware.com; dkim=pass header.d=vmware.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vmware.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=szvzva9e7Ay2q+fQbrQputerDjGq5GXbxWkcC4vLwgg=; b=fWahZVFGabkEOPZc3dUwZEPDH8oN3z+KyS8x2gwT9y46dG2ZsDdHxShfbwIQqJg1aZzBsgtGXXpAIdZ5fa2ZhcFg0neIZ7JuaA9bTOrBCaC3vGAf9gfahQZnKUZkfLvEy2ioPn4XPkwpi3inGVDMKKpoe7HPrF0nODaCo//VQtQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vmware.com; Received: from BYAPR05MB5624.namprd05.prod.outlook.com (2603:10b6:a03:1d::13) by SN7PR05MB7534.namprd05.prod.outlook.com (2603:10b6:806:f7::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.7; Wed, 25 May 2022 00:40:52 +0000 Received: from BYAPR05MB5624.namprd05.prod.outlook.com ([fe80::49ad:2ac7:16c0:51c8]) by BYAPR05MB5624.namprd05.prod.outlook.com ([fe80::49ad:2ac7:16c0:51c8%6]) with mapi id 15.20.5293.013; Wed, 25 May 2022 00:40:52 +0000 From: Pankaj Gupta To: jbehrens@vmware.com Cc: dev@dpdk.org, pagupta@vmware.com Subject: [PATCH v6 7/9] net/vmxnet3: advertise RETA size in device info Date: Tue, 24 May 2022 17:40:26 -0700 Message-Id: <20220525004028.24938-8-pagupta@vmware.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220525004028.24938-1-pagupta@vmware.com> References: <20220525004028.24938-1-pagupta@vmware.com> Content-Type: text/plain X-ClientProxiedBy: SJ0PR05CA0056.namprd05.prod.outlook.com (2603:10b6:a03:33f::31) To BYAPR05MB5624.namprd05.prod.outlook.com (2603:10b6:a03:1d::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 292887b6-893d-4e12-cd7a-08da3de736fb X-MS-TrafficTypeDiagnostic: SN7PR05MB7534:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 160uFBThcMjlARNiMyBfJF2JNNEahTLkM/zAVND3GYd4m2xlbReITrI8XPjp2462BQACGjrZWZesQIWH1KxN4VLtIFg2OdUIZo0BS6sM7YhOERb2f5GEWz1PX7vk3vuY9bpezThpyBzDN0WQqJSI+qMphzf7a5uuIqReLbAKXO26/zIO9verl/1uTbJ1gFrvGyIkzxZ3cCMVX2JObiEAHoQ0KWrfwHIKlF90q8jA0k+d+DgzqmflFTcb3wwq+K9pPX6CWmCnjy4tz9LB56x/++d3POhBP9rQTDghMdGtgYw/XH91hFF6CirVcNFVqeRBeEA7mj8wU2SGfqRODtiAL90qneoe9C6msSLZl/iMwX70xMQ5auir8RwrU3/EEEHSB3Z6Quu+/lbFmLdtZCBtnzzleoy5kBaoQkUTEACMSYvwxuY/cKZhSL2hsRAvgn3yVw3zZ9bAzdKQceD4uxMrGxIytx4qdXgwyqmbdlgdbEaTeUH6vOLAulhlH4MiHtNils8Jfv+Hb/C/lfJbPVIyNsknHCs5oLHiMtqSsuZ5UGqLahv4qvcVltEwRZuTyule1VPgtM4L8dLHSJnHWcMGgiKdwbn3umIfI6X3HrTZqqaCNgdIMGp3vo/6s+L5w5al1UWPaBhFRQvCY2Uv/skjotc5SJTow09oHo+C1lN/U7CXJalbIb3Vr+u6ZvVx+TlxkRDUGSIevuvJQOX/2gI5CUY9AV6PoO7ld3cEYIWiMIaMrekfRGlL5h0Oa4Dr8cgL X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR05MB5624.namprd05.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(316002)(38100700002)(5660300002)(38350700002)(8936002)(186003)(52116002)(2616005)(36756003)(6506007)(1076003)(6486002)(6666004)(508600001)(37006003)(6512007)(6636002)(107886003)(83380400001)(8676002)(34206002)(4326008)(66476007)(66556008)(66946007)(86362001)(2906002)(26005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?72qQY8aMK5dWpo+Pdk9RjboPvMVTRFeo1ImGo6MbB5LHOwnnFRa/6zkoQ4QK?= =?us-ascii?Q?2NCPsG/IjPeor2QZFFlP+4peq6QxdvBh+NslM/QipetnrjYVJtjyV8MsGmdX?= =?us-ascii?Q?1O+LUuS2fCJ8CTkglfYJROGgdNrD1aiGJP8PGXWzlz2zJ3H1jfoPmWrIA3o6?= =?us-ascii?Q?riXIwSxyEtnJ2htUUFQhKRCwlw/KEk9MLixV+HMkB3n6Ve8A/4D6v/FzgsuD?= =?us-ascii?Q?haf+UA6EWmmf3PjUhsRvyaUvoAIUTVj38gncW664FOerfzj3S1sTpl8yL1oG?= =?us-ascii?Q?QitXyThM4Qtwg/vtKptcaqoqiJZjSe4WjU4AkPD/KuWa2k2Z575U8Zg1DMqz?= =?us-ascii?Q?EUXF9YdgLeDY0YfENLqZn0/NYIBYrJ0Kok5/CUPRcAG/5gYvy5R11Dt0UFBU?= =?us-ascii?Q?fk/XXBSbnzEfAoI40jiCW3gzP+s4lC+xNkzjipk8vod9256Ri5GhqTHrVLqJ?= =?us-ascii?Q?oBiEREEG+kz7QzLh7ooSolvQsD4rirhTLYC6j+H3xWKT8lvbAcXzqpxSWp8m?= =?us-ascii?Q?Kc/h4zmcefOkH+0m0zPfx5zExkh5zhjTewhJqQ5fsIgvtPdqjY5tOsow1PCZ?= =?us-ascii?Q?UVLG8TDrcxzFumH+d9CDyL4pRvq+p12pfR+Cjh5O8gFZ3ze5u6d9V7HM91hN?= =?us-ascii?Q?7Vyb7UcZ0egVdSJQC1hSCqhhUn40X9rSbzAn3ouETJimWFWLEEGuBmaibSrA?= =?us-ascii?Q?3cqeLC6OYoHyqGrr9l3u7ZS1MfYAlOpP/992ZadfBc5csg3vjzN4xS6+dBOe?= =?us-ascii?Q?IKzKT0VD1malvl3vJwIyxvp6pOzC1Rgd+TJmOKhMFxyErfsgALZ0Jw/SxaWi?= =?us-ascii?Q?VCHKh50Ts3wCmxAzObpOHmbQUTg0z8t0pyZ63a+3RhpKoQIiPZ6Fgz+bYKAz?= =?us-ascii?Q?fFEareDlkHpkIatc3iYgp26+Hoi/ncCEk2yebGbVbIAk5qwBGa8sI9f2Ez46?= =?us-ascii?Q?EH0z+TcB2Y90nKp5Sva75E45nwLcqPt86wjam68LUxLoEnlUKNGb8Olg8GmT?= =?us-ascii?Q?pzUQIl1UDukVBJoNAROl3whGmv8es/ppPvXn2AlCXyzASIkmgRrhfet7is2F?= =?us-ascii?Q?Rgke2zqja7xOZkt/Lw8EQC6fwLH5Hxy5VgKONBTaapMd/EC8IXsmUwAObukn?= =?us-ascii?Q?ti/pCsXZqB2wVApE63+pAQbFOezjj6CeZpM9hFrFrhs6MM2OTHVoFwVBYBpX?= =?us-ascii?Q?AfhIWnDd43MmguXlDLMO4f7SRHT7lsKbyS4AJFfCN1R2l4g3Vgv8ndtv4Uza?= =?us-ascii?Q?5F86sXf/+34T8blngvxC7iR6PWpjbOBCtzReSCcdt72bfadcMmJZCluytwNn?= =?us-ascii?Q?x2LnxLf6eGd0HH9LoGUueB4wQhcWED5S6pmyZMt+YB7vi80ptguccJ4pAq0M?= =?us-ascii?Q?kkNZcd8pflosu40iox1cG+SxagR/Nt9UL5vxICnqQC/8UiucAH8aTgUQxer+?= =?us-ascii?Q?JdlfFqorO3Q4P2XmNJvjE8P3OTevdJeh0KKjAjanEQC2AAANOKfo5UTwzxjJ?= =?us-ascii?Q?NB9fd6BkqZRfFyzFZfNXeMFAYgme2cfPDOj7/HZvnAOh7KFP5RwCpvufiLyr?= =?us-ascii?Q?2kD8ZvxWc5xRlfRADHDxEcmwQmMl6HAL0gNDShoaYJmJRMPqeYdfWSrGdVnJ?= =?us-ascii?Q?WvKqf/9Osl1RFkrmSlrmtYzCcciPk6+/9WOkDBzNH/sRCK7zyl71yfPfgOe7?= =?us-ascii?Q?vYeuIRdl9TamAYeTpM7PieF+E/rz6FF+6q88MquT8tZ3a3xaZr/G2nbBysZu?= =?us-ascii?Q?UDryYMqBHg=3D=3D?= X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-Network-Message-Id: 292887b6-893d-4e12-cd7a-08da3de736fb X-MS-Exchange-CrossTenant-AuthSource: BYAPR05MB5624.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2022 00:40:49.7276 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Y+zY4CN/cvIdTzUWCCerMldaTOEpZ90Knmrh6RanFUxQO1Ity5dkaLRb1PYIxcg1mItzYRiV72VP6g4v3SzidA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR05MB7534 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Currently the driver assumes that the size of the RETA table is four times the number of Rx queues at multiple places. However, it sets it to four times the maximum number of queues (4 * 32 = 128) when it first initializes the device. Change the other uses to use the stored value, not the assumed default. Tested, using testpmd, for different hardware versions on ESXi 7.0 Update 2. Signed-off-by: Pankaj Gupta Reviewed-by: Jochen Behrens --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c index 52309811e5..c9e352b73a 100644 --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c @@ -1479,7 +1479,12 @@ vmxnet3_dev_info_get(struct rte_eth_dev *dev, dev_info->rx_queue_offload_capa = 0; dev_info->tx_offload_capa = VMXNET3_TX_OFFLOAD_CAP; dev_info->tx_queue_offload_capa = 0; - + if (hw->rss_conf == NULL) { + /* RSS not configured */ + dev_info->reta_size = 0; + } else { + dev_info->reta_size = hw->rss_conf->indTableSize; + } return 0; } -- 2.17.1