DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] app/procinfo: show all non-owned ports
@ 2022-05-10 13:21 Subendu Santra
  2022-05-23 10:53 ` Subendu Santra
  2022-05-25  5:52 ` [PATCH v2] " Subendu Santra
  0 siblings, 2 replies; 12+ messages in thread
From: Subendu Santra @ 2022-05-10 13:21 UTC (permalink / raw)
  To: Maryam Tahhan, Reshma Pattan, Stephen Hemminger, Hemant Agrawal
  Cc: dev, Subendu Santra

Show all non-owned ports when no port mask is specified

Fixes: 1dd6cffb6571 ("app/procinfo: provide way to request info on owned
ports")
Cc: stephen@networkplumber.org

Signed-off-by: Subendu Santra <subendu@arista.com>
---
 app/proc-info/main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/proc-info/main.c b/app/proc-info/main.c
index 56070a3317..2be24b584e 100644
--- a/app/proc-info/main.c
+++ b/app/proc-info/main.c
@@ -1504,10 +1504,10 @@ main(int argc, char **argv)
 	if (nb_ports == 0)
 		rte_exit(EXIT_FAILURE, "No Ethernet ports - bye\n");
 
-	/* If no port mask was specified, then show non-owned ports */
+	/* If no port mask was specified, then show all non-owned ports */
 	if (enabled_port_mask == 0) {
 		RTE_ETH_FOREACH_DEV(i)
-			enabled_port_mask = 1ul << i;
+			enabled_port_mask |= (1ul << i);
 	}
 
 	for (i = 0; i < RTE_MAX_ETHPORTS; i++) {
-- 
2.28.0


^ permalink raw reply	[flat|nested] 12+ messages in thread
* [PATCH v2] app/procinfo: show all non-owned ports
@ 2022-05-25  5:46 Subendu Santra
  2022-05-25  6:04 ` Stephen Hemminger
  0 siblings, 1 reply; 12+ messages in thread
From: Subendu Santra @ 2022-05-25  5:46 UTC (permalink / raw)
  To: Maryam Tahhan, Reshma Pattan, Stephen Hemminger, Hemant Agrawal
  Cc: dev, Subendu Santra

Show all non-owned ports when no port mask is specified

show-port option without the mask option, displays only the last
non-owned port. Show all the non-owned ports instead.

Fixes: 1dd6cffb6571 ("app/procinfo: provide way to request info on owned
ports")
Cc: stephen@networkplumber.org

Signed-off-by: Subendu Santra <subendu@arista.com>
---
 app/proc-info/main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/proc-info/main.c b/app/proc-info/main.c
index 56070a3317..2be24b584e 100644
--- a/app/proc-info/main.c
+++ b/app/proc-info/main.c
@@ -1504,10 +1504,10 @@ main(int argc, char **argv)
 	if (nb_ports == 0)
 		rte_exit(EXIT_FAILURE, "No Ethernet ports - bye\n");
 
-	/* If no port mask was specified, then show non-owned ports */
+	/* If no port mask was specified, then show all non-owned ports */
 	if (enabled_port_mask == 0) {
 		RTE_ETH_FOREACH_DEV(i)
-			enabled_port_mask = 1ul << i;
+			enabled_port_mask |= (1ul << i);
 	}
 
 	for (i = 0; i < RTE_MAX_ETHPORTS; i++) {
-- 
2.28.0


^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2022-06-26 15:26 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-10 13:21 [PATCH] app/procinfo: show all non-owned ports Subendu Santra
2022-05-23 10:53 ` Subendu Santra
2022-05-23 14:41   ` Thomas Monjalon
2022-05-23 16:10     ` Subendu Santra
2022-05-23 18:00       ` Thomas Monjalon
2022-05-25  5:52 ` [PATCH v2] " Subendu Santra
2022-05-25  5:58   ` Subendu Santra
2022-05-25  5:46 Subendu Santra
2022-05-25  6:04 ` Stephen Hemminger
2022-05-25  7:14   ` Morten Brørup
2022-06-06 14:20     ` Subendu Santra
2022-06-26 15:26     ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).