From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id CDBBDA054F;
	Wed, 25 May 2022 12:01:54 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id B89C540146;
	Wed, 25 May 2022 12:01:54 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 66374400EF;
 Wed, 25 May 2022 12:01:53 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id A6D7720B71D5; Wed, 25 May 2022 03:01:52 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com A6D7720B71D5
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1653472912;
 bh=9Yf2mc2wodCrxucTcFZXGZrKSMTGUSGL7HzZdsVu+/Y=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=eqDlvsWS2POhL2C0aZRRu9BG8nCuSMZp1jigI3c9Fbj0yQirdENzhmvGWoQNZz/my
 1M6T3tsBojKe+5wsKEJEvjK2FCpWIrWlSAWvv2VrsjnsZlF6j8neJoFcec2TPrioJ2
 +wt0guv5W2/AN5vZu6Lu8jkCGNK7gqfOtivy4nlQ=
Date: Wed, 25 May 2022 03:01:52 -0700
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, mdr@ashroe.eu, david.marchand@redhat.com,
 techboard@dpdk.org, David Christensen <drc@linux.vnet.ibm.com>
Subject: Re: [PATCH] eal/ppc: undefine AltiVec keyword vector
Message-ID: <20220525100152.GA12358@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <20220525095307.675312-1-thomas@monjalon.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220525095307.675312-1-thomas@monjalon.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Wed, May 25, 2022 at 11:53:07AM +0200, Thomas Monjalon wrote:
> The AltiVec header file is defining "vector", except in C++ build.
> The keyword "vector" may conflict easily.
> As a rule, it is better to use the alternative keyword "__vector".
> 
> The DPDK header file rte_altivec.h takes care of undefining "vector",
> so the applications and dependencies are free to define the name "vector".
> 
> This is a compatibility breakage for applications which were using
> the keyword "vector" for its AltiVec meaning.
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>