From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5377FA0555; Wed, 25 May 2022 20:35:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E411B40146; Wed, 25 May 2022 20:35:02 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id E394140143; Wed, 25 May 2022 20:35:00 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id 0529820B6C7C; Wed, 25 May 2022 11:35:00 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 0529820B6C7C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1653503700; bh=FN0Ie8jEKiRcf1CcpuWenGlxgUifAgdMaBBocMqTEbM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lAXyRh89nMk5MXd9i220D2SKd/IOyW2t0rx++XpUMhK4qT58lr3aJm+GIrKaXLzVh 7eDGzwqjQg/u2IWxFEUtDEPZHekzWjjfZdKzLoJBy+IsK2C/6TBsMnYskSL6n+c73l yDiXNRXqBJrmt8HXUisNkVWjXwF25K3BkN38WDiM= Date: Wed, 25 May 2022 11:34:59 -0700 From: Tyler Retzlaff To: Ray Kinsella Cc: Thomas Monjalon , dev@dpdk.org, david.marchand@redhat.com, techboard@dpdk.org, David Christensen Subject: Re: [PATCH] eal/ppc: undefine AltiVec keyword vector Message-ID: <20220525183459.GA24690@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20220525095307.675312-1-thomas@monjalon.net> <87ee0hzvd6.fsf@mdr78.vserver.site> <4084096.uADA5c2rLh@thomas> <878rqpze0j.fsf@mdr78.vserver.site> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <878rqpze0j.fsf@mdr78.vserver.site> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, May 25, 2022 at 07:02:52PM +0100, Ray Kinsella wrote: > > Thomas Monjalon writes: > > > 25/05/2022 13:48, Ray Kinsella: > >> > >> Thomas Monjalon writes: > >> > >> > The AltiVec header file is defining "vector", except in C++ build. > >> > The keyword "vector" may conflict easily. > >> > As a rule, it is better to use the alternative keyword "__vector". > >> > > >> > The DPDK header file rte_altivec.h takes care of undefining "vector", > >> > so the applications and dependencies are free to define the name "vector". > >> > > >> > This is a compatibility breakage for applications which were using > >> > the keyword "vector" for its AltiVec meaning. > >> > > >> > Signed-off-by: Thomas Monjalon > >> > --- > >> > doc/guides/rel_notes/release_22_07.rst | 5 +++++ > >> > lib/eal/ppc/include/rte_altivec.h | 7 +++++++ > >> > 2 files changed, 12 insertions(+) > >> > > >> > >> Acked-by: Ray Kinsella > > > > Just to make sure, we are all OK to break compatibility of rte_altivec.h? > > It means the keyword vector is not available anymore with this #include. > > Please confirm it is OK to merge in DPDK 22.07. > > I did think about it yes ;-). > I can't see how it would break the ABI in the short term. > And it makes sense to preclude this keyword in the long term. > > So I ack'ed - did I miss something? Acked-by: Tyler Retzlaff double ack, impact of break is understood as follows. * this is not an issue with abi it is an issue with api. * the break will cause a compile failure, the action to resolve is to replace vector with __vector. > > > -- > Regards, Ray K