From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 63783A0542;
	Mon,  6 Jun 2022 17:49:42 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 0187D4069C;
	Mon,  6 Jun 2022 17:49:42 +0200 (CEST)
Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com
 [209.85.214.180])
 by mails.dpdk.org (Postfix) with ESMTP id 94C7F4021E
 for <dev@dpdk.org>; Mon,  6 Jun 2022 17:49:40 +0200 (CEST)
Received: by mail-pl1-f180.google.com with SMTP id d22so12403208plr.9
 for <dev@dpdk.org>; Mon, 06 Jun 2022 08:49:40 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20210112.gappssmtp.com; s=20210112;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=1N4pD09tlV6joNL3INmK5/8aUcR0nbk7Nr6VOykVsuk=;
 b=SnWsNdO8Pa/wkMcVci8ClBhcwQHrsmxjdIVlTIv//TepWaX6u3ewJRf3URz5dVpGPm
 SEkVT0OaOv/hwG3y86XyR3pdjqgc+HMEJi2tto1S5/Bun02oMRmBoskp4KD5rQlf3XTD
 2wJLPLNrlkhBR4a/2f8pT9ycDKvLTM3VJiPEJm5YkShw/l2GyeOeSQ7z0VJ91ubZEtLQ
 wc68VKGYKmnbw6Do5Fforqn3VvK6ILrppUCYW+TCBYSUMSs/FY34BKm4wIchroWu4Wcl
 tciW04XwdTIhXgtjcO9qK/LogDeRFkbv/0fVwNpBJh0dZOA7YCSPcS4VvLr+s2jKo1Jw
 A8lQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=1N4pD09tlV6joNL3INmK5/8aUcR0nbk7Nr6VOykVsuk=;
 b=6P76HpxnyZXBwCnz9b6KDJInhVj+YojN4VGEB87Nvn0Knf2xaj21kfGEVpXzEllvO0
 xbGpvEfuhD/b2H2bKXkGXRXaEc5JTz6/Mck4h/fjVTSld/11Y9XQ9+qg0TkhSgvo9FpH
 SOWXgXGv8KSAFdArvb7VQY1wpXTc1X5bscYJwj6Y9GsUf/wrV/dx0OYoYUowqk4RMDUV
 bij4v6bBggeYrGi+zj8LtNRGi94j8ltdl/Szs3Igbzd+DZr9RmRsF5yavO6214+4VdyW
 C4vVy9VZ2+i2AQvjSF1OqgNpfQuhA52MH1J7n3GDjT9Q0pnn1MdrBEhVx520M0wxGMuW
 apxg==
X-Gm-Message-State: AOAM533tyan5Gu9ciJznxA1QBFZcZ2QXWsB5LdA6gmspuY6iLvX/Aglb
 VzS2Cgfaex4LwIJhFYRD7tkl9A==
X-Google-Smtp-Source: ABdhPJyjOq82Rb2c24sZ5KM/hpQs71jPQecYkLXpx303eMS1qjH8PlpV+H+ZON1Bw4/4Jz6OS467yA==
X-Received: by 2002:a17:902:7282:b0:164:17f6:e36a with SMTP id
 d2-20020a170902728200b0016417f6e36amr24256131pll.139.1654530579782; 
 Mon, 06 Jun 2022 08:49:39 -0700 (PDT)
Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199])
 by smtp.gmail.com with ESMTPSA id
 72-20020a62144b000000b0051b416c065esm10800820pfu.8.2022.06.06.08.49.38
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 06 Jun 2022 08:49:39 -0700 (PDT)
Date: Mon, 6 Jun 2022 08:49:36 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Spike Du <spiked@nvidia.com>
Cc: <matan@nvidia.com>, <viacheslavo@nvidia.com>, <orika@nvidia.com>,
 <thomas@monjalon.net>, Wenzhuo Lu <wenzhuo.lu@intel.com>, Beilei Xing
 <beilei.xing@intel.com>, Bernard Iremonger <bernard.iremonger@intel.com>,
 "Ray Kinsella" <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>,
 <andrew.rybchenko@oktetlabs.ru>, <mb@smartsharesystems.com>,
 <dev@dpdk.org>, <rasland@nvidia.com>
Subject: Re: [PATCH v4 3/7] ethdev: introduce Rx queue based fill threshold
Message-ID: <20220606084936.47ac8201@hermes.local>
In-Reply-To: <20220603124821.1148119-4-spiked@nvidia.com>
References: <20220524152041.737154-1-spiked@nvidia.com>
 <20220603124821.1148119-1-spiked@nvidia.com>
 <20220603124821.1148119-4-spiked@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Fri, 3 Jun 2022 15:48:17 +0300
Spike Du <spiked@nvidia.com> wrote:

> Fill threshold describes the fullness of a Rx queue. If the Rx
> queue fullness is above the threshold, the device will trigger the event
> RTE_ETH_EVENT_RX_FILL_THRESH.
> Fill threshold is defined as a percentage of Rx queue size with valid
> value of [0,99].
> Setting fill threshold to 0 means disable it, which is the default.
> Add fill threshold configuration and query driver callbacks in eth_dev_ops.
> Add command line options to support fill_thresh per-rxq configure.
> - Command syntax:
>   set port <port_id> rxq <rxq_id> fill_thresh <fill_thresh_num>
> 
> - Example commands:
> To configure fill_thresh as 30% of rxq size on port 1 rxq 0:
> testpmd> set port 1 rxq 0 fill_thresh 30  
> 
> To disable fill_thresh on port 1 rxq 0:
> testpmd> set port 1 rxq 0 fill_thresh 0  
> 
> Signed-off-by: Spike Du <spiked@nvidia.com>

Could the name be shortened to just rte_event_rx_thresh?

The eth_ and _fill_ part are redundant.