DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] event/dlb2: fix QID inflight exploit
@ 2022-06-06 16:03 Timothy McDaniel
  2022-06-09 17:58 ` Jerin Jacob
  0 siblings, 1 reply; 2+ messages in thread
From: Timothy McDaniel @ 2022-06-06 16:03 UTC (permalink / raw)
  To: jerinj; +Cc: dev, stable

If QID inflights is set to an invalid value it can cause the
PMD to hang.  This commit adds checks to make sure that the
value is valid before programming the hardware.

Fixes: 1857f1922ce2 ("event/dlb2: use new implementation of resource file")
Cc: stable@dpdk.org

Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>
---
 drivers/event/dlb2/pf/base/dlb2_resource.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/event/dlb2/pf/base/dlb2_resource.c b/drivers/event/dlb2/pf/base/dlb2_resource.c
index d4c49c2992..548bebd068 100644
--- a/drivers/event/dlb2/pf/base/dlb2_resource.c
+++ b/drivers/event/dlb2/pf/base/dlb2_resource.c
@@ -3701,7 +3701,7 @@ dlb2_verify_create_ldb_queue_args(struct dlb2_hw *hw,
 		}
 	}
 
-	if (args->num_qid_inflights > 4096) {
+	if (args->num_qid_inflights < 1 || args->num_qid_inflights > 2048) {
 		resp->status = DLB2_ST_INVALID_QID_INFLIGHT_ALLOCATION;
 		return -EINVAL;
 	}
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] event/dlb2: fix QID inflight exploit
  2022-06-06 16:03 [PATCH] event/dlb2: fix QID inflight exploit Timothy McDaniel
@ 2022-06-09 17:58 ` Jerin Jacob
  0 siblings, 0 replies; 2+ messages in thread
From: Jerin Jacob @ 2022-06-09 17:58 UTC (permalink / raw)
  To: Timothy McDaniel; +Cc: Jerin Jacob, dpdk-dev, dpdk stable

On Mon, Jun 6, 2022 at 9:33 PM Timothy McDaniel
<timothy.mcdaniel@intel.com> wrote:
>
> If QID inflights is set to an invalid value it can cause the
> PMD to hang.  This commit adds checks to make sure that the
> value is valid before programming the hardware.
>
> Fixes: 1857f1922ce2 ("event/dlb2: use new implementation of resource file")
> Cc: stable@dpdk.org
>
> Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>

Applied to dpdk-next-net-eventdev/for-main. Thanks


> ---
>  drivers/event/dlb2/pf/base/dlb2_resource.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/event/dlb2/pf/base/dlb2_resource.c b/drivers/event/dlb2/pf/base/dlb2_resource.c
> index d4c49c2992..548bebd068 100644
> --- a/drivers/event/dlb2/pf/base/dlb2_resource.c
> +++ b/drivers/event/dlb2/pf/base/dlb2_resource.c
> @@ -3701,7 +3701,7 @@ dlb2_verify_create_ldb_queue_args(struct dlb2_hw *hw,
>                 }
>         }
>
> -       if (args->num_qid_inflights > 4096) {
> +       if (args->num_qid_inflights < 1 || args->num_qid_inflights > 2048) {
>                 resp->status = DLB2_ST_INVALID_QID_INFLIGHT_ALLOCATION;
>                 return -EINVAL;
>         }
> --
> 2.25.1
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-06-09 17:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-06 16:03 [PATCH] event/dlb2: fix QID inflight exploit Timothy McDaniel
2022-06-09 17:58 ` Jerin Jacob

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).