From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 13A92A054D; Tue, 7 Jun 2022 18:42:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 061E54021D; Tue, 7 Jun 2022 18:42:52 +0200 (CEST) Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by mails.dpdk.org (Postfix) with ESMTP id 1403540156 for ; Tue, 7 Jun 2022 18:42:50 +0200 (CEST) Received: by mail-pf1-f176.google.com with SMTP id 15so16012600pfy.3 for ; Tue, 07 Jun 2022 09:42:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MrvflsungfUK4w9gUK3M9cc/2CRTdXoCei/+DCsXmys=; b=6aoHGZNgDOabq9kNppbkUhgNWtypmwibZK4TCfeEKgarvTKc3IWTCAdSSdUimOsSJ+ 3g7lJUKStoRmxTm4zoIw1PQvDgfa4tGgYjoF2ZsRfWpwztqENTuSzGqt1QqRO9DkRKBK oM1ZXYekoBKidDh77fxsZi95CXHm4GK2HVFt6nDhlZKBurLKSRrGKFB1D6YxvPD6l0mu rogL7qLq/E70IkL9PXkfoBPMtjEGaL95vF4Cbuhr1NaO7s7TF6dcY9620mJozqxknTkp 8Z9pMUd92/mWYO7DwfzFC1blfvyv3rW2M1fw0P+B315z8K3RUJ3y8SxJ00MviRpj4Xp4 dcDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MrvflsungfUK4w9gUK3M9cc/2CRTdXoCei/+DCsXmys=; b=hukfH/SsJby4AtjfnMvc26MUproc7x4NSBTSZ89lRHu5G7qfQKoPsvclZtpL9+4Tyr RDPAuC+jfw1v57cAu66WKrNCHz+1Ip5w0VrNnafVOJ0m7pg9pZPCa3mu271nm34jWgnu c2frX85wYDFQolkwCWJm/3hNabwhORhJOdLpnBgiL9p3K6BHBq36GVOhZ1RsuwwTVZjK nSe+JXAuBsOl/CSwVwEyrWWnBw/q/1A1/i4kop+2d+Ncu5LJMBSfCxEaBMyiRZN9ZWSg aVLgG0/F7nNyMxrtEY0TfiBpVuLFe6rDMwzUb+Jg+IASHLMkI6pj6DqBbxB5/42vbdko xG7A== X-Gm-Message-State: AOAM533OIPn1r5M363qHd2WVZz2hpGW7FqDqE3ekbB7anFs1Pe29pOiQ ZDE0geQLbQc42+W8u4c5XcbFRg== X-Google-Smtp-Source: ABdhPJz7xLYnAfp+DT+P6S86HdfLFjAxEhdSwXzufm2MJlC+gX/QMEaQOIdU4FyO4NbhsOLbk8aDYQ== X-Received: by 2002:a63:5b13:0:b0:3c2:163c:b9cb with SMTP id p19-20020a635b13000000b003c2163cb9cbmr26384401pgb.145.1654620170247; Tue, 07 Jun 2022 09:42:50 -0700 (PDT) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id v27-20020aa799db000000b0051bba89c2bcsm11528832pfi.58.2022.06.07.09.42.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jun 2022 09:42:49 -0700 (PDT) Date: Tue, 7 Jun 2022 09:42:47 -0700 From: Stephen Hemminger To: Maxime Coquelin Cc: "Chautru, Nicolas" , "dev@dpdk.org" , "gakhil@marvell.com" , "trix@redhat.com" , "hemant.agrawal@nxp.com" , "Vargas, Hernan" Subject: Re: [PATCH v1] bbdev: add device status info Message-ID: <20220607094247.1f4ee7b8@hermes.local> In-Reply-To: References: <1654555808-218770-1-git-send-email-nicolas.chautru@intel.com> <1654555808-218770-2-git-send-email-nicolas.chautru@intel.com> <20220606170906.6265c598@hermes.local> <9f995dde-738e-6c56-c4ef-41c9ad0f4926@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 7 Jun 2022 18:20:38 +0200 Maxime Coquelin wrote: > Hi Nicolas, > > On 6/7/22 17:44, Chautru, Nicolas wrote: > > Hi Maxime, > > > >> -----Original Message----- > >> From: Maxime Coquelin > >> Sent: Tuesday, June 7, 2022 5:43 AM > >> To: Stephen Hemminger ; Chautru, Nicolas > >> > >> Cc: dev@dpdk.org; gakhil@marvell.com; trix@redhat.com; > >> hemant.agrawal@nxp.com; Vargas, Hernan > >> Subject: Re: [PATCH v1] bbdev: add device status info > >> > >> Hi Stephen, > >> > >> On 6/7/22 02:09, Stephen Hemminger wrote: > >>> On Mon, 6 Jun 2022 15:50:08 -0700 > >>> Nicolas Chautru wrote: > >>> > >>>> @@ -298,6 +313,8 @@ struct rte_bbdev_driver_info { > >>>> const struct rte_bbdev_op_cap *capabilities; > >>>> /** Device cpu_flag requirements */ > >>>> const enum rte_cpu_flag_t *cpu_flag_reqs; > >>>> + /** Device Status */ > >>>> + enum rte_bbdev_device_status device_status; > >>>> }; > >>>> > >>> > >>> This ends up being an ABI breakage, can't change a struct like that > >>> until 22.11 release. > >>> > >> > >> Indeed, but Nicolas mentioned in the cover-letter that the patch targets > >> v22.11; not this release. > >> > >> However, a deprecation notice should be sent for v22.07 if it hasn't been > >> done yet. > > > > I have sent this deprecation Maxime: > > https://patches.dpdk.org/project/dpdk/patch/1647542252-35727-2-git-send-email-nicolas.chautru@intel.com/ > > Do you believe this needs to be extended to cover more details the change and including this device status info explicitly? I can update the verbiage in more details if required > > Thanks for the pointer, I missed it. > Reading the deprecation notice, it is not clear to me it is about the > device status info enum. > > Maybe rewording it a bit to be more specific would help. You might want to use one the existing empty padding slots (holes) in that structure. It appears to have been laid out haphazardly.