From: Ganapati Kundapura <ganapati.kundapura@intel.com>
To: jerinjacobk@gmail.com, dev@dpdk.org, jay.jayatheerthan@intel.com
Cc: s.v.naga.harish.k@intel.com
Subject: [PATCH v5 4/7] eventdev/eth_tx: add instance get API
Date: Wed, 8 Jun 2022 06:16:41 -0500 [thread overview]
Message-ID: <20220608111644.3939628-4-ganapati.kundapura@intel.com> (raw)
In-Reply-To: <20220608111644.3939628-1-ganapati.kundapura@intel.com>
Added rte_event_eth_tx_adapter_instance_get() to get the
adapter instance id for specified ethernet device id and
tx queue index.
Signed-off-by: Ganapati Kundapura <ganapati.kundapura@intel.com>
diff --git a/lib/eventdev/rte_event_eth_rx_adapter.h b/lib/eventdev/rte_event_eth_rx_adapter.h
index f56938d..45140a6 100644
--- a/lib/eventdev/rte_event_eth_rx_adapter.h
+++ b/lib/eventdev/rte_event_eth_rx_adapter.h
@@ -712,10 +712,10 @@ rte_event_eth_rx_adapter_event_port_get(uint8_t id, uint8_t *event_port_id);
* Port identifier of Ethernet device.
*
* @param rx_queue_id
- * Ethernet device receive queue index
+ * Ethernet device receive queue index.
*
* @param[out] rxa_inst_id
- * RX adapter instance identifier.
+ * Pointer to store RX adapter instance identifier.
*
* @return
* - 0: Success
diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c b/lib/eventdev/rte_event_eth_tx_adapter.c
index 1b304f0..d9de6e5 100644
--- a/lib/eventdev/rte_event_eth_tx_adapter.c
+++ b/lib/eventdev/rte_event_eth_tx_adapter.c
@@ -1,6 +1,8 @@
/* SPDX-License-Identifier: BSD-3-Clause
* Copyright(c) 2018 Intel Corporation.
*/
+#include <limits.h>
+
#include <rte_spinlock.h>
#include <rte_service_component.h>
#include <ethdev_driver.h>
@@ -17,6 +19,11 @@
#define TXA_MAX_NB_TX 128
#define TXA_INVALID_DEV_ID INT32_C(-1)
#define TXA_INVALID_SERVICE_ID INT64_C(-1)
+#define INVALID_INSTANCE_ID UINT8_MAX
+
+#define TXA_ADAPTER_ARRAY "txa_adapter_array"
+#define TXA_SERVICE_DATA_ARRAY "txa_service_data_array"
+#define TXA_ADAPTER_INSTANCE_ARRAY "txa_adapter_instance_array"
#define txa_evdev(id) (&rte_eventdevs[txa_dev_id_array[(id)]])
@@ -140,6 +147,10 @@ struct txa_service_ethdev {
void *queues;
};
+struct event_eth_txa_inst_info {
+ uint8_t txa_inst_id;
+};
+
/* Array of adapter instances, initialized with event device id
* when adapter is created
*/
@@ -148,6 +159,9 @@ static int *txa_dev_id_array;
/* Array of pointers to service implementation data */
static struct txa_service_data **txa_service_data_array;
+/* array of adapter instances to store tx queue specific instance */
+static struct event_eth_txa_inst_info **event_eth_txa_inst_info;
+
static int32_t txa_service_func(void *args);
static int txa_service_adapter_create_ext(uint8_t id,
struct rte_eventdev *dev,
@@ -194,12 +208,42 @@ txa_memzone_array_get(const char *name, unsigned int elt_size, int nb_elems)
}
static int
+txa_memzone_lookup(void)
+{
+ const struct rte_memzone *mz;
+
+ if (txa_dev_id_array == NULL) {
+ mz = rte_memzone_lookup(TXA_ADAPTER_ARRAY);
+ if (mz == NULL)
+ return -ENOMEM;
+ txa_dev_id_array = mz->addr;
+ }
+
+ if (txa_service_data_array == NULL) {
+ mz = rte_memzone_lookup(TXA_SERVICE_DATA_ARRAY);
+ if (mz == NULL)
+ return -ENOMEM;
+ txa_service_data_array = mz->addr;
+ }
+
+ if (event_eth_txa_inst_info == NULL) {
+ mz = rte_memzone_lookup(TXA_ADAPTER_INSTANCE_ARRAY);
+ if (mz == NULL)
+ return -ENOMEM;
+ event_eth_txa_inst_info = mz->addr;
+ }
+
+ return 0;
+}
+
+
+static int
txa_dev_id_array_init(void)
{
if (txa_dev_id_array == NULL) {
int i;
- txa_dev_id_array = txa_memzone_array_get("txa_adapter_array",
+ txa_dev_id_array = txa_memzone_array_get(TXA_ADAPTER_ARRAY,
sizeof(int),
RTE_EVENT_ETH_TX_ADAPTER_MAX_INSTANCE);
if (txa_dev_id_array == NULL)
@@ -221,15 +265,30 @@ txa_init(void)
static int
txa_service_data_init(void)
{
+ uint8_t i;
+
if (txa_service_data_array == NULL) {
txa_service_data_array =
- txa_memzone_array_get("txa_service_data_array",
+ txa_memzone_array_get(TXA_SERVICE_DATA_ARRAY,
sizeof(int),
RTE_EVENT_ETH_TX_ADAPTER_MAX_INSTANCE);
if (txa_service_data_array == NULL)
return -ENOMEM;
}
+ if (event_eth_txa_inst_info == NULL) {
+ event_eth_txa_inst_info =
+ txa_memzone_array_get(TXA_ADAPTER_INSTANCE_ARRAY,
+ sizeof(*event_eth_txa_inst_info),
+ RTE_MAX_ETHPORTS);
+ if (event_eth_txa_inst_info == NULL)
+ return -ENOMEM;
+ }
+
+ /* Reset the txa instance pointers */
+ for (i = 0; i < RTE_MAX_ETHPORTS; i++)
+ event_eth_txa_inst_info[i] = NULL;
+
return 0;
}
@@ -763,6 +822,7 @@ txa_service_queue_add(uint8_t id,
struct rte_eth_dev_tx_buffer *tb;
struct txa_retry *txa_retry;
int ret = 0;
+ uint16_t eth_dev_id = eth_dev->data->port_id;
txa = txa_service_id_to_data(id);
@@ -831,6 +891,31 @@ txa_service_queue_add(uint8_t id,
rte_eth_tx_buffer_set_err_callback(tb,
txa_service_buffer_retry, txa_retry);
+ /* Allocate storage to store txa_inst_id for txq */
+ if (event_eth_txa_inst_info[eth_dev_id] == NULL) {
+ uint16_t n, i;
+ struct event_eth_txa_inst_info *i_info;
+
+ n = eth_dev->data->nb_tx_queues;
+
+ i_info = rte_zmalloc_socket("event_eth_txa_inst_info",
+ n * sizeof(event_eth_txa_inst_info),
+ 0,
+ txa->socket_id);
+ if (i_info == NULL) {
+ RTE_EDEV_LOG_ERR("Failed to allocate storage for "
+ "event_eth_txa_inst_info");
+ goto err_unlock;
+ }
+
+ for (i = 0; i < n; i++)
+ i_info[i].txa_inst_id = INVALID_INSTANCE_ID;
+
+ event_eth_txa_inst_info[eth_dev_id] = i_info;
+ }
+
+ event_eth_txa_inst_info[eth_dev_id][tx_queue_id].txa_inst_id = id;
+
tqi->tx_buf = tb;
tqi->added = 1;
tdi->nb_queues++;
@@ -902,6 +987,12 @@ txa_service_queue_del(uint8_t id,
txa->nb_queues--;
txa->txa_ethdev[port_id].nb_queues--;
+ /* unset txa_inst_id for tx_queue_id */
+ if (event_eth_txa_inst_info[port_id])
+ event_eth_txa_inst_info[port_id][tx_queue_id].txa_inst_id =
+ INVALID_INSTANCE_ID;
+
+
txa_service_queue_array_free(txa, port_id);
return 0;
}
@@ -1056,6 +1147,10 @@ int
rte_event_eth_tx_adapter_free(uint8_t id)
{
int ret;
+ uint16_t eth_dev_id;
+
+ if (txa_memzone_lookup())
+ return -ENOMEM;
TXA_CHECK_OR_ERR_RET(id);
@@ -1067,6 +1162,13 @@ rte_event_eth_tx_adapter_free(uint8_t id)
ret = txa_service_adapter_free(id);
txa_dev_id_array[id] = TXA_INVALID_DEV_ID;
+ for (eth_dev_id = 0; eth_dev_id < RTE_MAX_ETHPORTS; eth_dev_id++) {
+ if (event_eth_txa_inst_info[eth_dev_id]) {
+ rte_free(event_eth_txa_inst_info[eth_dev_id]);
+ event_eth_txa_inst_info[eth_dev_id] = NULL;
+ }
+ }
+
rte_eventdev_trace_eth_tx_adapter_free(id, ret);
return ret;
}
@@ -1080,6 +1182,9 @@ rte_event_eth_tx_adapter_queue_add(uint8_t id,
int ret;
uint32_t caps;
+ if (txa_memzone_lookup())
+ return -ENOMEM;
+
RTE_ETH_VALID_PORTID_OR_ERR_RET(eth_dev_id, -EINVAL);
TXA_CHECK_OR_ERR_RET(id);
@@ -1113,6 +1218,9 @@ rte_event_eth_tx_adapter_queue_del(uint8_t id,
int ret;
uint32_t caps;
+ if (txa_memzone_lookup())
+ return -ENOMEM;
+
RTE_ETH_VALID_PORTID_OR_ERR_RET(eth_dev_id, -EINVAL);
TXA_CHECK_OR_ERR_RET(id);
@@ -1218,3 +1326,46 @@ rte_event_eth_tx_adapter_stop(uint8_t id)
rte_eventdev_trace_eth_tx_adapter_stop(id, ret);
return ret;
}
+
+int
+rte_event_eth_tx_adapter_instance_get(uint16_t eth_dev_id,
+ uint16_t tx_queue_id,
+ uint8_t *txa_inst_id)
+{
+ uint8_t inst_id;
+
+ if (txa_memzone_lookup())
+ return -ENOMEM;
+
+ if (eth_dev_id >= rte_eth_dev_count_avail()) {
+ RTE_EDEV_LOG_ERR("Invalid ethernet port id %u", eth_dev_id);
+ return -EINVAL;
+ }
+
+ if (tx_queue_id >= rte_eth_devices[eth_dev_id].data->nb_tx_queues) {
+ RTE_EDEV_LOG_ERR("Invalid tx queue id %u", tx_queue_id);
+ return -EINVAL;
+ }
+
+ if (txa_inst_id == NULL) {
+ RTE_EDEV_LOG_ERR("txa_instance_id cannot be NULL");
+ return -EINVAL;
+ }
+
+ if (event_eth_txa_inst_info[eth_dev_id] == NULL) {
+ RTE_EDEV_LOG_ERR("No valid txa instance for eth_dev_id %d",
+ eth_dev_id);
+ return -EINVAL;
+ }
+
+ inst_id = event_eth_txa_inst_info[eth_dev_id][tx_queue_id].txa_inst_id;
+ if (inst_id == INVALID_INSTANCE_ID) {
+ RTE_EDEV_LOG_ERR("Invalid txa instance for eth_dev_id %u, "
+ "tx_queue_id %u", eth_dev_id, tx_queue_id);
+ return -EINVAL;
+ }
+
+ *txa_inst_id = inst_id;
+
+ return 0;
+}
diff --git a/lib/eventdev/rte_event_eth_tx_adapter.h b/lib/eventdev/rte_event_eth_tx_adapter.h
index 3908c2d..20d28a7 100644
--- a/lib/eventdev/rte_event_eth_tx_adapter.h
+++ b/lib/eventdev/rte_event_eth_tx_adapter.h
@@ -34,6 +34,7 @@
* - rte_event_eth_tx_adapter_enqueue()
* - rte_event_eth_tx_adapter_event_port_get()
* - rte_event_eth_tx_adapter_service_id_get()
+ * - rte_event_eth_tx_adapter_instance_get()
*
* The application creates the adapter using
* rte_event_eth_tx_adapter_create() or rte_event_eth_tx_adapter_create_ext().
@@ -423,6 +424,24 @@ rte_event_eth_tx_adapter_stats_reset(uint8_t id);
int
rte_event_eth_tx_adapter_service_id_get(uint8_t id, uint32_t *service_id);
+/**
+ * Get TX adapter instance id for TX queue
+ *
+ * @param eth_dev_id
+ * Port identifier of Ethernet device.
+ *
+ * @param tx_queue_id
+ * Etherdev device TX queue index.
+ *
+ * @param[out] txa_inst_id
+ * Pointer to store TX adapter instance identifier.
+ */
+__rte_experimental
+int
+rte_event_eth_tx_adapter_instance_get(uint16_t eth_dev_id,
+ uint16_t tx_queue_id,
+ uint8_t *txa_inst_id);
+
#ifdef __cplusplus
}
#endif
diff --git a/lib/eventdev/version.map b/lib/eventdev/version.map
index f1818a2..1c99d52 100644
--- a/lib/eventdev/version.map
+++ b/lib/eventdev/version.map
@@ -106,6 +106,7 @@ EXPERIMENTAL {
rte_event_eth_rx_adapter_queue_conf_get;
rte_event_eth_rx_adapter_queue_stats_get;
rte_event_eth_rx_adapter_queue_stats_reset;
+ rte_event_eth_tx_adapter_instance_get;
# added in 22.03
rte_event_eth_rx_adapter_event_port_get;
--
2.6.4
next prev parent reply other threads:[~2022-06-08 11:17 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-06 17:25 [PATCH v1] eventdev: add adapter " Ganapati Kundapura
2022-06-07 8:07 ` [PATCH v2] " Ganapati Kundapura
2022-06-07 8:21 ` [PATCH v3] " Ganapati Kundapura
2022-06-07 13:18 ` Jayatheerthan, Jay
2022-06-08 11:23 ` Kundapura, Ganapati
2022-06-07 15:13 ` [PATCH v4] " Ganapati Kundapura
2022-06-08 4:26 ` Naga Harish K, S V
2022-06-08 11:22 ` Kundapura, Ganapati
2022-06-08 11:16 ` [PATCH v5 1/7] eventdev/eth_rx: " Ganapati Kundapura
2022-06-08 11:16 ` [PATCH v5 2/7] eventdev/eth_rx: add telemetry callback for instance get Ganapati Kundapura
2022-06-08 11:16 ` [PATCH v5 3/7] test/eth_rx: add test case for instance get API Ganapati Kundapura
2022-06-08 11:16 ` Ganapati Kundapura [this message]
2022-06-08 11:16 ` [PATCH v5 5/7] test/eth_tx: add testcase " Ganapati Kundapura
2022-06-08 11:16 ` [PATCH v5 6/7] doc/eth_rx: update " Ganapati Kundapura
2022-06-08 11:16 ` [PATCH v5 7/7] doc/eth_tx: " Ganapati Kundapura
2022-06-08 12:13 ` [PATCH v6 1/7] eventdev/eth_rx: add adapter " Ganapati Kundapura
2022-06-08 12:13 ` [PATCH v6 2/7] eventdev/eth_rx: add telemetry callback for instance get Ganapati Kundapura
2022-06-08 12:13 ` [PATCH v6 3/7] test/eth_rx: add test case for instance get API Ganapati Kundapura
2022-06-08 12:13 ` [PATCH v6 4/7] eventdev/eth_tx: add " Ganapati Kundapura
2022-06-10 4:14 ` Naga Harish K, S V
2022-06-08 12:13 ` [PATCH v6 5/7] test/eth_tx: add testcase for " Ganapati Kundapura
2022-06-08 12:13 ` [PATCH v6 6/7] doc/eth_rx: update " Ganapati Kundapura
2022-06-08 12:14 ` [PATCH v6 7/7] doc/eth_tx: " Ganapati Kundapura
2022-06-10 4:12 ` [PATCH v6 1/7] eventdev/eth_rx: add adapter " Naga Harish K, S V
2022-06-22 10:37 ` [PATCH v7 " Ganapati Kundapura
2022-06-22 10:37 ` [PATCH v7 2/7] eventdev/eth_rx: add telemetry callback for instance get Ganapati Kundapura
2022-06-22 10:37 ` [PATCH v7 3/7] test/eth_rx: add test case for instance get API Ganapati Kundapura
2022-06-22 10:37 ` [PATCH v7 4/7] eventdev/eth_tx: add " Ganapati Kundapura
2022-06-22 10:37 ` [PATCH v7 5/7] test/eth_tx: add testcase for " Ganapati Kundapura
2022-06-22 10:37 ` [PATCH v7 6/7] doc/eth_rx: update " Ganapati Kundapura
2022-06-22 10:37 ` [PATCH v7 7/7] doc/eth_tx: " Ganapati Kundapura
2022-06-22 16:53 ` [PATCH v8 1/7] eventdev/eth_rx: add adapter " Ganapati Kundapura
2022-06-22 16:54 ` [PATCH v8 2/7] eventdev/eth_rx: add telemetry callback for instance get Ganapati Kundapura
2022-06-22 17:29 ` Naga Harish K, S V
2022-06-22 16:54 ` [PATCH v8 3/7] test/eth_rx: add test case for instance get API Ganapati Kundapura
2022-06-22 17:29 ` Naga Harish K, S V
2022-06-22 16:54 ` [PATCH v8 4/7] eventdev/eth_tx: add " Ganapati Kundapura
2022-06-22 17:30 ` Naga Harish K, S V
2022-06-22 16:54 ` [PATCH v8 5/7] test/eth_tx: add testcase for " Ganapati Kundapura
2022-06-22 17:30 ` Naga Harish K, S V
2022-06-22 16:54 ` [PATCH v8 6/7] doc/eth_rx: update " Ganapati Kundapura
2022-06-22 17:30 ` Naga Harish K, S V
2022-06-22 16:54 ` [PATCH v8 7/7] doc/eth_tx: " Ganapati Kundapura
2022-06-22 17:30 ` Naga Harish K, S V
2022-06-22 17:41 ` Jayatheerthan, Jay
2022-06-22 17:29 ` [PATCH v8 1/7] eventdev/eth_rx: add adapter " Naga Harish K, S V
2022-06-22 17:44 ` Jayatheerthan, Jay
2022-06-23 6:24 ` [PATCH v9 " Ganapati Kundapura
2022-06-23 6:24 ` [PATCH v9 2/7] eventdev/eth_rx: add telemetry callback for instance get Ganapati Kundapura
2022-06-23 6:24 ` [PATCH v9 3/7] test/eth_rx: add test case for instance get API Ganapati Kundapura
2022-06-23 6:24 ` [PATCH v9 4/7] eventdev/eth_tx: add " Ganapati Kundapura
2022-06-23 6:24 ` [PATCH v9 5/7] test/eth_tx: add testcase for " Ganapati Kundapura
2022-06-23 6:24 ` [PATCH v9 6/7] doc/eth_rx: update " Ganapati Kundapura
2022-06-23 6:24 ` [PATCH v9 7/7] doc/eth_tx: " Ganapati Kundapura
2022-06-23 9:30 ` [PATCH v10 1/7] eventdev/eth_rx: add adapter " Ganapati Kundapura
2022-06-23 9:30 ` [PATCH v10 2/7] eventdev/eth_rx: add telemetry callback for instance get Ganapati Kundapura
2022-06-23 9:30 ` [PATCH v10 3/7] test/eth_rx: add test case for instance get API Ganapati Kundapura
2022-06-23 9:30 ` [PATCH v10 4/7] eventdev/eth_tx: add " Ganapati Kundapura
2022-06-23 9:30 ` [PATCH v10 5/7] test/eth_tx: add testcase for " Ganapati Kundapura
2022-06-23 9:30 ` [PATCH v10 6/7] doc/eth_rx: update " Ganapati Kundapura
2022-06-23 9:30 ` [PATCH v10 7/7] doc/eth_tx: " Ganapati Kundapura
2022-07-19 8:25 ` [PATCH v11 1/7] eventdev/eth_rx: add adapter " Ganapati Kundapura
2022-07-19 8:25 ` [PATCH v11 2/7] eventdev/eth_rx: add telemetry callback for instance get Ganapati Kundapura
2022-07-19 8:25 ` [PATCH v11 3/7] test/eth_rx: add test case for instance get API Ganapati Kundapura
2022-07-19 8:25 ` [PATCH v11 4/7] eventdev/eth_tx: add " Ganapati Kundapura
2022-07-19 8:25 ` [PATCH v11 5/7] test/eth_tx: add testcase for " Ganapati Kundapura
2022-07-19 8:25 ` [PATCH v11 6/7] doc/eth_rx: update " Ganapati Kundapura
2022-07-19 8:25 ` [PATCH v11 7/7] doc/eth_tx: " Ganapati Kundapura
2022-08-11 13:28 ` [PATCH v11 1/7] eventdev/eth_rx: add adapter " Kundapura, Ganapati
2022-08-27 12:14 ` Jerin Jacob
2022-08-29 8:20 ` Kundapura, Ganapati
2022-08-29 8:14 ` [PATCH v12 1/6] " Ganapati Kundapura
2022-08-29 8:14 ` [PATCH v12 2/6] eventdev/eth_rx: add telemetry callback for instance get Ganapati Kundapura
2022-08-29 8:14 ` [PATCH v12 3/6] test/eth_rx: add test case for instance get API Ganapati Kundapura
2022-08-29 8:14 ` [PATCH v12 4/6] eventdev/eth_tx: add " Ganapati Kundapura
2022-09-02 13:10 ` Jerin Jacob
2022-08-29 8:14 ` [PATCH v12 5/6] test/eth_tx: add testcase for " Ganapati Kundapura
2022-08-29 8:14 ` [PATCH v12 6/6] doc: Added adapter " Ganapati Kundapura
2022-08-29 8:14 ` [PATCH v12 6/6] doc: added " Ganapati Kundapura
2022-09-02 13:11 ` Jerin Jacob
2022-09-02 13:09 ` [PATCH v12 1/6] eventdev/eth_rx: add " Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220608111644.3939628-4-ganapati.kundapura@intel.com \
--to=ganapati.kundapura@intel.com \
--cc=dev@dpdk.org \
--cc=jay.jayatheerthan@intel.com \
--cc=jerinjacobk@gmail.com \
--cc=s.v.naga.harish.k@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).