From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D2EE7A0553; Sat, 11 Jun 2022 17:37:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C542B410E5; Sat, 11 Jun 2022 17:37:29 +0200 (CEST) Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by mails.dpdk.org (Postfix) with ESMTP id 0CC594069C for ; Sat, 11 Jun 2022 17:37:28 +0200 (CEST) Received: by mail-pg1-f169.google.com with SMTP id d129so1791330pgc.9 for ; Sat, 11 Jun 2022 08:37:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=w0HOMnMG+LeAa7BvxA0hLFqrdDI5XL7V21lYO9Z0x0w=; b=YYtAYGad/DUiXzdsb7peUaiJLKSbqWUDM1t3VxLfYFTaS84hPeVuyrpxvjZ8P8z8BU xhEc89fG4CJpCA6Zuf94PVBmkV8dNzI6D9uuxPFAPy9W9hr/B7/QKl7u9JmcHbUMqkMR ZwTPR8WUuzmzUaNDlq+Rr6qhCTXkgdYh2Kxvl3lXi6ZaAusZcF0Oy9eJvwglC1SBfGON aRxLVUC1PPM66Gp0LaJeQrigbCXWIYMzTHTzQLkonJnnnzbuv3hZkNeABKrfteh9R27I 70fbp5+Bmyol4qiawHJxcAUnGwysyepfXXwKjxb4fQ1Smw7c3dQLmFeP3hDeFJKDgMnT d6Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=w0HOMnMG+LeAa7BvxA0hLFqrdDI5XL7V21lYO9Z0x0w=; b=rAHb19yuFj3aGC3uMBaFuC31oAsyxjKdggB53esdr3DT4EwJ9tyF/9s0YE8F4hzSFc g8dSwpjPI80ClLrTORN7RwM679RvfyppaIWmVrN53Xi4PejmTY/zMRLUpHj9Etp9boUC e30XlcLR8Zy2aqBUkpPZc+zqFwtVVTupudDfdu66bD7ogR6O0G9L81XXwWFUGUqpGHpV bujuLb+6UpqhaoaR8E8S8nXHJ8/+/1OU386klHLL/EYzTnn9VNmcpnMJdSvoYT+XaWX6 +vVGTTm0oLCcZ6jw+nUYFMdhdvOwtZAn5tUK6VsRIcdphPH5rw5QlULyGKLqDRkYNDqw HsKA== X-Gm-Message-State: AOAM530v1/grzEXFOi2sahERBsDzsyDGfNPak+fcIFJqnNV0Lnd09s0U Isetsa7oI73SH/zwVBudj/2G4Q== X-Google-Smtp-Source: ABdhPJyZWjxf03UalEkC3m16xpu/ZAxAomWun4SP9X6QQ5yPS1ehvFUBKB9Q31il8jtx3UE1cQxmJg== X-Received: by 2002:a63:28f:0:b0:401:b849:cbd8 with SMTP id 137-20020a63028f000000b00401b849cbd8mr8963903pgc.132.1654961847304; Sat, 11 Jun 2022 08:37:27 -0700 (PDT) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id bl2-20020a17090b098200b001e30a16c609sm1619441pjb.21.2022.06.11.08.37.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Jun 2022 08:37:26 -0700 (PDT) Date: Sat, 11 Jun 2022 08:37:24 -0700 From: Stephen Hemminger To: David Marchand Cc: dev@dpdk.org, thomas@monjalon.net, ferruh.yigit@xilinx.com, stable@dpdk.org, Wisam Jaddo Subject: Re: [PATCH 11/12] app/flow-perf: fix build with GCC 12 Message-ID: <20220611083724.2c72e179@hermes.local> In-Reply-To: <20220518101657.1230416-12-david.marchand@redhat.com> References: <20220518101657.1230416-1-david.marchand@redhat.com> <20220518101657.1230416-12-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 18 May 2022 12:16:56 +0200 David Marchand wrote: > GCC 12 raises the following warning: >=20 > ../app/test-flow-perf/main.c: In function =E2=80=98start_forwarding=E2=80= =99: > ../app/test-flow-perf/main.c:1737:28: error: =E2=80=98sprintf=E2=80=99 ma= y write a > terminating nul past the end of the destination > [-Werror=3Dformat-overflow=3D] > 1737 | sprintf(p[i++], "%d", (int)n); > | ^ > In function =E2=80=98pretty_number=E2=80=99, > inlined from =E2=80=98packet_per_second_stats=E2=80=99 at > ../app/test-flow-perf/main.c:1792:4, > inlined from =E2=80=98start_forwarding=E2=80=99 at > ../app/test-flow-perf/main.c:1831:3: > [...] >=20 > We can simplify this code and rely on libc integer formatting via > this system locales. >=20 > Cc: stable@dpdk.org >=20 > Signed-off-by: David Marchand Fixes and ends up cleaner. Acked-by: Stephen Hemminger