From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D1C3EA0543; Mon, 13 Jun 2022 20:19:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B7F1440223; Mon, 13 Jun 2022 20:19:35 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 9C42340222; Mon, 13 Jun 2022 20:19:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655144374; x=1686680374; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=eH/XpExLEWu9gky7iCTdx1THUcRt058iz4BflZxLip4=; b=WOL3eAvtOIvpymeV3qUokOLAy/eeIWNg26dYAjdg8/TklruftwjcANee QD8QDKIVqVTOA8H6tBrZDvCJEcGWVSqK/PCqQIrGrHGaplRMskBp4vng9 EkqyB9pzLKunv10gQdDYmG7QavG1fWpR3ArjvBAI0IPMccuPt0L5DHhZy Hj7a1kYIbTC6uA01N6jzg7EyumkMy6nwPKk962Wis6iWrpLW9KCNvR0no DpK97nPL7mt0Y1Gs7f4qa2wOWO0xQdfBys82fynD5KlZC17nA2RBKxGvA bgidZrnVdCaST64V88sIr09KasKjECj9qBZLLXLIzpmECmN03P8sm543N w==; X-IronPort-AV: E=McAfee;i="6400,9594,10377"; a="279417836" X-IronPort-AV: E=Sophos;i="5.91,297,1647327600"; d="scan'208";a="279417836" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jun 2022 11:19:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,297,1647327600"; d="scan'208";a="673433874" Received: from txanpdk03.an.intel.com ([10.123.117.78]) by FMSMGA003.fm.intel.com with ESMTP; 13 Jun 2022 11:19:24 -0700 From: Timothy McDaniel To: jerinj@marvell.com Cc: dev@dpdk.org, stable@dpdk.org Subject: [PATCH v3] event/dlb2: fix advertized capabilities Date: Mon, 13 Jun 2022 13:19:14 -0500 Message-Id: <20220613181914.3212778-1-timothy.mcdaniel@intel.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20220606154044.1225683-1-timothy.mcdaniel@intel.com> References: <20220606154044.1225683-1-timothy.mcdaniel@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This commit corrects the advertized capabilities reported by the DLB2 PMD. Previously DLB2 reported supporting RTE_EVENT_DEV_CAP_QUEUE_QOS, but the DLB2 hardware does not support such capability. This commit removes that feature from the reported capabilities feature set. Additionally, two capabilities that DLB2 does support were not being reported in the capabilities feature set. This commit adds those. RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT = Event device is capable of setting up the link between multiple queues and a single port. If the flag is not set, the eventdev can only map a single queue to each port or map a single queue to many port RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK = Event device is capable of configuring the queue/port link at runtime. If the flag is not set, the eventdev queue/port link is only can be configured during initialization Finally, the file doc/guides/eventdevs/features/dlb2.ini has been updated to match the capabilities actually reported by the PMD. Fixes: e7c9971a857a ("event/dlb2: add probe-time hardware init") Cc: stable@dpdk.org Signed-off-by: Timothy McDaniel === Changes since V2: Added "fixes" line that was present in original, but missing in V2. Changes since V1; 1) reorder capabilities flags to match the order that they appear in in the default.ini file 2) update the dlb2.ini file with the new set of features supported by DLB2 3) expanded the commit message to provide additional details --- doc/guides/eventdevs/features/dlb2.ini | 3 ++- drivers/event/dlb2/dlb2.c | 9 +++++---- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/doc/guides/eventdevs/features/dlb2.ini b/doc/guides/eventdevs/features/dlb2.ini index 29747b1c26..48a2a18aff 100644 --- a/doc/guides/eventdevs/features/dlb2.ini +++ b/doc/guides/eventdevs/features/dlb2.ini @@ -4,12 +4,13 @@ ; Refer to default.ini for the full list of available PMD features. ; [Scheduling Features] -queue_qos = Y event_qos = Y distributed_sched = Y queue_all_types = Y burst_mode = Y implicit_release_disable = Y +runtime_port_link = Y +multiple_queue_port = Y maintenance_free = Y [Eth Rx adapter Features] diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c index 3641ed2942..bc4e705e0b 100644 --- a/drivers/event/dlb2/dlb2.c +++ b/drivers/event/dlb2/dlb2.c @@ -61,12 +61,13 @@ static struct rte_event_dev_info evdev_dlb2_default_info = { .max_num_events = DLB2_MAX_NUM_LDB_CREDITS, .max_single_link_event_port_queue_pairs = DLB2_MAX_NUM_DIR_PORTS(DLB2_HW_V2), - .event_dev_cap = (RTE_EVENT_DEV_CAP_QUEUE_QOS | - RTE_EVENT_DEV_CAP_EVENT_QOS | - RTE_EVENT_DEV_CAP_BURST_MODE | + .event_dev_cap = (RTE_EVENT_DEV_CAP_EVENT_QOS | RTE_EVENT_DEV_CAP_DISTRIBUTED_SCHED | - RTE_EVENT_DEV_CAP_IMPLICIT_RELEASE_DISABLE | RTE_EVENT_DEV_CAP_QUEUE_ALL_TYPES | + RTE_EVENT_DEV_CAP_BURST_MODE | + RTE_EVENT_DEV_CAP_IMPLICIT_RELEASE_DISABLE | + RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK | + RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT | RTE_EVENT_DEV_CAP_MAINTENANCE_FREE), }; -- 2.25.1