* Re: [PATCH] event/dlb2: fix advertized capabilities
2022-06-06 15:40 [PATCH] event/dlb2: fix advertized capabilities Timothy McDaniel
@ 2022-06-09 17:05 ` Jerin Jacob
2022-06-09 18:02 ` McDaniel, Timothy
2022-06-10 18:36 ` [PATCH v2] " Timothy McDaniel
2022-06-13 18:19 ` [PATCH v3] " Timothy McDaniel
2 siblings, 1 reply; 7+ messages in thread
From: Jerin Jacob @ 2022-06-09 17:05 UTC (permalink / raw)
To: Timothy McDaniel; +Cc: Jerin Jacob, dpdk-dev, dpdk stable
On Mon, Jun 6, 2022 at 9:31 PM Timothy McDaniel
<timothy.mcdaniel@intel.com> wrote:
>
Be more descriptive,
> 1) Remove RTE_EVENT_DEV_CAP_QUEUE_QOS. DLB/DLB2 do not support
> queue priority
> 2) Add RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT
> 3) Add RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK
file doc/guides/eventdevs/features/dlb2.ini is not updated. It is out of sync.
>
> Fixes: e7c9971a857a ("event/dlb2: add probe-time hardware init")
> Cc: stable@dpdk.org
>
> Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>
> ---
> drivers/event/dlb2/dlb2.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c
> index 36f07d0061..5c30d5ce35 100644
> --- a/drivers/event/dlb2/dlb2.c
> +++ b/drivers/event/dlb2/dlb2.c
> @@ -61,11 +61,12 @@ static struct rte_event_dev_info evdev_dlb2_default_info = {
> .max_num_events = DLB2_MAX_NUM_LDB_CREDITS,
> .max_single_link_event_port_queue_pairs =
> DLB2_MAX_NUM_DIR_PORTS(DLB2_HW_V2),
> - .event_dev_cap = (RTE_EVENT_DEV_CAP_QUEUE_QOS |
> - RTE_EVENT_DEV_CAP_EVENT_QOS |
> + .event_dev_cap = (RTE_EVENT_DEV_CAP_EVENT_QOS |
> RTE_EVENT_DEV_CAP_BURST_MODE |
> RTE_EVENT_DEV_CAP_DISTRIBUTED_SCHED |
> RTE_EVENT_DEV_CAP_IMPLICIT_RELEASE_DISABLE |
> + RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT |
> + RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK |
> RTE_EVENT_DEV_CAP_QUEUE_ALL_TYPES |
> RTE_EVENT_DEV_CAP_MAINTENANCE_FREE),
> };
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread* RE: [PATCH] event/dlb2: fix advertized capabilities
2022-06-09 17:05 ` Jerin Jacob
@ 2022-06-09 18:02 ` McDaniel, Timothy
0 siblings, 0 replies; 7+ messages in thread
From: McDaniel, Timothy @ 2022-06-09 18:02 UTC (permalink / raw)
To: Jerin Jacob; +Cc: Jerin Jacob, dpdk-dev, dpdk stable
I will update both the description and doc/guides/eventdevs/features/dlb2.ini
Thanks,
Tim
> -----Original Message-----
> From: Jerin Jacob <jerinjacobk@gmail.com>
> Sent: Thursday, June 9, 2022 12:06 PM
> To: McDaniel, Timothy <timothy.mcdaniel@intel.com>
> Cc: Jerin Jacob <jerinj@marvell.com>; dpdk-dev <dev@dpdk.org>; dpdk stable
> <stable@dpdk.org>
> Subject: Re: [PATCH] event/dlb2: fix advertized capabilities
>
> On Mon, Jun 6, 2022 at 9:31 PM Timothy McDaniel
> <timothy.mcdaniel@intel.com> wrote:
> >
>
> Be more descriptive,
>
> > 1) Remove RTE_EVENT_DEV_CAP_QUEUE_QOS. DLB/DLB2 do not support
> > queue priority
> > 2) Add RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT
> > 3) Add RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK
>
> file doc/guides/eventdevs/features/dlb2.ini is not updated. It is out of sync.
>
> >
> > Fixes: e7c9971a857a ("event/dlb2: add probe-time hardware init")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>
> > ---
> > drivers/event/dlb2/dlb2.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c
> > index 36f07d0061..5c30d5ce35 100644
> > --- a/drivers/event/dlb2/dlb2.c
> > +++ b/drivers/event/dlb2/dlb2.c
> > @@ -61,11 +61,12 @@ static struct rte_event_dev_info
> evdev_dlb2_default_info = {
> > .max_num_events = DLB2_MAX_NUM_LDB_CREDITS,
> > .max_single_link_event_port_queue_pairs =
> > DLB2_MAX_NUM_DIR_PORTS(DLB2_HW_V2),
> > - .event_dev_cap = (RTE_EVENT_DEV_CAP_QUEUE_QOS |
> > - RTE_EVENT_DEV_CAP_EVENT_QOS |
> > + .event_dev_cap = (RTE_EVENT_DEV_CAP_EVENT_QOS |
> > RTE_EVENT_DEV_CAP_BURST_MODE |
> > RTE_EVENT_DEV_CAP_DISTRIBUTED_SCHED |
> > RTE_EVENT_DEV_CAP_IMPLICIT_RELEASE_DISABLE |
> > + RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT |
> > + RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK |
> > RTE_EVENT_DEV_CAP_QUEUE_ALL_TYPES |
> > RTE_EVENT_DEV_CAP_MAINTENANCE_FREE),
> > };
> > --
> > 2.25.1
> >
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2] event/dlb2: fix advertized capabilities
2022-06-06 15:40 [PATCH] event/dlb2: fix advertized capabilities Timothy McDaniel
2022-06-09 17:05 ` Jerin Jacob
@ 2022-06-10 18:36 ` Timothy McDaniel
2022-06-13 6:21 ` Jerin Jacob
2022-06-13 18:19 ` [PATCH v3] " Timothy McDaniel
2 siblings, 1 reply; 7+ messages in thread
From: Timothy McDaniel @ 2022-06-10 18:36 UTC (permalink / raw)
To: jerinj; +Cc: dev
This commit corrects the advertized capabilities reported by the DLB2 PMD.
Previously DLB2 reported supporting RTE_EVENT_DEV_CAP_QUEUE_QOS, but the
DLB2 hardware does not support such capability. This commit removes that
feature from the reported capabilities feature set.
Additionally, two capabilities that DLB2 does support were not being
reported in the capabilities feature set. This commit adds those.
RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT = Event device is capable of
setting up the link between multiple queues and a single port. If the
flag is not set, the eventdev can only map a single queue to each
port or map a single queue to many port
RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK = Event device is capable of
configuring the queue/port link at runtime. If the flag is not set,
the eventdev queue/port link is only can be configured during
initialization
Finally, the file doc/guides/eventdevs/features/dlb2.ini has been updated
to match the capabilities actually reported by the PMD.
Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>
===
Changes since V1;
1) reorder capabilities flags to match the order that they appear in
in the default.ini file
2) update the dlb2.ini file with the new set of features supported by DLB2
3) expanded the commit message to provide additional details
---
doc/guides/eventdevs/features/dlb2.ini | 3 ++-
drivers/event/dlb2/dlb2.c | 9 +++++----
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/doc/guides/eventdevs/features/dlb2.ini b/doc/guides/eventdevs/features/dlb2.ini
index 29747b1c26..48a2a18aff 100644
--- a/doc/guides/eventdevs/features/dlb2.ini
+++ b/doc/guides/eventdevs/features/dlb2.ini
@@ -4,12 +4,13 @@
; Refer to default.ini for the full list of available PMD features.
;
[Scheduling Features]
-queue_qos = Y
event_qos = Y
distributed_sched = Y
queue_all_types = Y
burst_mode = Y
implicit_release_disable = Y
+runtime_port_link = Y
+multiple_queue_port = Y
maintenance_free = Y
[Eth Rx adapter Features]
diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c
index 3641ed2942..bc4e705e0b 100644
--- a/drivers/event/dlb2/dlb2.c
+++ b/drivers/event/dlb2/dlb2.c
@@ -61,12 +61,13 @@ static struct rte_event_dev_info evdev_dlb2_default_info = {
.max_num_events = DLB2_MAX_NUM_LDB_CREDITS,
.max_single_link_event_port_queue_pairs =
DLB2_MAX_NUM_DIR_PORTS(DLB2_HW_V2),
- .event_dev_cap = (RTE_EVENT_DEV_CAP_QUEUE_QOS |
- RTE_EVENT_DEV_CAP_EVENT_QOS |
- RTE_EVENT_DEV_CAP_BURST_MODE |
+ .event_dev_cap = (RTE_EVENT_DEV_CAP_EVENT_QOS |
RTE_EVENT_DEV_CAP_DISTRIBUTED_SCHED |
- RTE_EVENT_DEV_CAP_IMPLICIT_RELEASE_DISABLE |
RTE_EVENT_DEV_CAP_QUEUE_ALL_TYPES |
+ RTE_EVENT_DEV_CAP_BURST_MODE |
+ RTE_EVENT_DEV_CAP_IMPLICIT_RELEASE_DISABLE |
+ RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK |
+ RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT |
RTE_EVENT_DEV_CAP_MAINTENANCE_FREE),
};
--
2.25.1
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v2] event/dlb2: fix advertized capabilities
2022-06-10 18:36 ` [PATCH v2] " Timothy McDaniel
@ 2022-06-13 6:21 ` Jerin Jacob
0 siblings, 0 replies; 7+ messages in thread
From: Jerin Jacob @ 2022-06-13 6:21 UTC (permalink / raw)
To: Timothy McDaniel; +Cc: Jerin Jacob, dpdk-dev
On Sat, Jun 11, 2022 at 12:06 AM Timothy McDaniel
<timothy.mcdaniel@intel.com> wrote:
>
> This commit corrects the advertized capabilities reported by the DLB2 PMD.
>
> Previously DLB2 reported supporting RTE_EVENT_DEV_CAP_QUEUE_QOS, but the
> DLB2 hardware does not support such capability. This commit removes that
> feature from the reported capabilities feature set.
>
> Additionally, two capabilities that DLB2 does support were not being
> reported in the capabilities feature set. This commit adds those.
>
> RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT = Event device is capable of
> setting up the link between multiple queues and a single port. If the
> flag is not set, the eventdev can only map a single queue to each
> port or map a single queue to many port
>
> RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK = Event device is capable of
> configuring the queue/port link at runtime. If the flag is not set,
> the eventdev queue/port link is only can be configured during
> initialization
>
> Finally, the file doc/guides/eventdevs/features/dlb2.ini has been updated
> to match the capabilities actually reported by the PMD.
>
> Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>
Please fix
[for-main]dell[dpdk-next-eventdev] $ ./devtools/check-git-log.sh -n 1
Missing 'Fixes' tag:
event/dlb2: fix advertized capabilities
Invalid patch(es) found - checked 1 patch
> ===
>
> Changes since V1;
> 1) reorder capabilities flags to match the order that they appear in
> in the default.ini file
> 2) update the dlb2.ini file with the new set of features supported by DLB2
> 3) expanded the commit message to provide additional details
> ---
> doc/guides/eventdevs/features/dlb2.ini | 3 ++-
> drivers/event/dlb2/dlb2.c | 9 +++++----
> 2 files changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/doc/guides/eventdevs/features/dlb2.ini b/doc/guides/eventdevs/features/dlb2.ini
> index 29747b1c26..48a2a18aff 100644
> --- a/doc/guides/eventdevs/features/dlb2.ini
> +++ b/doc/guides/eventdevs/features/dlb2.ini
> @@ -4,12 +4,13 @@
> ; Refer to default.ini for the full list of available PMD features.
> ;
> [Scheduling Features]
> -queue_qos = Y
> event_qos = Y
> distributed_sched = Y
> queue_all_types = Y
> burst_mode = Y
> implicit_release_disable = Y
> +runtime_port_link = Y
> +multiple_queue_port = Y
> maintenance_free = Y
>
> [Eth Rx adapter Features]
> diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c
> index 3641ed2942..bc4e705e0b 100644
> --- a/drivers/event/dlb2/dlb2.c
> +++ b/drivers/event/dlb2/dlb2.c
> @@ -61,12 +61,13 @@ static struct rte_event_dev_info evdev_dlb2_default_info = {
> .max_num_events = DLB2_MAX_NUM_LDB_CREDITS,
> .max_single_link_event_port_queue_pairs =
> DLB2_MAX_NUM_DIR_PORTS(DLB2_HW_V2),
> - .event_dev_cap = (RTE_EVENT_DEV_CAP_QUEUE_QOS |
> - RTE_EVENT_DEV_CAP_EVENT_QOS |
> - RTE_EVENT_DEV_CAP_BURST_MODE |
> + .event_dev_cap = (RTE_EVENT_DEV_CAP_EVENT_QOS |
> RTE_EVENT_DEV_CAP_DISTRIBUTED_SCHED |
> - RTE_EVENT_DEV_CAP_IMPLICIT_RELEASE_DISABLE |
> RTE_EVENT_DEV_CAP_QUEUE_ALL_TYPES |
> + RTE_EVENT_DEV_CAP_BURST_MODE |
> + RTE_EVENT_DEV_CAP_IMPLICIT_RELEASE_DISABLE |
> + RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK |
> + RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT |
> RTE_EVENT_DEV_CAP_MAINTENANCE_FREE),
> };
>
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v3] event/dlb2: fix advertized capabilities
2022-06-06 15:40 [PATCH] event/dlb2: fix advertized capabilities Timothy McDaniel
2022-06-09 17:05 ` Jerin Jacob
2022-06-10 18:36 ` [PATCH v2] " Timothy McDaniel
@ 2022-06-13 18:19 ` Timothy McDaniel
2022-06-14 9:26 ` Jerin Jacob
2 siblings, 1 reply; 7+ messages in thread
From: Timothy McDaniel @ 2022-06-13 18:19 UTC (permalink / raw)
To: jerinj; +Cc: dev, stable
This commit corrects the advertized capabilities reported by the DLB2 PMD.
Previously DLB2 reported supporting RTE_EVENT_DEV_CAP_QUEUE_QOS, but the
DLB2 hardware does not support such capability. This commit removes that
feature from the reported capabilities feature set.
Additionally, two capabilities that DLB2 does support were not being
reported in the capabilities feature set. This commit adds those.
RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT = Event device is capable of
setting up the link between multiple queues and a single port. If the
flag is not set, the eventdev can only map a single queue to each
port or map a single queue to many port
RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK = Event device is capable of
configuring the queue/port link at runtime. If the flag is not set,
the eventdev queue/port link is only can be configured during
initialization
Finally, the file doc/guides/eventdevs/features/dlb2.ini has been updated
to match the capabilities actually reported by the PMD.
Fixes: e7c9971a857a ("event/dlb2: add probe-time hardware init")
Cc: stable@dpdk.org
Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>
===
Changes since V2:
Added "fixes" line that was present in original, but missing in V2.
Changes since V1;
1) reorder capabilities flags to match the order that they appear in
in the default.ini file
2) update the dlb2.ini file with the new set of features supported by DLB2
3) expanded the commit message to provide additional details
---
doc/guides/eventdevs/features/dlb2.ini | 3 ++-
drivers/event/dlb2/dlb2.c | 9 +++++----
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/doc/guides/eventdevs/features/dlb2.ini b/doc/guides/eventdevs/features/dlb2.ini
index 29747b1c26..48a2a18aff 100644
--- a/doc/guides/eventdevs/features/dlb2.ini
+++ b/doc/guides/eventdevs/features/dlb2.ini
@@ -4,12 +4,13 @@
; Refer to default.ini for the full list of available PMD features.
;
[Scheduling Features]
-queue_qos = Y
event_qos = Y
distributed_sched = Y
queue_all_types = Y
burst_mode = Y
implicit_release_disable = Y
+runtime_port_link = Y
+multiple_queue_port = Y
maintenance_free = Y
[Eth Rx adapter Features]
diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c
index 3641ed2942..bc4e705e0b 100644
--- a/drivers/event/dlb2/dlb2.c
+++ b/drivers/event/dlb2/dlb2.c
@@ -61,12 +61,13 @@ static struct rte_event_dev_info evdev_dlb2_default_info = {
.max_num_events = DLB2_MAX_NUM_LDB_CREDITS,
.max_single_link_event_port_queue_pairs =
DLB2_MAX_NUM_DIR_PORTS(DLB2_HW_V2),
- .event_dev_cap = (RTE_EVENT_DEV_CAP_QUEUE_QOS |
- RTE_EVENT_DEV_CAP_EVENT_QOS |
- RTE_EVENT_DEV_CAP_BURST_MODE |
+ .event_dev_cap = (RTE_EVENT_DEV_CAP_EVENT_QOS |
RTE_EVENT_DEV_CAP_DISTRIBUTED_SCHED |
- RTE_EVENT_DEV_CAP_IMPLICIT_RELEASE_DISABLE |
RTE_EVENT_DEV_CAP_QUEUE_ALL_TYPES |
+ RTE_EVENT_DEV_CAP_BURST_MODE |
+ RTE_EVENT_DEV_CAP_IMPLICIT_RELEASE_DISABLE |
+ RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK |
+ RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT |
RTE_EVENT_DEV_CAP_MAINTENANCE_FREE),
};
--
2.25.1
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v3] event/dlb2: fix advertized capabilities
2022-06-13 18:19 ` [PATCH v3] " Timothy McDaniel
@ 2022-06-14 9:26 ` Jerin Jacob
0 siblings, 0 replies; 7+ messages in thread
From: Jerin Jacob @ 2022-06-14 9:26 UTC (permalink / raw)
To: Timothy McDaniel; +Cc: Jerin Jacob, dpdk-dev, dpdk stable
On Mon, Jun 13, 2022 at 11:49 PM Timothy McDaniel
<timothy.mcdaniel@intel.com> wrote:
>
> This commit corrects the advertized capabilities reported by the DLB2 PMD.
>
> Previously DLB2 reported supporting RTE_EVENT_DEV_CAP_QUEUE_QOS, but the
> DLB2 hardware does not support such capability. This commit removes that
> feature from the reported capabilities feature set.
>
> Additionally, two capabilities that DLB2 does support were not being
> reported in the capabilities feature set. This commit adds those.
>
> RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT = Event device is capable of
> setting up the link between multiple queues and a single port. If the
> flag is not set, the eventdev can only map a single queue to each
> port or map a single queue to many port
>
> RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK = Event device is capable of
> configuring the queue/port link at runtime. If the flag is not set,
> the eventdev queue/port link is only can be configured during
> initialization
>
> Finally, the file doc/guides/eventdevs/features/dlb2.ini has been updated
> to match the capabilities actually reported by the PMD.
>
> Fixes: e7c9971a857a ("event/dlb2: add probe-time hardware init")
> Cc: stable@dpdk.org
>
> Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>
>
For here to [2] content, needs to be moved to [1] to avoid polluting
the commit message.
Fixed and Applied to dpdk-next-net-eventdev/for-main. Thanks
> ===
>
> Changes since V2:
> Added "fixes" line that was present in original, but missing in V2.
>
> Changes since V1;
> 1) reorder capabilities flags to match the order that they appear in
> in the default.ini file
> 2) update the dlb2.ini file with the new set of features supported by DLB2
> 3) expanded the commit message to provide additional details
[2]
> ---
[1]
> doc/guides/eventdevs/features/dlb2.ini | 3 ++-
^ permalink raw reply [flat|nested] 7+ messages in thread