DPDK patches and discussions
 help / color / mirror / Atom feed
From: Chengwen Feng <fengchengwen@huawei.com>
To: <thomas@monjalon.net>, <dev@dpdk.org>
Cc: <anatoly.burakov@intel.com>, <jerinj@marvell.com>,
	<bruce.richardson@intel.com>, <david.marchand@redhat.com>
Subject: [PATCH v2 1/3] eal: fix segment fault when exit trace
Date: Tue, 14 Jun 2022 13:58:58 +0800	[thread overview]
Message-ID: <20220614055900.22848-2-fengchengwen@huawei.com> (raw)
In-Reply-To: <20220614055900.22848-1-fengchengwen@huawei.com>

Bug scenario:
1. start testpmd:
	dpdk-testpmd -l 4-6 -a 0000:7d:00.0 --trace=.* -- -i
2. quit testpmd and then observed segment fault:
	Bye...
	Segmentation fault (core dumped)

The root cause is that rte_trace_save() and eal_trace_fini() access
the huge pages which were cleanup by rte_eal_memory_detach().

This patch moves rte_trace_save() and eal_trace_fini() before
rte_eal_memory_detach() to fix the bug.

Fixes: dfbc61a2f9a6 ("mem: detach memsegs on cleanup")
Cc: stable@dpdk.org

Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
Tested-by: Jerin Jacob <jerinj@marvell.com>
---
 lib/eal/freebsd/eal.c | 4 ++--
 lib/eal/linux/eal.c   | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c
index a6b20960f2..26fbc91b26 100644
--- a/lib/eal/freebsd/eal.c
+++ b/lib/eal/freebsd/eal.c
@@ -893,11 +893,11 @@ rte_eal_cleanup(void)
 		eal_get_internal_configuration();
 	rte_service_finalize();
 	rte_mp_channel_cleanup();
+	rte_trace_save();
+	eal_trace_fini();
 	/* after this point, any DPDK pointers will become dangling */
 	rte_eal_memory_detach();
 	rte_eal_alarm_cleanup();
-	rte_trace_save();
-	eal_trace_fini();
 	eal_cleanup_config(internal_conf);
 	return 0;
 }
diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c
index 1ef263434a..c6f2056197 100644
--- a/lib/eal/linux/eal.c
+++ b/lib/eal/linux/eal.c
@@ -1266,13 +1266,13 @@ rte_eal_cleanup(void)
 	vfio_mp_sync_cleanup();
 #endif
 	rte_mp_channel_cleanup();
+	rte_trace_save();
+	eal_trace_fini();
 	/* after this point, any DPDK pointers will become dangling */
 	rte_eal_memory_detach();
 	eal_mp_dev_hotplug_cleanup();
 	rte_eal_malloc_heap_cleanup();
 	rte_eal_alarm_cleanup();
-	rte_trace_save();
-	eal_trace_fini();
 	eal_cleanup_config(internal_conf);
 	rte_eal_log_cleanup();
 	return 0;
-- 
2.33.0


  reply	other threads:[~2022-06-14  6:06 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-07 12:00 [PATCH] " Chengwen Feng
2022-06-07 12:26 ` fengchengwen
2022-06-13 14:15   ` David Marchand
2022-06-14  0:33     ` fengchengwen
2022-06-07 13:00 ` David Marchand
2022-06-08 10:31 ` Jerin Jacob
2022-06-14  5:58 ` [PATCH v2 0/3] bugfix for trace Chengwen Feng
2022-06-14  5:58   ` Chengwen Feng [this message]
2022-06-14  8:25     ` [PATCH v2 1/3] eal: fix segment fault when exit trace David Marchand
2022-06-14  5:58   ` [PATCH v2 2/3] eal: fix trace init fail with long file-prefix Chengwen Feng
2022-06-15 14:02     ` David Marchand
2022-06-15 18:11       ` Jerin Jacob
2022-06-14  5:59   ` [PATCH v2 3/3] test: support trace-autotest when enable trace Chengwen Feng
2022-06-15 14:00     ` David Marchand
2022-06-17  2:42       ` fengchengwen
2022-06-21  9:06         ` David Marchand
2022-06-17  2:29 ` [PATCH v3 0/4] bugfix for trace Chengwen Feng
2022-06-17  2:29   ` [PATCH v3 1/4] eal: fix segment fault when exit trace Chengwen Feng
2022-06-17  2:29   ` [PATCH v3 2/4] eal: fix errno not set if strftime return zero Chengwen Feng
2022-06-21  9:05     ` David Marchand
2022-06-17  2:29   ` [PATCH v3 3/4] eal: fix trace init fail with long file-prefix Chengwen Feng
2022-06-17  2:29   ` [PATCH v3 4/4] test: introduce trace-autotest with traces enabled Chengwen Feng
2022-06-21  9:07     ` David Marchand
2022-06-21  9:07   ` [PATCH v3 0/4] bugfix for trace David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220614055900.22848-2-fengchengwen@huawei.com \
    --to=fengchengwen@huawei.com \
    --cc=anatoly.burakov@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).