DPDK patches and discussions
 help / color / mirror / Atom feed
From: zhichaox.zeng@intel.com
To: dev@dpdk.org
Cc: qiming.yang@intel.com, Zhichao Zeng <zhichaox.zeng@intel.com>,
	Qi Zhang <qi.z.zhang@intel.com>
Subject: [RFC] net/ice: support represented port flow action
Date: Tue, 14 Jun 2022 13:20:33 +0000	[thread overview]
Message-ID: <20220614132033.11604-1-zhichaox.zeng@intel.com> (raw)

From: Zhichao Zeng <zhichaox.zeng@intel.com>

Add support for action REPRESENTED_PORT, which send traffic
to the VF represented by the given ethdev.

Signed-off-by: Zhichao Zeng <zhichaox.zeng@intel.com>
---
 doc/guides/nics/features/ice.ini    |  1 +
 drivers/net/ice/ice_switch_filter.c | 43 +++++++++++++++++++++++++++++
 2 files changed, 44 insertions(+)

diff --git a/doc/guides/nics/features/ice.ini b/doc/guides/nics/features/ice.ini
index 7861790a51..12fd802885 100644
--- a/doc/guides/nics/features/ice.ini
+++ b/doc/guides/nics/features/ice.ini
@@ -82,3 +82,4 @@ passthru             = Y
 queue                = Y
 rss                  = Y
 vf                   = Y
+represented_port     = Y
diff --git a/drivers/net/ice/ice_switch_filter.c b/drivers/net/ice/ice_switch_filter.c
index 36c9bffb73..56bc392ac7 100644
--- a/drivers/net/ice/ice_switch_filter.c
+++ b/drivers/net/ice/ice_switch_filter.c
@@ -1618,9 +1618,14 @@ ice_switch_parse_dcf_action(struct ice_dcf_adapter *ad,
 			    struct rte_flow_error *error,
 			    struct ice_adv_rule_info *rule_info)
 {
+	const struct rte_flow_action_ethdev *act_represented_port;
+	const struct rte_eth_dev *representor_dev;
 	const struct rte_flow_action_vf *act_vf;
 	const struct rte_flow_action *action;
+	const struct ice_pf *pf;
 	enum rte_flow_action_type action_type;
+	uint16_t representor_port_id, representor_id;
+	uint16_t backer_port_id, pf_port_id;
 
 	for (action = actions; action->type !=
 				RTE_FLOW_ACTION_TYPE_END; action++) {
@@ -1646,6 +1651,43 @@ ice_switch_parse_dcf_action(struct ice_dcf_adapter *ad,
 				rule_info->sw_act.vsi_handle = act_vf->id;
 			break;
 
+		case RTE_FLOW_ACTION_TYPE_REPRESENTED_PORT:
+			/**
+			 * The following two cases will return an invalid parameter error code:
+			 * 1.The given port_id is not in the valid range
+			 * 2.The VF represented by the representor and the current adapter do
+			 *   not belong to the same PF
+			 */
+			rule_info->sw_act.fltr_act = ICE_FWD_TO_VSI;
+			act_represented_port = action->conf;
+			representor_dev = &rte_eth_devices[act_represented_port->port_id];
+			pf = &ad->parent.pf;
+			pf_port_id = pf->dev_data->port_id;
+
+			if (!representor_dev->data) {
+				rte_flow_error_set(error,
+					EINVAL, RTE_FLOW_ERROR_TYPE_ACTION,
+					actions,
+					"Invalid ethdev_port_id");
+				return -rte_errno;
+			}
+
+			backer_port_id = representor_dev->data->backer_port_id;
+			representor_id = representor_dev->data->representor_id;
+			representor_port_id = representor_dev->data->port_id;
+
+			if (backer_port_id != pf_port_id &&
+				(representor_id || pf_port_id != representor_port_id)) {
+				rte_flow_error_set(error,
+					EINVAL, RTE_FLOW_ERROR_TYPE_ACTION,
+					actions,
+					"Invalid ethdev_port_id");
+				return -rte_errno;
+			}
+
+			rule_info->sw_act.vsi_handle = representor_id;
+			break;
+
 		case RTE_FLOW_ACTION_TYPE_DROP:
 			rule_info->sw_act.fltr_act = ICE_DROP_PACKET;
 			break;
@@ -1789,6 +1831,7 @@ ice_switch_check_action(const struct rte_flow_action *actions,
 		case RTE_FLOW_ACTION_TYPE_RSS:
 		case RTE_FLOW_ACTION_TYPE_QUEUE:
 		case RTE_FLOW_ACTION_TYPE_DROP:
+		case RTE_FLOW_ACTION_TYPE_REPRESENTED_PORT:
 			actions_num++;
 			break;
 		case RTE_FLOW_ACTION_TYPE_VOID:
-- 
2.25.1


             reply	other threads:[~2022-06-14  5:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-14 13:20 zhichaox.zeng [this message]
2022-07-20  2:02 ` Zeng, ZhichaoX
2022-08-08  1:28 ` Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220614132033.11604-1-zhichaox.zeng@intel.com \
    --to=zhichaox.zeng@intel.com \
    --cc=dev@dpdk.org \
    --cc=qi.z.zhang@intel.com \
    --cc=qiming.yang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).