From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 78227A0548;
Wed, 15 Jun 2022 15:09:04 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 6483440F1A;
Wed, 15 Jun 2022 15:09:04 +0200 (CEST)
Received: from NAM02-DM3-obe.outbound.protection.outlook.com
(mail-dm3nam02on2079.outbound.protection.outlook.com [40.107.95.79])
by mails.dpdk.org (Postfix) with ESMTP id 8E4EB40F19
for <dev@dpdk.org>; Wed, 15 Jun 2022 15:09:02 +0200 (CEST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=m+zkws8hxPkP1wLP+6D0/BBg3J/OgWXkHwV/ipvfqy5IZE3oe72QDQEQoBq+2yDSae1wavrp6Ouzqbg0LiCyjUmNr1f6z97w3lMKokIESxL3rptZnVgynPlKKZFXBJFWaGuGJ23ZiTb4nce38Fy9UkK0crq0A/PO7l9bIUtqpR+40Zjob6oC87QuKzUKIv0XOeg1KJvCRZFqNxWTkSwDuwK9fWEMR1vzY2/NQ4jD7ijYE20VCcBsC1tTFG4ScWjVzFzfxL4+8VbN4X4+z+63VT5GTpEW4WktgI2P9DfLlX5T+04mQSBpDb6TYovEw5VrZzawzhT800wEHQcXCnIunw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=lnjJ12K6Euf4JDX+1Q6sh/8Fpp1+3LYhtr0kWNlOt/Y=;
b=gdG+NxE+23PV/z/RLjzlMSsQ7dQZnMTTzc3I9YLiGvGIwTsZ4qpgtubMLIPDzxHWycIySCZzC5+LqStDBopLYhfi5zJ28Sw7LwU8lNP7XllXwglodKHdUk16cjiwDOawWepX2RRnE2Y/JsIcdH2s9mUsiHsUrpY6wFbTYyUCrIUPF6kBoSIOTAByHsYYgXVU9JU/B1caq+12RAEFd+zcYPzlUXJxoFnTH2JYTghqkLN3lePE0KUNRxS9qopPrF/JAsS/1xARIFJ9EvGALfvVBdI+Qc+QZna7XzAFIOCPc5OFagYmT+q7QXv7ObQ/DcjihHRyXFGMwrRRc0+l0Hr/uw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
12.22.5.236) smtp.rcpttodomain=networkplumber.org smtp.mailfrom=nvidia.com;
dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;
dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
s=selector2;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=lnjJ12K6Euf4JDX+1Q6sh/8Fpp1+3LYhtr0kWNlOt/Y=;
b=ZWXi1W17hmWPAo6r6nbDeFcNTF8PTwwSLuJTKS/4gssJ+3AKiF4ZXXhBejdW7cZQFZC1pOFKYBbVCLayDDbahoqhvkbA1SJXJP3NzK0C2gYvWdZ2uTNHMrQdCT5jZmylUAKWkfsC4HlIKZ3L2ByL+5FO6v3rQOWtMZhzj/iRf92ODM/XLjbnn3wyyiNJs8LPmMSMx7UL2++93T1BgC3ZaUCHbd8J/DDnw4ALogW7H6IutR/9B7CqpqsdW82gpFPERkYus90YPc1kPHYVLFvdXHeFo9O70PgtcO39Ij++izdwZiZM5Tww4m17VI+6mJ4GihqZs2+kX7zz3JORa2ZxqA==
Received: from MWHPR1601CA0019.namprd16.prod.outlook.com
(2603:10b6:300:da::29) by MWHPR12MB1934.namprd12.prod.outlook.com
(2603:10b6:300:109::23) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.14; Wed, 15 Jun
2022 12:59:01 +0000
Received: from CO1NAM11FT022.eop-nam11.prod.protection.outlook.com
(2603:10b6:300:da:cafe::a) by MWHPR1601CA0019.outlook.office365.com
(2603:10b6:300:da::29) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.14 via Frontend
Transport; Wed, 15 Jun 2022 12:59:01 +0000
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.236)
smtp.mailfrom=nvidia.com; dkim=none (message not signed)
header.d=none;dmarc=pass action=none header.from=nvidia.com;
Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
12.22.5.236 as permitted sender) receiver=protection.outlook.com;
client-ip=12.22.5.236; helo=mail.nvidia.com; pr=C
Received: from mail.nvidia.com (12.22.5.236) by
CO1NAM11FT022.mail.protection.outlook.com (10.13.175.199) with Microsoft SMTP
Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id
15.20.5332.12 via Frontend Transport; Wed, 15 Jun 2022 12:59:01 +0000
Received: from rnnvmail201.nvidia.com (10.129.68.8) by DRHQMAIL109.nvidia.com
(10.27.9.19) with Microsoft SMTP Server (TLS) id 15.0.1497.32;
Wed, 15 Jun 2022 12:59:00 +0000
Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com
(10.129.68.8) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 15 Jun
2022 05:58:56 -0700
From: Spike Du <spiked@nvidia.com>
To: <matan@nvidia.com>, <viacheslavo@nvidia.com>, <orika@nvidia.com>,
<thomas@monjalon.net>, Shahaf Shuler <shahafs@nvidia.com>, Ray Kinsella
<mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>
CC: <andrew.rybchenko@oktetlabs.ru>, <stephen@networkplumber.org>,
<mb@smartsharesystems.com>, <dev@dpdk.org>, <rasland@nvidia.com>
Subject: [PATCH v8 2/6] common/mlx5: share interrupt management
Date: Wed, 15 Jun 2022 15:58:32 +0300
Message-ID: <20220615125836.391771-3-spiked@nvidia.com>
X-Mailer: git-send-email 2.27.0
In-Reply-To: <20220615125836.391771-1-spiked@nvidia.com>
References: <20220614120134.1828188-2-spiked@nvidia.com>
<20220615125836.391771-1-spiked@nvidia.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-Originating-IP: [10.126.230.35]
X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To
rnnvmail201.nvidia.com (10.129.68.8)
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 69de5b76-54c2-4ccb-36ee-08da4eced197
X-MS-TrafficTypeDiagnostic: MWHPR12MB1934:EE_
X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr
X-Microsoft-Antispam-PRVS: <MWHPR12MB1934A297588DCB5AF5A14496A8AD9@MWHPR12MB1934.namprd12.prod.outlook.com>
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: kY2yWmTcKK8vr+qedc51XVw121DAWR/EH3k9h9NHZ/3ZKgNsH2gRJEVpXX4Z4T7zpSpTV2faciawF0CwW/awOaV/qP3NpwR0DTXWlM1eH1MPscjITC8GjJpPi+6Hg0Irqj7B8Rfurohjpsp8Sj3xBXpRGbgQ7a/jZPlJiqq+tCQQsaYeY9bnelS3JPxxl+SQzqeJS2xBCW6hAq8gVHKVWkZN1hGnBWeA6QJnsUb/8DcC1E7D96qA4jjL1xutoUK9QItrIKumXeQ+yyqE+DD0l4fmsL0XZBSRK9yDnfFP1pF4KCoBHAxw0KBuom1m0UdnM/fAoWVDHxUhwK5pwJr4eT/Nc31jgxcDp1Pog68OBEStDuY2EaYyy+2bcNxdmKZOVj2EY121+h6yp6as8mBU7VD86v0qQLcpeM/VqPTlVuE5WsTk+s/rDLscny2XEs9XkSUC/B2FT6I+Cn8GLztIv2fZvu173dhQ1rzQeCTiUyInf7dOaM2Mnnp9vvkMMg5rrMkIM0nAwAttB/dDN6GsJY0SBz7RDP/jKygsYvxB/f1eq8QxXXKl4TVkjHQe4pzR9TiR5/3oLWdvovibLpJp6Pv/LPyMPU+9MJg73gUizgEJGoJ811u6or09zxEwRkME6gOe+Fi88RqcWjM+L5Jw+zhZ+uxW+jVvwONlZwZgLbCJxhXF8tXbINJ96OM4IiVt2gkCOuWyJovkuS0IGwDPOA==
X-Forefront-Antispam-Report: CIP:12.22.5.236; CTRY:US; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:InfoNoRecords; CAT:NONE;
SFS:(13230016)(4636009)(46966006)(40470700004)(36840700001)(2906002)(6666004)(6286002)(26005)(508600001)(8936002)(40460700003)(82310400005)(86362001)(7696005)(70586007)(36756003)(30864003)(107886003)(83380400001)(2616005)(5660300002)(336012)(47076005)(186003)(1076003)(16526019)(426003)(356005)(81166007)(36860700001)(316002)(55016003)(110136005)(4326008)(54906003)(70206006)(8676002)(36900700001);
DIR:OUT; SFP:1101;
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2022 12:59:01.1674 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 69de5b76-54c2-4ccb-36ee-08da4eced197
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[12.22.5.236];
Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT022.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1934
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
There are many duplicate code of creating and initializing rte_intr_handle.
Add a new mlx5_os API to do this, replace all PMD related code with this
API.
Signed-off-by: Spike Du <spiked@nvidia.com>
---
drivers/common/mlx5/linux/mlx5_common_os.c | 131 ++++++++++++++++++++++++++
drivers/common/mlx5/linux/mlx5_common_os.h | 11 +++
drivers/common/mlx5/version.map | 2 +
drivers/common/mlx5/windows/mlx5_common_os.h | 24 +++++
drivers/net/mlx5/linux/mlx5_ethdev_os.c | 71 --------------
drivers/net/mlx5/linux/mlx5_os.c | 132 ++++++---------------------
drivers/net/mlx5/linux/mlx5_socket.c | 53 ++---------
drivers/net/mlx5/mlx5.h | 2 -
drivers/net/mlx5/mlx5_txpp.c | 28 ++----
drivers/net/mlx5/windows/mlx5_ethdev_os.c | 22 -----
drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 48 ++--------
11 files changed, 217 insertions(+), 307 deletions(-)
diff --git a/drivers/common/mlx5/linux/mlx5_common_os.c b/drivers/common/mlx5/linux/mlx5_common_os.c
index d40cfd5..f10a981 100644
--- a/drivers/common/mlx5/linux/mlx5_common_os.c
+++ b/drivers/common/mlx5/linux/mlx5_common_os.c
@@ -11,6 +11,7 @@
#endif
#include <dirent.h>
#include <net/if.h>
+#include <fcntl.h>
#include <rte_errno.h>
#include <rte_string_fns.h>
@@ -964,3 +965,133 @@
claim_zero(mlx5_glue->dereg_mr(pmd_mr->obj));
memset(pmd_mr, 0, sizeof(*pmd_mr));
}
+
+/**
+ * Rte_intr_handle create and init helper.
+ *
+ * @param[in] mode
+ * interrupt instance can be shared between primary and secondary
+ * processes or not.
+ * @param[in] set_fd_nonblock
+ * Whether to set fd to O_NONBLOCK.
+ * @param[in] fd
+ * Fd to set in created intr_handle.
+ * @param[in] cb
+ * Callback to register for intr_handle.
+ * @param[in] cb_arg
+ * Callback argument for cb.
+ *
+ * @return
+ * - Interrupt handle on success.
+ * - NULL on failure, with rte_errno set.
+ */
+struct rte_intr_handle *
+mlx5_os_interrupt_handler_create(int mode, bool set_fd_nonblock, int fd,
+ rte_intr_callback_fn cb, void *cb_arg)
+{
+ struct rte_intr_handle *tmp_intr_handle;
+ int ret, flags;
+
+ tmp_intr_handle = rte_intr_instance_alloc(mode);
+ if (!tmp_intr_handle) {
+ rte_errno = ENOMEM;
+ goto err;
+ }
+ if (set_fd_nonblock) {
+ flags = fcntl(fd, F_GETFL);
+ ret = fcntl(fd, F_SETFL, flags | O_NONBLOCK);
+ if (ret) {
+ rte_errno = errno;
+ goto err;
+ }
+ }
+ ret = rte_intr_fd_set(tmp_intr_handle, fd);
+ if (ret)
+ goto err;
+ ret = rte_intr_type_set(tmp_intr_handle, RTE_INTR_HANDLE_EXT);
+ if (ret)
+ goto err;
+ ret = rte_intr_callback_register(tmp_intr_handle, cb, cb_arg);
+ if (ret) {
+ rte_errno = -ret;
+ goto err;
+ }
+ return tmp_intr_handle;
+err:
+ if (tmp_intr_handle)
+ rte_intr_instance_free(tmp_intr_handle);
+ return NULL;
+}
+
+/* Safe unregistration for interrupt callback. */
+static void
+mlx5_intr_callback_unregister(const struct rte_intr_handle *handle,
+ rte_intr_callback_fn cb_fn, void *cb_arg)
+{
+ uint64_t twait = 0;
+ uint64_t start = 0;
+
+ do {
+ int ret;
+
+ ret = rte_intr_callback_unregister(handle, cb_fn, cb_arg);
+ if (ret >= 0)
+ return;
+ if (ret != -EAGAIN) {
+ DRV_LOG(INFO, "failed to unregister interrupt"
+ " handler (error: %d)", ret);
+ MLX5_ASSERT(false);
+ return;
+ }
+ if (twait) {
+ struct timespec onems;
+
+ /* Wait one millisecond and try again. */
+ onems.tv_sec = 0;
+ onems.tv_nsec = NS_PER_S / MS_PER_S;
+ nanosleep(&onems, 0);
+ /* Check whether one second elapsed. */
+ if ((rte_get_timer_cycles() - start) <= twait)
+ continue;
+ } else {
+ /*
+ * We get the amount of timer ticks for one second.
+ * If this amount elapsed it means we spent one
+ * second in waiting. This branch is executed once
+ * on first iteration.
+ */
+ twait = rte_get_timer_hz();
+ MLX5_ASSERT(twait);
+ }
+ /*
+ * Timeout elapsed, show message (once a second) and retry.
+ * We have no other acceptable option here, if we ignore
+ * the unregistering return code the handler will not
+ * be unregistered, fd will be closed and we may get the
+ * crush. Hanging and messaging in the loop seems not to be
+ * the worst choice.
+ */
+ DRV_LOG(INFO, "Retrying to unregister interrupt handler");
+ start = rte_get_timer_cycles();
+ } while (true);
+}
+
+/**
+ * Rte_intr_handle destroy helper.
+ *
+ * @param[in] intr_handle
+ * Rte_intr_handle to destroy.
+ * @param[in] cb
+ * Callback which is registered to intr_handle.
+ * @param[in] cb_arg
+ * Callback argument for cb.
+ *
+ */
+void
+mlx5_os_interrupt_handler_destroy(struct rte_intr_handle *intr_handle,
+ rte_intr_callback_fn cb, void *cb_arg)
+{
+ if (rte_intr_fd_get(intr_handle) >= 0)
+ mlx5_intr_callback_unregister(intr_handle, cb, cb_arg);
+ rte_intr_instance_free(intr_handle);
+}
diff --git a/drivers/common/mlx5/linux/mlx5_common_os.h b/drivers/common/mlx5/linux/mlx5_common_os.h
index 27f1192..479bb3c 100644
--- a/drivers/common/mlx5/linux/mlx5_common_os.h
+++ b/drivers/common/mlx5/linux/mlx5_common_os.h
@@ -15,6 +15,7 @@
#include <rte_log.h>
#include <rte_kvargs.h>
#include <rte_devargs.h>
+#include <rte_interrupts.h>
#include "mlx5_autoconf.h"
#include "mlx5_glue.h"
@@ -299,4 +300,14 @@
int
mlx5_get_device_guid(const struct rte_pci_addr *dev, uint8_t *guid, size_t len);
+__rte_internal
+struct rte_intr_handle *
+mlx5_os_interrupt_handler_create(int mode, bool set_fd_nonblock, int fd,
+ rte_intr_callback_fn cb, void *cb_arg);
+
+__rte_internal
+void
+mlx5_os_interrupt_handler_destroy(struct rte_intr_handle *intr_handle,
+ rte_intr_callback_fn cb, void *cb_arg);
+
#endif /* RTE_PMD_MLX5_COMMON_OS_H_ */
diff --git a/drivers/common/mlx5/version.map b/drivers/common/mlx5/version.map
index a23a30a..413dec1 100644
--- a/drivers/common/mlx5/version.map
+++ b/drivers/common/mlx5/version.map
@@ -153,5 +153,7 @@ INTERNAL {
mlx5_mr_mempool2mr_bh;
mlx5_mr_mempool_populate_cache;
+ mlx5_os_interrupt_handler_create; # WINDOWS_NO_EXPORT
+ mlx5_os_interrupt_handler_destroy; # WINDOWS_NO_EXPORT
local: *;
};
diff --git a/drivers/common/mlx5/windows/mlx5_common_os.h b/drivers/common/mlx5/windows/mlx5_common_os.h
index ee7973f..e9e9108 100644
--- a/drivers/common/mlx5/windows/mlx5_common_os.h
+++ b/drivers/common/mlx5/windows/mlx5_common_os.h
@@ -9,6 +9,7 @@
#include <sys/types.h>
#include <rte_errno.h>
+#include <rte_interrupts.h>
#include "mlx5_autoconf.h"
#include "mlx5_glue.h"
@@ -253,4 +254,27 @@
__rte_internal
int mlx5_os_umem_dereg(void *pumem);
+static inline struct rte_intr_handle *
+mlx5_os_interrupt_handler_create(int mode, bool set_fd_nonblock, int fd,
+ rte_intr_callback_fn cb, void *cb_arg)
+{
+ (void)mode;
+ (void)set_fd_nonblock;
+ (void)fd;
+ (void)cb;
+ (void)cb_arg;
+ rte_errno = ENOTSUP;
+ return NULL;
+}
+
+static inline void
+mlx5_os_interrupt_handler_destroy(struct rte_intr_handle *intr_handle,
+ rte_intr_callback_fn cb, void *cb_arg)
+{
+ (void)intr_handle;
+ (void)cb;
+ (void)cb_arg;
+}
+
+
#endif /* RTE_PMD_MLX5_COMMON_OS_H_ */
diff --git a/drivers/net/mlx5/linux/mlx5_ethdev_os.c b/drivers/net/mlx5/linux/mlx5_ethdev_os.c
index 8fe73f1..a276b2b 100644
--- a/drivers/net/mlx5/linux/mlx5_ethdev_os.c
+++ b/drivers/net/mlx5/linux/mlx5_ethdev_os.c
@@ -881,77 +881,6 @@ struct ethtool_link_settings {
}
}
-/*
- * Unregister callback handler safely. The handler may be active
- * while we are trying to unregister it, in this case code -EAGAIN
- * is returned by rte_intr_callback_unregister(). This routine checks
- * the return code and tries to unregister handler again.
- *
- * @param handle
- * interrupt handle
- * @param cb_fn
- * pointer to callback routine
- * @cb_arg
- * opaque callback parameter
- */
-void
-mlx5_intr_callback_unregister(const struct rte_intr_handle *handle,
- rte_intr_callback_fn cb_fn, void *cb_arg)
-{
- /*
- * Try to reduce timeout management overhead by not calling
- * the timer related routines on the first iteration. If the
- * unregistering succeeds on first call there will be no
- * timer calls at all.
- */
- uint64_t twait = 0;
- uint64_t start = 0;
-
- do {
- int ret;
-
- ret = rte_intr_callback_unregister(handle, cb_fn, cb_arg);
- if (ret >= 0)
- return;
- if (ret != -EAGAIN) {
- DRV_LOG(INFO, "failed to unregister interrupt"
- " handler (error: %d)", ret);
- MLX5_ASSERT(false);
- return;
- }
- if (twait) {
- struct timespec onems;
-
- /* Wait one millisecond and try again. */
- onems.tv_sec = 0;
- onems.tv_nsec = NS_PER_S / MS_PER_S;
- nanosleep(&onems, 0);
- /* Check whether one second elapsed. */
- if ((rte_get_timer_cycles() - start) <= twait)
- continue;
- } else {
- /*
- * We get the amount of timer ticks for one second.
- * If this amount elapsed it means we spent one
- * second in waiting. This branch is executed once
- * on first iteration.
- */
- twait = rte_get_timer_hz();
- MLX5_ASSERT(twait);
- }
- /*
- * Timeout elapsed, show message (once a second) and retry.
- * We have no other acceptable option here, if we ignore
- * the unregistering return code the handler will not
- * be unregistered, fd will be closed and we may get the
- * crush. Hanging and messaging in the loop seems not to be
- * the worst choice.
- */
- DRV_LOG(INFO, "Retrying to unregister interrupt handler");
- start = rte_get_timer_cycles();
- } while (true);
-}
-
/**
* Handle DEVX interrupts from the NIC.
* This function is probably called from the DPDK host thread.
diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c
index a821153..0741028 100644
--- a/drivers/net/mlx5/linux/mlx5_os.c
+++ b/drivers/net/mlx5/linux/mlx5_os.c
@@ -2494,40 +2494,6 @@
mlx5_pmd_socket_uninit();
}
-static int
-mlx5_os_dev_shared_handler_install_lsc(struct mlx5_dev_ctx_shared *sh)
-{
- int nlsk_fd, flags, ret;
-
- nlsk_fd = mlx5_nl_init(NETLINK_ROUTE, RTMGRP_LINK);
- if (nlsk_fd < 0) {
- DRV_LOG(ERR, "Failed to create a socket for Netlink events: %s",
- rte_strerror(rte_errno));
- return -1;
- }
- flags = fcntl(nlsk_fd, F_GETFL);
- ret = fcntl(nlsk_fd, F_SETFL, flags | O_NONBLOCK);
- if (ret != 0) {
- DRV_LOG(ERR, "Failed to make Netlink event socket non-blocking: %s",
- strerror(errno));
- rte_errno = errno;
- goto error;
- }
- rte_intr_type_set(sh->intr_handle_nl, RTE_INTR_HANDLE_EXT);
- rte_intr_fd_set(sh->intr_handle_nl, nlsk_fd);
- if (rte_intr_callback_register(sh->intr_handle_nl,
- mlx5_dev_interrupt_handler_nl,
- sh) != 0) {
- DRV_LOG(ERR, "Failed to register Netlink events interrupt");
- rte_intr_fd_set(sh->intr_handle_nl, -1);
- goto error;
- }
- return 0;
-error:
- close(nlsk_fd);
- return -1;
-}
-
/**
* Install shared asynchronous device events handler.
* This function is implemented to support event sharing
@@ -2539,76 +2505,47 @@
void
mlx5_os_dev_shared_handler_install(struct mlx5_dev_ctx_shared *sh)
{
- int ret;
- int flags;
struct ibv_context *ctx = sh->cdev->ctx;
+ int nlsk_fd;
- sh->intr_handle = rte_intr_instance_alloc(RTE_INTR_INSTANCE_F_SHARED);
- if (sh->intr_handle == NULL) {
- DRV_LOG(ERR, "Fail to allocate intr_handle");
- rte_errno = ENOMEM;
+ sh->intr_handle = mlx5_os_interrupt_handler_create
+ (RTE_INTR_INSTANCE_F_SHARED, true,
+ ctx->async_fd, mlx5_dev_interrupt_handler, sh);
+ if (!sh->intr_handle) {
+ DRV_LOG(ERR, "Failed to allocate intr_handle.");
return;
}
- rte_intr_fd_set(sh->intr_handle, -1);
-
- flags = fcntl(ctx->async_fd, F_GETFL);
- ret = fcntl(ctx->async_fd, F_SETFL, flags | O_NONBLOCK);
- if (ret) {
- DRV_LOG(INFO, "failed to change file descriptor async event"
- " queue");
- } else {
- rte_intr_fd_set(sh->intr_handle, ctx->async_fd);
- rte_intr_type_set(sh->intr_handle, RTE_INTR_HANDLE_EXT);
- if (rte_intr_callback_register(sh->intr_handle,
- mlx5_dev_interrupt_handler, sh)) {
- DRV_LOG(INFO, "Fail to install the shared interrupt.");
- rte_intr_fd_set(sh->intr_handle, -1);
- }
+ nlsk_fd = mlx5_nl_init(NETLINK_ROUTE, RTMGRP_LINK);
+ if (nlsk_fd < 0) {
+ DRV_LOG(ERR, "Failed to create a socket for Netlink events: %s",
+ rte_strerror(rte_errno));
+ return;
}
- sh->intr_handle_nl = rte_intr_instance_alloc
- (RTE_INTR_INSTANCE_F_SHARED);
+ sh->intr_handle_nl = mlx5_os_interrupt_handler_create
+ (RTE_INTR_INSTANCE_F_SHARED, true,
+ nlsk_fd, mlx5_dev_interrupt_handler_nl, sh);
if (sh->intr_handle_nl == NULL) {
DRV_LOG(ERR, "Fail to allocate intr_handle");
- rte_errno = ENOMEM;
return;
}
- rte_intr_fd_set(sh->intr_handle_nl, -1);
- if (mlx5_os_dev_shared_handler_install_lsc(sh) < 0) {
- DRV_LOG(INFO, "Fail to install the shared Netlink event handler.");
- rte_intr_fd_set(sh->intr_handle_nl, -1);
- }
if (sh->cdev->config.devx) {
#ifdef HAVE_IBV_DEVX_ASYNC
- sh->intr_handle_devx =
- rte_intr_instance_alloc(RTE_INTR_INSTANCE_F_SHARED);
- if (!sh->intr_handle_devx) {
- DRV_LOG(ERR, "Fail to allocate intr_handle");
- rte_errno = ENOMEM;
- return;
- }
- rte_intr_fd_set(sh->intr_handle_devx, -1);
+ struct mlx5dv_devx_cmd_comp *devx_comp;
+
sh->devx_comp = (void *)mlx5_glue->devx_create_cmd_comp(ctx);
- struct mlx5dv_devx_cmd_comp *devx_comp = sh->devx_comp;
+ devx_comp = sh->devx_comp;
if (!devx_comp) {
DRV_LOG(INFO, "failed to allocate devx_comp.");
return;
}
- flags = fcntl(devx_comp->fd, F_GETFL);
- ret = fcntl(devx_comp->fd, F_SETFL, flags | O_NONBLOCK);
- if (ret) {
- DRV_LOG(INFO, "failed to change file descriptor"
- " devx comp");
+ sh->intr_handle_devx = mlx5_os_interrupt_handler_create
+ (RTE_INTR_INSTANCE_F_SHARED, true,
+ devx_comp->fd,
+ mlx5_dev_interrupt_handler_devx, sh);
+ if (!sh->intr_handle_devx) {
+ DRV_LOG(ERR, "Failed to allocate intr_handle.");
return;
}
- rte_intr_fd_set(sh->intr_handle_devx, devx_comp->fd);
- rte_intr_type_set(sh->intr_handle_devx,
- RTE_INTR_HANDLE_EXT);
- if (rte_intr_callback_register(sh->intr_handle_devx,
- mlx5_dev_interrupt_handler_devx, sh)) {
- DRV_LOG(INFO, "Fail to install the devx shared"
- " interrupt.");
- rte_intr_fd_set(sh->intr_handle_devx, -1);
- }
#endif /* HAVE_IBV_DEVX_ASYNC */
}
}
@@ -2624,24 +2561,13 @@
void
mlx5_os_dev_shared_handler_uninstall(struct mlx5_dev_ctx_shared *sh)
{
- int nlsk_fd;
-
- if (rte_intr_fd_get(sh->intr_handle) >= 0)
- mlx5_intr_callback_unregister(sh->intr_handle,
- mlx5_dev_interrupt_handler, sh);
- rte_intr_instance_free(sh->intr_handle);
- nlsk_fd = rte_intr_fd_get(sh->intr_handle_nl);
- if (nlsk_fd >= 0) {
- mlx5_intr_callback_unregister
- (sh->intr_handle_nl, mlx5_dev_interrupt_handler_nl, sh);
- close(nlsk_fd);
- }
- rte_intr_instance_free(sh->intr_handle_nl);
+ mlx5_os_interrupt_handler_destroy(sh->intr_handle,
+ mlx5_dev_interrupt_handler, sh);
+ mlx5_os_interrupt_handler_destroy(sh->intr_handle_nl,
+ mlx5_dev_interrupt_handler_nl, sh);
#ifdef HAVE_IBV_DEVX_ASYNC
- if (rte_intr_fd_get(sh->intr_handle_devx) >= 0)
- rte_intr_callback_unregister(sh->intr_handle_devx,
- mlx5_dev_interrupt_handler_devx, sh);
- rte_intr_instance_free(sh->intr_handle_devx);
+ mlx5_os_interrupt_handler_destroy(sh->intr_handle_devx,
+ mlx5_dev_interrupt_handler_devx, sh);
if (sh->devx_comp)
mlx5_glue->devx_destroy_cmd_comp(sh->devx_comp);
#endif
diff --git a/drivers/net/mlx5/linux/mlx5_socket.c b/drivers/net/mlx5/linux/mlx5_socket.c
index 4882e5f..0e01aff 100644
--- a/drivers/net/mlx5/linux/mlx5_socket.c
+++ b/drivers/net/mlx5/linux/mlx5_socket.c
@@ -134,51 +134,6 @@
}
/**
- * Install interrupt handler.
- *
- * @param dev
- * Pointer to Ethernet device.
- * @return
- * 0 on success, a negative errno value otherwise.
- */
-static int
-mlx5_pmd_interrupt_handler_install(void)
-{
- MLX5_ASSERT(server_socket != -1);
-
- server_intr_handle =
- rte_intr_instance_alloc(RTE_INTR_INSTANCE_F_PRIVATE);
- if (server_intr_handle == NULL) {
- DRV_LOG(ERR, "Fail to allocate intr_handle");
- return -ENOMEM;
- }
- if (rte_intr_fd_set(server_intr_handle, server_socket))
- return -rte_errno;
-
- if (rte_intr_type_set(server_intr_handle, RTE_INTR_HANDLE_EXT))
- return -rte_errno;
-
- return rte_intr_callback_register(server_intr_handle,
- mlx5_pmd_socket_handle, NULL);
-}
-
-/**
- * Uninstall interrupt handler.
- */
-static void
-mlx5_pmd_interrupt_handler_uninstall(void)
-{
- if (server_socket != -1) {
- mlx5_intr_callback_unregister(server_intr_handle,
- mlx5_pmd_socket_handle,
- NULL);
- }
- rte_intr_fd_set(server_intr_handle, 0);
- rte_intr_type_set(server_intr_handle, RTE_INTR_HANDLE_UNKNOWN);
- rte_intr_instance_free(server_intr_handle);
-}
-
-/**
* Initialise the socket to communicate with external tools.
*
* @return
@@ -224,7 +179,10 @@
strerror(errno));
goto remove;
}
- if (mlx5_pmd_interrupt_handler_install()) {
+ server_intr_handle = mlx5_os_interrupt_handler_create
+ (RTE_INTR_INSTANCE_F_PRIVATE, false,
+ server_socket, mlx5_pmd_socket_handle, NULL);
+ if (server_intr_handle == NULL) {
DRV_LOG(WARNING, "cannot register interrupt handler for mlx5 socket: %s",
strerror(errno));
goto remove;
@@ -248,7 +206,8 @@
{
if (server_socket == -1)
return;
- mlx5_pmd_interrupt_handler_uninstall();
+ mlx5_os_interrupt_handler_destroy(server_intr_handle,
+ mlx5_pmd_socket_handle, NULL);
claim_zero(close(server_socket));
server_socket = -1;
MKSTR(path, MLX5_SOCKET_PATH, getpid());
diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h
index 305edff..7ebb2cc 100644
--- a/drivers/net/mlx5/mlx5.h
+++ b/drivers/net/mlx5/mlx5.h
@@ -1682,8 +1682,6 @@ int mlx5_sysfs_switch_info(unsigned int ifindex,
struct mlx5_switch_info *info);
void mlx5_translate_port_name(const char *port_name_in,
struct mlx5_switch_info *port_info_out);
-void mlx5_intr_callback_unregister(const struct rte_intr_handle *handle,
- rte_intr_callback_fn cb_fn, void *cb_arg);
int mlx5_sysfs_bond_info(unsigned int pf_ifindex, unsigned int *ifindex,
char *ifname);
int mlx5_get_module_info(struct rte_eth_dev *dev,
diff --git a/drivers/net/mlx5/mlx5_txpp.c b/drivers/net/mlx5/mlx5_txpp.c
index fe74317..f853a67 100644
--- a/drivers/net/mlx5/mlx5_txpp.c
+++ b/drivers/net/mlx5/mlx5_txpp.c
@@ -741,11 +741,8 @@
static void
mlx5_txpp_stop_service(struct mlx5_dev_ctx_shared *sh)
{
- if (!rte_intr_fd_get(sh->txpp.intr_handle))
- return;
- mlx5_intr_callback_unregister(sh->txpp.intr_handle,
- mlx5_txpp_interrupt_handler, sh);
- rte_intr_instance_free(sh->txpp.intr_handle);
+ mlx5_os_interrupt_handler_destroy(sh->txpp.intr_handle,
+ mlx5_txpp_interrupt_handler, sh);
}
/* Attach interrupt handler and fires first request to Rearm Queue. */
@@ -769,23 +766,12 @@
rte_errno = errno;
return -rte_errno;
}
- sh->txpp.intr_handle =
- rte_intr_instance_alloc(RTE_INTR_INSTANCE_F_SHARED);
- if (sh->txpp.intr_handle == NULL) {
- DRV_LOG(ERR, "Fail to allocate intr_handle");
- return -ENOMEM;
- }
fd = mlx5_os_get_devx_channel_fd(sh->txpp.echan);
- if (rte_intr_fd_set(sh->txpp.intr_handle, fd))
- return -rte_errno;
-
- if (rte_intr_type_set(sh->txpp.intr_handle, RTE_INTR_HANDLE_EXT))
- return -rte_errno;
-
- if (rte_intr_callback_register(sh->txpp.intr_handle,
- mlx5_txpp_interrupt_handler, sh)) {
- rte_intr_fd_set(sh->txpp.intr_handle, 0);
- DRV_LOG(ERR, "Failed to register CQE interrupt %d.", rte_errno);
+ sh->txpp.intr_handle = mlx5_os_interrupt_handler_create
+ (RTE_INTR_INSTANCE_F_SHARED, false,
+ fd, mlx5_txpp_interrupt_handler, sh);
+ if (!sh->txpp.intr_handle) {
+ DRV_LOG(ERR, "Fail to allocate intr_handle");
return -rte_errno;
}
/* Subscribe CQ event to the event channel controlled by the driver. */
diff --git a/drivers/net/mlx5/windows/mlx5_ethdev_os.c b/drivers/net/mlx5/windows/mlx5_ethdev_os.c
index f975265..88d8213 100644
--- a/drivers/net/mlx5/windows/mlx5_ethdev_os.c
+++ b/drivers/net/mlx5/windows/mlx5_ethdev_os.c
@@ -140,28 +140,6 @@
return 0;
}
-/*
- * Unregister callback handler safely. The handler may be active
- * while we are trying to unregister it, in this case code -EAGAIN
- * is returned by rte_intr_callback_unregister(). This routine checks
- * the return code and tries to unregister handler again.
- *
- * @param handle
- * interrupt handle
- * @param cb_fn
- * pointer to callback routine
- * @cb_arg
- * opaque callback parameter
- */
-void
-mlx5_intr_callback_unregister(const struct rte_intr_handle *handle,
- rte_intr_callback_fn cb_fn, void *cb_arg)
-{
- RTE_SET_USED(handle);
- RTE_SET_USED(cb_fn);
- RTE_SET_USED(cb_arg);
-}
-
/**
* DPDK callback to get flow control status.
*
diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c b/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c
index e025be4..fd447cc 100644
--- a/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c
+++ b/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c
@@ -93,22 +93,10 @@
static int
mlx5_vdpa_virtq_unset(struct mlx5_vdpa_virtq *virtq)
{
- int ret = -EAGAIN;
-
- if (rte_intr_fd_get(virtq->intr_handle) >= 0) {
- while (ret == -EAGAIN) {
- ret = rte_intr_callback_unregister(virtq->intr_handle,
- mlx5_vdpa_virtq_kick_handler, virtq);
- if (ret == -EAGAIN) {
- DRV_LOG(DEBUG, "Try again to unregister fd %d of virtq %hu interrupt",
- rte_intr_fd_get(virtq->intr_handle),
- virtq->index);
- usleep(MLX5_VDPA_INTR_RETRIES_USEC);
- }
- }
- rte_intr_fd_set(virtq->intr_handle, -1);
- }
- rte_intr_instance_free(virtq->intr_handle);
+ int ret;
+
+ mlx5_os_interrupt_handler_destroy(virtq->intr_handle,
+ mlx5_vdpa_virtq_kick_handler, virtq);
if (virtq->virtq) {
ret = mlx5_vdpa_virtq_stop(virtq->priv, virtq->index);
if (ret)
@@ -365,35 +353,13 @@
virtq->priv = priv;
rte_write32(virtq->index, priv->virtq_db_addr);
/* Setup doorbell mapping. */
- virtq->intr_handle =
- rte_intr_instance_alloc(RTE_INTR_INSTANCE_F_SHARED);
+ virtq->intr_handle = mlx5_os_interrupt_handler_create(
+ RTE_INTR_INSTANCE_F_SHARED, false,
+ vq.kickfd, mlx5_vdpa_virtq_kick_handler, virtq);
if (virtq->intr_handle == NULL) {
DRV_LOG(ERR, "Fail to allocate intr_handle");
goto error;
}
-
- if (rte_intr_fd_set(virtq->intr_handle, vq.kickfd))
- goto error;
-
- if (rte_intr_fd_get(virtq->intr_handle) == -1) {
- DRV_LOG(WARNING, "Virtq %d kickfd is invalid.", index);
- } else {
- if (rte_intr_type_set(virtq->intr_handle, RTE_INTR_HANDLE_EXT))
- goto error;
-
- if (rte_intr_callback_register(virtq->intr_handle,
- mlx5_vdpa_virtq_kick_handler,
- virtq)) {
- rte_intr_fd_set(virtq->intr_handle, -1);
- DRV_LOG(ERR, "Failed to register virtq %d interrupt.",
- index);
- goto error;
- } else {
- DRV_LOG(DEBUG, "Register fd %d interrupt for virtq %d.",
- rte_intr_fd_get(virtq->intr_handle),
- index);
- }
- }
/* Subscribe virtq error event. */
virtq->version++;
cookie = ((uint64_t)virtq->version << 32) + index;
--
1.8.3.1