From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8ED3BA00BE; Thu, 16 Jun 2022 11:24:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5E9BC42BCA; Thu, 16 Jun 2022 11:24:31 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 1882E4281E for ; Thu, 16 Jun 2022 11:24:29 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 25G9D4ct010129 for ; Thu, 16 Jun 2022 02:24:28 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=pfpt0220; bh=5OLpNp8fpyDYQj6CvfBDxD0YVX2QUMm0qknR6TNhX9c=; b=PBLcK1SHSOmlRjlU5pO/jgOX/KTLyeycneXlP88S7CSKWvo9ntg5cGEH5gmbbPDrNkK/ C2veaz3Q/XcAGypPKrlSebiqnIxLArJIyVngpAvFyZm8CqF6TC4E7jMN8d9JmC39++wd 2lh6dP8LNVnTNvSuzmejk2zcCW+BLlAVQkVGSXnjbjdztBAc0zyl+Ae4ed/H0/vaMLx2 20BIqH0wB4plSkl/pcqxCC1TL5F7F26x2zrHNnzfmq4qnwW6zkDNbI/2pRgM93+IIUeH XeHTXwiIuTV02nv/Nf+Qz2Ol9p5mgAYPZbxuJzUwEmuqxRmJh1qfe7qoJCinkmbiTcDn Iw== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3gr1pmg1wf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Thu, 16 Jun 2022 02:24:28 -0700 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Thu, 16 Jun 2022 02:24:27 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 16 Jun 2022 02:24:27 -0700 Received: from hyd1588t430.marvell.com (unknown [10.29.52.204]) by maili.marvell.com (Postfix) with ESMTP id B385D3F7063; Thu, 16 Jun 2022 02:24:24 -0700 (PDT) From: Nithin Dabilpuram To: , Nithin Dabilpuram , "Kiran Kumar K" , Sunil Kumar Kori , Satha Rao , Pavan Nikhilesh , Shijith Thotton CC: Subject: [PATCH v2 01/12] common/cnxk: use computed value for WQE skip Date: Thu, 16 Jun 2022 14:54:09 +0530 Message-ID: <20220616092420.17861-1-ndabilpuram@marvell.com> X-Mailer: git-send-email 2.8.4 In-Reply-To: <20220616070743.30658-1-ndabilpuram@marvell.com> References: <20220616070743.30658-1-ndabilpuram@marvell.com> MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-ORIG-GUID: nrIe4NrjLalAx9rzXxtbSLa7CGGVBvrF X-Proofpoint-GUID: nrIe4NrjLalAx9rzXxtbSLa7CGGVBvrF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.517,FMLib:17.11.64.514 definitions=2022-06-16_05,2022-06-15_01,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Use computed value for WQE skip instead of a hardcoded value. WQE skip needs to be number of 128B lines to accommodate rte_mbuf. Signed-off-by: Nithin Dabilpuram --- Depends-on: series=23500 ("common/cnxk: add cnf10kb support") v2: - Fixed commit message in 10/12, 1/12 patches drivers/common/cnxk/roc_nix_inl.h | 2 +- drivers/common/cnxk/roc_nix_inl_priv.h | 2 +- drivers/event/cnxk/cnxk_eventdev_adptr.c | 5 ++++- drivers/net/cnxk/cnxk_ethdev_sec.c | 5 ++++- 4 files changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/common/cnxk/roc_nix_inl.h b/drivers/common/cnxk/roc_nix_inl.h index b1b4c5b..c7b1817 100644 --- a/drivers/common/cnxk/roc_nix_inl.h +++ b/drivers/common/cnxk/roc_nix_inl.h @@ -131,7 +131,7 @@ struct roc_nix_inl_dev { uint16_t channel; uint16_t chan_mask; bool attach_cptlf; - bool wqe_skip; + uint16_t wqe_skip; uint8_t spb_drop_pc; uint8_t lpb_drop_pc; bool set_soft_exp_poll; diff --git a/drivers/common/cnxk/roc_nix_inl_priv.h b/drivers/common/cnxk/roc_nix_inl_priv.h index d61c7b2..a775efc 100644 --- a/drivers/common/cnxk/roc_nix_inl_priv.h +++ b/drivers/common/cnxk/roc_nix_inl_priv.h @@ -84,7 +84,7 @@ struct nix_inl_dev { uint32_t ipsec_in_max_spi; uint32_t inb_spi_mask; bool attach_cptlf; - bool wqe_skip; + uint16_t wqe_skip; bool ts_ena; }; diff --git a/drivers/event/cnxk/cnxk_eventdev_adptr.c b/drivers/event/cnxk/cnxk_eventdev_adptr.c index fa96090..cf5b1dd 100644 --- a/drivers/event/cnxk/cnxk_eventdev_adptr.c +++ b/drivers/event/cnxk/cnxk_eventdev_adptr.c @@ -125,6 +125,7 @@ cnxk_sso_rxq_enable(struct cnxk_eth_dev *cnxk_eth_dev, uint16_t rq_id, { struct roc_nix *nix = &cnxk_eth_dev->nix; struct roc_nix_rq *rq; + uint16_t wqe_skip; int rc; rq = &cnxk_eth_dev->rqs[rq_id]; @@ -132,7 +133,9 @@ cnxk_sso_rxq_enable(struct cnxk_eth_dev *cnxk_eth_dev, uint16_t rq_id, rq->tt = ev->sched_type; rq->hwgrp = ev->queue_id; rq->flow_tag_width = 20; - rq->wqe_skip = 1; + wqe_skip = RTE_ALIGN_CEIL(sizeof(struct rte_mbuf), ROC_CACHE_LINE_SZ); + wqe_skip = wqe_skip / ROC_CACHE_LINE_SZ; + rq->wqe_skip = wqe_skip; rq->tag_mask = (port_id & 0xF) << 20; rq->tag_mask |= (((port_id >> 4) & 0xF) | (RTE_EVENT_TYPE_ETHDEV << 4)) << 24; diff --git a/drivers/net/cnxk/cnxk_ethdev_sec.c b/drivers/net/cnxk/cnxk_ethdev_sec.c index d01ebb4..1de3454 100644 --- a/drivers/net/cnxk/cnxk_ethdev_sec.c +++ b/drivers/net/cnxk/cnxk_ethdev_sec.c @@ -264,6 +264,7 @@ cnxk_nix_inl_dev_probe(struct rte_pci_driver *pci_drv, char name[CNXK_NIX_INL_DEV_NAME_LEN]; struct roc_nix_inl_dev *inl_dev; const struct rte_memzone *mz; + uint16_t wqe_skip; int rc = -ENOMEM; RTE_SET_USED(pci_drv); @@ -295,7 +296,9 @@ cnxk_nix_inl_dev_probe(struct rte_pci_driver *pci_drv, inl_dev->attach_cptlf = true; /* WQE skip is one for DPDK */ - inl_dev->wqe_skip = true; + wqe_skip = RTE_ALIGN_CEIL(sizeof(struct rte_mbuf), ROC_CACHE_LINE_SZ); + wqe_skip = wqe_skip / ROC_CACHE_LINE_SZ; + inl_dev->wqe_skip = wqe_skip; inl_dev->set_soft_exp_poll = true; rc = roc_nix_inl_dev_init(inl_dev); if (rc) { -- 2.8.4