From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DB66AA00C2; Thu, 16 Jun 2022 18:31:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C249440689; Thu, 16 Jun 2022 18:31:17 +0200 (CEST) Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by mails.dpdk.org (Postfix) with ESMTP id A813A4014F for <dev@dpdk.org>; Thu, 16 Jun 2022 18:31:15 +0200 (CEST) Received: by mail-pj1-f50.google.com with SMTP id t3-20020a17090a510300b001ea87ef9a3dso1937393pjh.4 for <dev@dpdk.org>; Thu, 16 Jun 2022 09:31:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=H2VXBzI42rD0w3oI1f5FyQlPxiQP3r+aGfkPgjKTJ9Q=; b=ckzpGrUgIDBOYQQ4z9FEyVPrdidarsLn5+UTZ7T+8OYS0r738S4dJ7K2cYFNzWdzos xANHBdtUSA4bNDA9G2vpwS4O7zy4/yE7ArKchvJBTBHdsfsf9OVrc7nY6XZ2kKJIsvC1 g/N0YQHDIauzn3ZZV5k/90IRab8LDdZO19EDMFev9Rc7A5ZHZy5uRHGEddupQbDZpqu2 V/dkfMaDW25gc5LXlYsXMATowZsfnBEUrFsQYF662ZZqPN1m8rDxVr5A/CCSQc6q1hjz 4mlQeGai2vMYDeKa+UALfwSCMhQ6/fJXHha7qsVSPPp1hxK+oUZAdZie6S0mkTV+WsEh 7pog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=H2VXBzI42rD0w3oI1f5FyQlPxiQP3r+aGfkPgjKTJ9Q=; b=y41PABKUzJVSk/g4m1olaAkrkjmSEGj1LaUCOd/Cqfj0D5QpgP8/d1Mt63wyvOmNT+ u+EVGqAgfT2RKXXQrXLScvpectYbnyc6MRhUQBzWvOmdPPifq2uMSAUj0IlrNNTUrAMM hVmLgcG9xrBySuuS4K/gMjf6QvSTm8BU1YMwaPQjVkzFZpGWQO8E6GibE/FmpsoWFUub gK8NwTeSOm8IY55vp9IaZvHdCsGALfjWi5pamxoygFimrwFtJZurbNwShXz4yq8EKD3M yLvoKFvaF+70zRb/jsiOuNlY7Xx1mH+fJZm2yn1VCXQOuJx2TEV+jWHL4Q+jWd1RqpZF Mt8g== X-Gm-Message-State: AJIora8xzX5wmXut7rV6seR7dAjmBmyCMkJeWP8asyljJin5MpeM5UeC FoXbI0V/eQL5MCdLDg81IWSUGQ== X-Google-Smtp-Source: AGRyM1sHFybh7OG7SfdO49Grm4lue/1dJeAB0W5nDmFrmkTdpiWeHwJmzlwBolRtUToVtx7TVrgopw== X-Received: by 2002:a17:902:6901:b0:168:9bb4:7adb with SMTP id j1-20020a170902690100b001689bb47adbmr5591788plk.147.1655397074669; Thu, 16 Jun 2022 09:31:14 -0700 (PDT) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id f16-20020a633810000000b003fd9b8b865dsm2005108pga.0.2022.06.16.09.31.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jun 2022 09:31:14 -0700 (PDT) Date: Thu, 16 Jun 2022 09:31:11 -0700 From: Stephen Hemminger <stephen@networkplumber.org> To: David Marchand <david.marchand@redhat.com> Cc: Huichao Cai <chcchc88@163.com>, Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>, dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net> Subject: Re: [PATCH v7] ip_frag: add IPv4 options fragment and test data Message-ID: <20220616093111.763435f4@hermes.local> In-Reply-To: <CAJFAV8yA7VfqZfr4eBKJmtPC6z=Po9DM-0k=D-2BrejC0T9Q0Q@mail.gmail.com> References: <1649649325-1942-1-git-send-email-chcchc88@163.com> <1649993210-1854-1-git-send-email-chcchc88@163.com> <CAJFAV8yA7VfqZfr4eBKJmtPC6z=Po9DM-0k=D-2BrejC0T9Q0Q@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Thu, 16 Jun 2022 17:10:46 +0200 David Marchand <david.marchand@redhat.com> wrote: > On Fri, Apr 15, 2022 at 5:27 AM Huichao Cai <chcchc88@163.com> wrote: > > > > According to RFC791,the options may appear or not in datagrams. > > They must be implemented by all IP modules (host and gateways). > > What is optional is their transmission in any particular datagram, > > not their implementation.So we have to deal with it during the > > fragmenting process.Add some test data for the IPv4 header optional > > field fragmenting. > > > > Signed-off-by: Huichao Cai <chcchc88@163.com> > > gcc-12 raises warnings on both the unit test code and the library code. > See below. Since the copies will all be short why bother using rte_memcpy() all over the place. Especially in the test code, just use memcpy().