* [PATCH] vhost: fix missing statistics update
@ 2022-06-16 9:36 xuan.ding
2022-06-16 9:44 ` [PATCH v2] " xuan.ding
0 siblings, 1 reply; 5+ messages in thread
From: xuan.ding @ 2022-06-16 9:36 UTC (permalink / raw)
To: maxime.coquelin, chenbo.xia; +Cc: dev, jiayu.hu, wenwux.ma, Xuan Ding, stable
From: Xuan Ding <xuan.ding@intel.com>
This patch adds missing per-virtqueue statistics in async dequeue path.
Fixes: 84d5204310d7("vhost: support async dequeue for split ring")
Cc: stable@dpdk.org
Signed-off-by: Xuan Ding <xuan.ding@intel.com>
---
lib/vhost/virtio_net.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c
index 68a26eb17d..a5e510c51e 100644
--- a/lib/vhost/virtio_net.c
+++ b/lib/vhost/virtio_net.c
@@ -3538,6 +3538,7 @@ rte_vhost_async_try_dequeue_burst(int vid, uint16_t queue_id,
* learning table will get updated first.
*/
pkts[0] = rarp_mbuf;
+ vhost_queue_stats_update(dev, vq, pkts, 1);
pkts++;
count -= 1;
}
@@ -3562,6 +3563,7 @@ rte_vhost_async_try_dequeue_burst(int vid, uint16_t queue_id,
count, dma_id, vchan_id);
*nr_inflight = vq->async->pkts_inflight_n;
+ vhost_queue_stats_update(dev, vq, pkts, count);
out:
if (dev->features & (1ULL << VIRTIO_F_IOMMU_PLATFORM))
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] vhost: fix missing statistics update
2022-06-16 9:36 [PATCH] vhost: fix missing statistics update xuan.ding
@ 2022-06-16 9:44 ` xuan.ding
2022-06-17 5:19 ` Ling, WeiX
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: xuan.ding @ 2022-06-16 9:44 UTC (permalink / raw)
To: maxime.coquelin, chenbo.xia; +Cc: dev, jiayu.hu, wenwux.ma, Xuan Ding
From: Xuan Ding <xuan.ding@intel.com>
This patch adds missing per-virtqueue statistics in async dequeue path.
Fixes: 84d5204310d7("vhost: support async dequeue for split ring")
Signed-off-by: Xuan Ding <xuan.ding@intel.com>
---
v2:
* Since this issue was introduced and fixed in same release,
no need to add cc stable.
---
lib/vhost/virtio_net.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c
index 68a26eb17d..a5e510c51e 100644
--- a/lib/vhost/virtio_net.c
+++ b/lib/vhost/virtio_net.c
@@ -3538,6 +3538,7 @@ rte_vhost_async_try_dequeue_burst(int vid, uint16_t queue_id,
* learning table will get updated first.
*/
pkts[0] = rarp_mbuf;
+ vhost_queue_stats_update(dev, vq, pkts, 1);
pkts++;
count -= 1;
}
@@ -3562,6 +3563,7 @@ rte_vhost_async_try_dequeue_burst(int vid, uint16_t queue_id,
count, dma_id, vchan_id);
*nr_inflight = vq->async->pkts_inflight_n;
+ vhost_queue_stats_update(dev, vq, pkts, count);
out:
if (dev->features & (1ULL << VIRTIO_F_IOMMU_PLATFORM))
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH v2] vhost: fix missing statistics update
2022-06-16 9:44 ` [PATCH v2] " xuan.ding
@ 2022-06-17 5:19 ` Ling, WeiX
2022-06-17 5:35 ` David Marchand
2022-06-17 14:08 ` Maxime Coquelin
2 siblings, 0 replies; 5+ messages in thread
From: Ling, WeiX @ 2022-06-17 5:19 UTC (permalink / raw)
To: Ding, Xuan, maxime.coquelin, Xia, Chenbo
Cc: dev, Hu, Jiayu, Ma, WenwuX, Ding, Xuan
> -----Original Message-----
> From: xuan.ding@intel.com <xuan.ding@intel.com>
> Sent: Thursday, June 16, 2022 5:45 PM
> To: maxime.coquelin@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>
> Cc: dev@dpdk.org; Hu, Jiayu <jiayu.hu@intel.com>; Ma, WenwuX
> <wenwux.ma@intel.com>; Ding, Xuan <xuan.ding@intel.com>
> Subject: [PATCH v2] vhost: fix missing statistics update
>
> From: Xuan Ding <xuan.ding@intel.com>
>
> This patch adds missing per-virtqueue statistics in async dequeue path.
>
> Fixes: 84d5204310d7("vhost: support async dequeue for split ring")
>
> Signed-off-by: Xuan Ding <xuan.ding@intel.com>
> ---
>
> v2:
> * Since this issue was introduced and fixed in same release, no need to add
> cc stable.
> ---
Tested-by: Wei Ling <weix.ling@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] vhost: fix missing statistics update
2022-06-16 9:44 ` [PATCH v2] " xuan.ding
2022-06-17 5:19 ` Ling, WeiX
@ 2022-06-17 5:35 ` David Marchand
2022-06-17 14:08 ` Maxime Coquelin
2 siblings, 0 replies; 5+ messages in thread
From: David Marchand @ 2022-06-17 5:35 UTC (permalink / raw)
To: Xuan Ding; +Cc: Maxime Coquelin, Xia, Chenbo, dev, Jiayu Hu, Ma, WenwuX
On Thu, Jun 16, 2022 at 11:47 AM <xuan.ding@intel.com> wrote:
>
> From: Xuan Ding <xuan.ding@intel.com>
>
> This patch adds missing per-virtqueue statistics in async dequeue path.
This would not happen if the async code was better integrated with the
sync code.
>
> Fixes: 84d5204310d7("vhost: support async dequeue for split ring")
>
> Signed-off-by: Xuan Ding <xuan.ding@intel.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] vhost: fix missing statistics update
2022-06-16 9:44 ` [PATCH v2] " xuan.ding
2022-06-17 5:19 ` Ling, WeiX
2022-06-17 5:35 ` David Marchand
@ 2022-06-17 14:08 ` Maxime Coquelin
2 siblings, 0 replies; 5+ messages in thread
From: Maxime Coquelin @ 2022-06-17 14:08 UTC (permalink / raw)
To: xuan.ding, chenbo.xia; +Cc: dev, jiayu.hu, wenwux.ma
On 6/16/22 11:44, xuan.ding@intel.com wrote:
> From: Xuan Ding <xuan.ding@intel.com>
>
> This patch adds missing per-virtqueue statistics in async dequeue path.
>
> Fixes: 84d5204310d7("vhost: support async dequeue for split ring")
>
> Signed-off-by: Xuan Ding <xuan.ding@intel.com>
> ---
>
> v2:
> * Since this issue was introduced and fixed in same release,
> no need to add cc stable.
> ---
> lib/vhost/virtio_net.c | 2 ++
> 1 file changed, 2 insertions(+)
>
Applied to dpdk-next-virtio/main.
Thanks,
Maxime
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-06-17 14:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-16 9:36 [PATCH] vhost: fix missing statistics update xuan.ding
2022-06-16 9:44 ` [PATCH v2] " xuan.ding
2022-06-17 5:19 ` Ling, WeiX
2022-06-17 5:35 ` David Marchand
2022-06-17 14:08 ` Maxime Coquelin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).