From: Gregory Etelson <getelson@nvidia.com>
To: <dev@dpdk.org>, <getelson@nvidia.com>
Cc: <rasland@nvidia.com>, <stable@dpdk.org>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Olivier Matz <olivier.matz@6wind.com>,
Ferruh Yigit <ferruh.yigit@intel.com>
Subject: [PATCH v2 1/2] net: fix GTP PSC headers
Date: Thu, 16 Jun 2022 21:01:03 +0300 [thread overview]
Message-ID: <20220616180105.8839-1-getelson@nvidia.com> (raw)
In-Reply-To: <20220616093417.27843-1-getelson@nvidia.com>
Fix bitmap fields order in little endian section of GTP PSC headers.
Fixes: e8ca1479cdc4 ("net: add extension header for GTP PSC")
cc: stable@dpdk.org
Signed-off-by: Gregory Etelson <getelson@nvidia.com>
Reviewed-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
---
v2:
---
lib/net/rte_gtp.h | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/lib/net/rte_gtp.h b/lib/net/rte_gtp.h
index dca940c2c5..9849872366 100644
--- a/lib/net/rte_gtp.h
+++ b/lib/net/rte_gtp.h
@@ -75,11 +75,11 @@ struct rte_gtp_psc_generic_hdr {
uint8_t spare:2; /**< type specific spare bits */
uint8_t qfi:6; /**< Qos Flow Identifier */
#else
- uint8_t qfi:6; /**< Qos Flow Identifier */
- uint8_t spare:2; /**< type specific spare bits */
uint8_t pad:3; /**< type specific pad bits */
uint8_t qmp:1; /**< Qos Monitoring Packet */
uint8_t type:4; /**< PDU type */
+ uint8_t qfi:6; /**< Qos Flow Identifier */
+ uint8_t spare:2; /**< type specific spare bits */
#endif
uint8_t data[0]; /**< variable length data fields */
} __rte_packed;
@@ -100,12 +100,13 @@ struct rte_gtp_psc_type0_hdr {
uint8_t rqi:1; /**< Reflective Qos Indicator */
uint8_t qfi:6; /**< Qos Flow Identifier */
#else
- uint8_t qfi:6; /**< Qos Flow Identifier */
- uint8_t rqi:1; /**< Reflective Qos Indicator */
- uint8_t ppp:1; /**< Paging policy presence */
uint8_t spare_dl1:2; /**< spare down link bits */
uint8_t snp:1; /**< Sequence number presence */
+ uint8_t qmp:1; /**< Qos Monitoring Packet */
uint8_t type:4; /**< PDU type */
+ uint8_t qfi:6; /**< Qos Flow Identifier */
+ uint8_t rqi:1; /**< Reflective Qos Indicator */
+ uint8_t ppp:1; /**< Paging policy presence */
#endif
uint8_t data[0]; /**< variable length data fields */
} __rte_packed;
@@ -127,14 +128,14 @@ struct rte_gtp_psc_type1_hdr {
uint8_t spare_ul2:1; /**< spare up link bits */
uint8_t qfi:6; /**< Qos Flow Identifier */
#else
- uint8_t qfi:6; /**< Qos Flow Identifier */
- uint8_t spare_ul2:1; /**< spare up link bits */
- uint8_t n_delay_ind:1; /**< N3/N9 delay result presence */
uint8_t snp:1; /**< Sequence number presence ul */
uint8_t ul_delay_ind:1; /**< ul delay result presence */
uint8_t dl_delay_ind:1; /**< dl delay result presence */
uint8_t qmp:1; /**< Qos Monitoring Packet */
uint8_t type:4; /**< PDU type */
+ uint8_t qfi:6; /**< Qos Flow Identifier */
+ uint8_t spare_ul2:1; /**< spare up link bits */
+ uint8_t n_delay_ind:1; /**< N3/N9 delay result presence */
#endif
uint8_t data[0]; /**< variable length data fields */
} __rte_packed;
--
2.34.1
next prev parent reply other threads:[~2022-06-16 18:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 9:34 [PATCH " Gregory Etelson
2022-06-16 9:34 ` [PATCH 2/2] app/testpmd: fix GTP PSC raw processing Gregory Etelson
2022-06-16 18:01 ` Gregory Etelson [this message]
2022-06-16 18:01 ` [PATCH v2 " Gregory Etelson
2022-06-21 9:16 ` Singh, Aman Deep
2022-06-21 13:45 ` [PATCH v2 1/2] net: fix GTP PSC headers Singh, Aman Deep
2022-06-23 11:38 ` Andrew Rybchenko
2022-06-23 11:53 ` Andrew Rybchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220616180105.8839-1-getelson@nvidia.com \
--to=getelson@nvidia.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=olivier.matz@6wind.com \
--cc=rasland@nvidia.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).