From: Gregory Etelson <getelson@nvidia.com>
To: <dev@dpdk.org>, <getelson@nvidia.com>
Cc: <rasland@nvidia.com>, <stable@dpdk.org>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Ori Kam <orika@nvidia.com>, Xiaoyun Li <xiaoyun.li@intel.com>,
Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>
Subject: [PATCH v2 2/2] app/testpmd: fix GTP PSC raw processing
Date: Thu, 16 Jun 2022 21:01:04 +0300 [thread overview]
Message-ID: <20220616180105.8839-2-getelson@nvidia.com> (raw)
In-Reply-To: <20220616180105.8839-1-getelson@nvidia.com>
Use generic GTP PSC header definition in raw handler.
Fixes: 9213c50e36fa ("app/testpmd: support GTP PSC option in raw sets")
cc: stable@dpdk.org
Signed-off-by: Gregory Etelson <getelson@nvidia.com>
Reviewed-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
---
v2: fix raw GTP PSC object creation.
---
app/test-pmd/cmdline_flow.c | 20 +++++++-------------
1 file changed, 7 insertions(+), 13 deletions(-)
diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index cfd55c598d..6cb1173385 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -11029,19 +11029,13 @@ cmd_set_raw_parsed(const struct buffer *in)
} else {
const struct rte_flow_item_gtp_psc
*opt = item->spec;
- struct {
- uint8_t len;
- uint8_t pdu_type:4;
- uint8_t qfi:6;
- uint8_t next;
- } psc;
- psc.len = sizeof(psc) / 4;
- psc.pdu_type = opt->hdr.type;
- psc.qfi = opt->hdr.qfi;
- psc.next = 0;
- *total_size += sizeof(psc);
- rte_memcpy(data_tail - (*total_size),
- &psc, sizeof(psc));
+ struct rte_gtp_psc_generic_hdr *hdr;
+
+ *total_size += RTE_ALIGN(sizeof(hdr),
+ sizeof(int32_t));
+ hdr = (typeof(hdr))(data_tail - (*total_size));
+ *hdr = opt->hdr;
+ hdr->ext_hdr_len = 1;
gtp_psc = i;
size = 0;
}
--
2.34.1
next prev parent reply other threads:[~2022-06-16 18:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 9:34 [PATCH 1/2] net: fix GTP PSC headers Gregory Etelson
2022-06-16 9:34 ` [PATCH 2/2] app/testpmd: fix GTP PSC raw processing Gregory Etelson
2022-06-16 18:01 ` [PATCH v2 1/2] net: fix GTP PSC headers Gregory Etelson
2022-06-16 18:01 ` Gregory Etelson [this message]
2022-06-21 9:16 ` [PATCH v2 2/2] app/testpmd: fix GTP PSC raw processing Singh, Aman Deep
2022-06-21 13:45 ` [PATCH v2 1/2] net: fix GTP PSC headers Singh, Aman Deep
2022-06-23 11:38 ` Andrew Rybchenko
2022-06-23 11:53 ` Andrew Rybchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220616180105.8839-2-getelson@nvidia.com \
--to=getelson@nvidia.com \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
--cc=xiaoyun.li@intel.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).