From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 935C2A00C2; Fri, 17 Jun 2022 04:35:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A919440698; Fri, 17 Jun 2022 04:35:52 +0200 (CEST) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 80BD240689 for ; Fri, 17 Jun 2022 04:35:51 +0200 (CEST) Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4LPNNs6HtszSgxJ; Fri, 17 Jun 2022 10:32:29 +0800 (CST) Received: from localhost.localdomain (10.67.165.24) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 17 Jun 2022 10:35:37 +0800 From: Chengwen Feng To: , , CC: , , Subject: [PATCH v3 2/4] eal: fix errno not set if strftime return zero Date: Fri, 17 Jun 2022 10:29:11 +0800 Message-ID: <20220617022913.47564-3-fengchengwen@huawei.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20220617022913.47564-1-fengchengwen@huawei.com> References: <20220607120014.49823-1-fengchengwen@huawei.com> <20220617022913.47564-1-fengchengwen@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.67.165.24] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The trace_session_name_generate() takes errno as the return value, but the errno was not set if strftime return zero, the previously set errno is returned in this case, this will result in inaccurate prompting. This patch sets errno to ENOSPC if strftime return zero to fix it. Fixes: 321dd5f8fa62 ("trace: add internal init and fini interface") Cc: stable@dpdk.org Signed-off-by: Chengwen Feng --- lib/eal/common/eal_common_trace_utils.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/eal/common/eal_common_trace_utils.c b/lib/eal/common/eal_common_trace_utils.c index 64f58fb66a..09f97d3c34 100644 --- a/lib/eal/common/eal_common_trace_utils.c +++ b/lib/eal/common/eal_common_trace_utils.c @@ -109,8 +109,10 @@ trace_session_name_generate(char *trace_dir) rc = strftime(trace_dir + rc, TRACE_DIR_STR_LEN - rc, "%Y-%m-%d-%p-%I-%M-%S", tm_result); - if (rc == 0) + if (rc == 0) { + errno = ENOSPC; goto fail; + } return rc; fail: -- 2.33.0