DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stanislaw Kardach <kda@semihalf.com>
To: Ruifeng Wang <ruifeng.wang@arm.com>,
	David Christensen <drc@linux.vnet.ibm.com>
Cc: Stanislaw Kardach <kda@semihalf.com>,
	dev@dpdk.org, upstream@semihalf.com
Subject: [PATCH 2/2] ci: use crossbuild-essential packages
Date: Tue, 21 Jun 2022 14:28:24 +0200	[thread overview]
Message-ID: <20220621122824.187905-3-kda@semihalf.com> (raw)
In-Reply-To: <20220621122824.187905-1-kda@semihalf.com>

The crossbuild-essential-<arch> packages contain all necessary
dependencies to cross-compile binaries for a given architecture
including C and C++ compilers. Therefore use those instead of listing
packages directly. This way C++ compiler is also installed and C++
include checks will be checked in CI for PowerPC and ARM.

Signed-off-by: Stanislaw Kardach <kda@semihalf.com>
---
 .github/workflows/build.yml | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index c0d2829d0e..1106256539 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -128,15 +128,13 @@ jobs:
       run: sudo apt install -y gcc-multilib g++-multilib
     - name: Install aarch64 cross compiling packages
       if: env.AARCH64 == 'true'
-      run: sudo apt install -y gcc-aarch64-linux-gnu libc6-dev-arm64-cross
-        pkg-config-aarch64-linux-gnu
+      run: sudo apt install -y crossbuild-essential-arm64
     - name: Install mingw cross compiling packages
       if: env.MINGW == 'true'
       run: sudo apt install -y mingw-w64 mingw-w64-tools
     - name: Install ppc64le cross compiling packages
       if: env.PPC64LE == 'true'
-      run: sudo apt install -y gcc-powerpc64le-linux-gnu libc6-dev-ppc64el-cross
-        pkg-config-powerpc-linux-gnu
+      run: sudo apt install -y crossbuild-essential-ppc64el
     - name: Install riscv64 cross compiling packages
       if: env.RISCV64 == 'true'
       run: sudo apt install -y crossbuild-essential-riscv64
-- 
2.30.2

  parent reply	other threads:[~2022-06-21 12:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-21 12:28 [PATCH 0/2] fix C++ include checks in cross-compilation Stanislaw Kardach
2022-06-21 12:28 ` [PATCH 1/2] config: Use G++ as C++ compiler Stanislaw Kardach
2022-06-21 14:25   ` Bruce Richardson
2022-06-21 19:53   ` Tyler Retzlaff
2022-06-22  5:07     ` Stanisław Kardach
2022-06-22 16:05       ` Tyler Retzlaff
2022-06-22 16:24         ` Morten Brørup
2022-06-21 12:28 ` Stanislaw Kardach [this message]
2022-06-23  8:04   ` [PATCH 2/2] ci: use crossbuild-essential packages David Marchand
2022-06-23  8:04 ` [PATCH 0/2] fix C++ include checks in cross-compilation David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220621122824.187905-3-kda@semihalf.com \
    --to=kda@semihalf.com \
    --cc=dev@dpdk.org \
    --cc=drc@linux.vnet.ibm.com \
    --cc=ruifeng.wang@arm.com \
    --cc=upstream@semihalf.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).