From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, dmitry.kozliuk@gmail.com, gakhil@marvell.com,
roy.fan.zhang@intel.com, david.marchand@redhat.com
Subject: Re: [PATCH v2 1/2] test/crypto: remove Windows conditional compilation
Date: Tue, 21 Jun 2022 09:11:56 -0700 [thread overview]
Message-ID: <20220621161156.GA18214@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <5078948.fW5hKsROvD@thomas>
On Tue, Jun 21, 2022 at 05:09:40PM +0200, Thomas Monjalon wrote:
> 20/05/2022 12:12, Tyler Retzlaff:
> > @@ -590,4 +588,3 @@ static int uplane_encap_no_integrity(uint32_t sn_size, uint8_t dir,
> > return n - i;
> > };
> >
> > -#endif /* !RTE_EXEC_ENV_WINDOWS */
>
> When removing the last line of a file, you should remove the blank line before.
> I'll fix when merging.
>
this isn't a header so unlikely to be #include in preprocessing so that
should be alright.
thanks Thomas
next prev parent reply other threads:[~2022-06-21 16:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 9:02 [PATCH 0/2] test: enable most driver tests on windows Tyler Retzlaff
2022-03-29 9:02 ` [PATCH 1/2] test/crypto: remove Windows conditional compilation Tyler Retzlaff
2022-03-29 9:02 ` [PATCH 2/2] test: enable most driver tests on Windows Tyler Retzlaff
2022-03-29 9:12 ` Thomas Monjalon
2022-03-29 9:32 ` Tyler Retzlaff
2022-03-29 11:29 ` Thomas Monjalon
2022-03-29 12:10 ` Tyler Retzlaff
2022-03-29 12:28 ` Thomas Monjalon
2022-05-20 10:12 ` [PATCH v2 0/2] test: enable most driver tests on windows Tyler Retzlaff
2022-05-20 10:12 ` [PATCH v2 1/2] test/crypto: remove Windows conditional compilation Tyler Retzlaff
2022-06-21 15:09 ` Thomas Monjalon
2022-06-21 16:11 ` Tyler Retzlaff [this message]
2022-05-20 10:12 ` [PATCH v2 2/2] test: enable most driver tests on Windows Tyler Retzlaff
2022-05-31 18:39 ` [EXT] [PATCH v2 0/2] test: enable most driver tests on windows Akhil Goyal
2022-06-21 15:13 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220621161156.GA18214@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
--to=roretzla@linux.microsoft.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=gakhil@marvell.com \
--cc=roy.fan.zhang@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).