From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 189A4A0545;
	Tue, 21 Jun 2022 18:11:59 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id A2DF94069C;
	Tue, 21 Jun 2022 18:11:58 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 6830740151
 for <dev@dpdk.org>; Tue, 21 Jun 2022 18:11:57 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id 8E3EB20C5A68; Tue, 21 Jun 2022 09:11:56 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 8E3EB20C5A68
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1655827916;
 bh=oZwwYL1DdbtqdB7e2RjFwGvpx20wGQ1niLThLUFss+w=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=hEEXsMEpcAgd0JOs1e2kkz1DAdfHMw5bBljAZufmq2PZqhtQCS1hMev4bI1zbIyqu
 x5lfS+VNgA1kk651jjsajWiBj/cSPfmf/WtA1aJ7xv0gIEcDNFtWYnz8UvHEFX6zMH
 2Ejzr4GR9cwfeE6Qh9jPdSejbaVi/yqCuJ3bbyqE=
Date: Tue, 21 Jun 2022 09:11:56 -0700
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, dmitry.kozliuk@gmail.com, gakhil@marvell.com,
 roy.fan.zhang@intel.com, david.marchand@redhat.com
Subject: Re: [PATCH v2 1/2] test/crypto: remove Windows conditional compilation
Message-ID: <20220621161156.GA18214@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1648544551-21324-1-git-send-email-roretzla@linux.microsoft.com>
 <1653041526-5872-1-git-send-email-roretzla@linux.microsoft.com>
 <1653041526-5872-2-git-send-email-roretzla@linux.microsoft.com>
 <5078948.fW5hKsROvD@thomas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5078948.fW5hKsROvD@thomas>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Tue, Jun 21, 2022 at 05:09:40PM +0200, Thomas Monjalon wrote:
> 20/05/2022 12:12, Tyler Retzlaff:
> > @@ -590,4 +588,3 @@ static int uplane_encap_no_integrity(uint32_t sn_size, uint8_t dir,
> >  	return n - i;
> >  };
> >  
> > -#endif /* !RTE_EXEC_ENV_WINDOWS */
> 
> When removing the last line of a file, you should remove the blank line before.
> I'll fix when merging.
> 

this isn't a header so unlikely to be #include in preprocessing so that
should be alright.

thanks Thomas