From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B141BA04FD; Wed, 22 Jun 2022 11:27:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A081B4069C; Wed, 22 Jun 2022 11:27:29 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id CAD9740689; Wed, 22 Jun 2022 11:27:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655890048; x=1687426048; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=NSfX7xoilEPM9oAOfXKJqcXHLb7bpFrkad2WDF2QXoQ=; b=eXJVtLCn2nrv9xGThfrF3c9oVfCyqHgS8Jx/oj40BDNO3rD9y0yJZuVx DCtivKzPz3kclxhFbzAEbhkRyaMhKUrLWLUJ2buk5CxeKOgdorOAzYHKC FE2v+JglMB/D2GRGIek/EOFXXf6DPEOgXLICgxzdD5eZlScABjkKZlWEs iuVfMDanQoQt8J57WkFxAClPI5wpsbokP/00ePrfgQGvPXEeo4fFKxufG t0uj5CGVMSAoH+cL1TrinQy+KfQ042z9g0IK7PUVzajRI0EGAhQgIFP4d j0CyvQYCe8+OLZ/pZmJkCjicxY1PU4g+JOd49mX4Ylans+hJroR7ZqI3E g==; X-IronPort-AV: E=McAfee;i="6400,9594,10385"; a="263401119" X-IronPort-AV: E=Sophos;i="5.92,212,1650956400"; d="scan'208";a="263401119" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2022 02:27:26 -0700 X-IronPort-AV: E=Sophos;i="5.92,212,1650956400"; d="scan'208";a="592094524" Received: from unknown (HELO localhost.localdomain) ([10.239.252.55]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2022 02:27:24 -0700 From: Yuan Wang To: maxime.coquelin@redhat.com, chenbo.xia@intel.com, dev@dpdk.org Cc: jiayu.hu@intel.com, xingguang.he@intel.com, cheng1.jiang@intel.com, Yuan Wang , stable@dpdk.org, Wei Ling Subject: [PATCH v4] examples/vhost: fix retry logic on eth rx path Date: Wed, 22 Jun 2022 17:25:55 +0800 Message-Id: <20220622092555.1149810-1-yuanx.wang@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220518162505.1691401-1-yuanx.wang@intel.com> References: <20220518162505.1691401-1-yuanx.wang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org drain_eth_rx() uses rte_vhost_avail_entries() to calculate the available entries to determine if a retry is required. However, this function only works with split rings, and calculating packed rings will return the wrong value and cause unnecessary retries resulting in a significant performance penalty. This patch fix that by using the difference between tx/rx burst as the retry condition. Fixes: be800696c26e ("examples/vhost: use burst enqueue and dequeue from lib") Cc: stable@dpdk.org Signed-off-by: Yuan Wang Tested-by: Wei Ling --- V4: Fix fiexs tag. V3: Fix mbuf index. V2: Rebase to 22.07 rc1. --- examples/vhost/main.c | 28 +++++++++++----------------- 1 file changed, 11 insertions(+), 17 deletions(-) diff --git a/examples/vhost/main.c b/examples/vhost/main.c index e7fee5aa1b..0fa6c096c8 100644 --- a/examples/vhost/main.c +++ b/examples/vhost/main.c @@ -634,7 +634,7 @@ us_vhost_usage(const char *prgname) { RTE_LOG(INFO, VHOST_CONFIG, "%s [EAL options] -- -p PORTMASK\n" " --vm2vm [0|1|2]\n" - " --rx_retry [0|1] --mergeable [0|1] --stats [0-N]\n" + " --rx-retry [0|1] --mergeable [0|1] --stats [0-N]\n" " --socket-file \n" " --nb-devices ND\n" " -p PORTMASK: Set mask for ports to be used by application\n" @@ -1383,27 +1383,21 @@ drain_eth_rx(struct vhost_dev *vdev) if (!rx_count) return; - /* - * When "enable_retry" is set, here we wait and retry when there - * is no enough free slots in the queue to hold @rx_count packets, - * to diminish packet loss. - */ - if (enable_retry && - unlikely(rx_count > rte_vhost_avail_entries(vdev->vid, - VIRTIO_RXQ))) { - uint32_t retry; + enqueue_count = vdev_queue_ops[vdev->vid].enqueue_pkt_burst(vdev, + VIRTIO_RXQ, pkts, rx_count); - for (retry = 0; retry < burst_rx_retry_num; retry++) { + /* Retry if necessary */ + if (enable_retry && unlikely(enqueue_count < rx_count)) { + uint32_t retry = 0; + + while (enqueue_count < rx_count && retry++ < burst_rx_retry_num) { rte_delay_us(burst_rx_delay_time); - if (rx_count <= rte_vhost_avail_entries(vdev->vid, - VIRTIO_RXQ)) - break; + enqueue_count += vdev_queue_ops[vdev->vid].enqueue_pkt_burst(vdev, + VIRTIO_RXQ, &pkts[enqueue_count], + rx_count - enqueue_count); } } - enqueue_count = vdev_queue_ops[vdev->vid].enqueue_pkt_burst(vdev, - VIRTIO_RXQ, pkts, rx_count); - if (enable_stats) { __atomic_add_fetch(&vdev->stats.rx_total_atomic, rx_count, __ATOMIC_SEQ_CST); -- 2.25.1